-
Notifications
You must be signed in to change notification settings - Fork 9
Description
Description: There is a critical redundancy issue between the current version of StellarCore and Ancient Spellcraft (v1.8.1+).
The original bug in Ancient Spellcraft has been fixed natively by its author. As a result, the ASFakePlayerFixes patch included in StellarCore is now redundant and conflicting with the base mod.
Symptoms
Severe Log Spam: Generating upwards of 10 false-positive crash reports every hour in multiplayer environments.
Config Failure: The mixin continues to fire and cause issues even when explicitly disabled in the StellarCore configuration.
Crashes: Occurs during "Create New World" or initialization (as noted in related issue #56).
Technical Details: The patch in StellarCore attempts to fix an issue that no longer exists in Ancient Spellcraft 1.8.1. Because the upstream mod now handles this logic, StellarCore's mixin is trying to apply a fix to code that has changed, resulting in instability and conflicts.
Proposed Solution: Please remove the ASFakePlayerFixes mixin entirely. It is no longer necessary for stability and is actively detrimental to modpacks running the latest version of Ancient Spellcraft.
Reference
Related to Issue #56 (This provides further context and crash logs).