Skip to content

getMoveOnsetAndPeak is not agnostic to bin_size #10

@raeedcho

Description

@raeedcho

Because it uses a differences in speed from bin to bin to find a movement onset, it's not agnostic to the bin size. For example, with smaller bins, ds should be smaller because of the smaller timestep, but min_ds doesn't reflect this reliance on timestep.

I think the fix is simply to replace the calls to diff with calls to gradient, but I'm not sure how that would change the rest of the code right now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions