From 82e4126bbe7ac6721ceff88e46d3479c7d67dec5 Mon Sep 17 00:00:00 2001 From: srrangarajan Date: Tue, 30 Sep 2025 10:22:03 -0700 Subject: [PATCH 1/2] fix hit rate metrics --- .../src/main/java/com/netflix/evcache/EVCacheImpl.java | 7 ++++++- .../java/com/netflix/evcache/EVCacheNoOpTranscoder.java | 2 ++ .../netflix/evcache/EvCacheNoSerializingTranscoder.java | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 evcache-core/src/main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java create mode 100644 evcache-core/src/main/java/com/netflix/evcache/EvCacheNoSerializingTranscoder.java diff --git a/evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java b/evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java index c3606e3f..397349fa 100644 --- a/evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java +++ b/evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java @@ -636,7 +636,12 @@ private CompletableFuture doAsyncGet(EVCacheKey evcKey, Transcoder tc) } } else { handleFinally(data, status, retryCount.get(), client, cacheOperation, start, Call.COMPLETABLE_FUTURE_GET); - handleData(data, event, evcKey, client, cacheOperation); + // Fix: Check if data is null before determining hit/miss + if (data != null) { + handleData(data, event, evcKey, client, cacheOperation); // HIT + } else { + handleMissData(event, evcKey, client, cacheOperation); // MISS + } return data; } }); diff --git a/evcache-core/src/main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java b/evcache-core/src/main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java new file mode 100644 index 00000000..bb3ae218 --- /dev/null +++ b/evcache-core/src/main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java @@ -0,0 +1,2 @@ +package com.netflix.evcache;public class EVCacheNoOpTranscoder { +} diff --git a/evcache-core/src/main/java/com/netflix/evcache/EvCacheNoSerializingTranscoder.java b/evcache-core/src/main/java/com/netflix/evcache/EvCacheNoSerializingTranscoder.java new file mode 100644 index 00000000..b8f4afdd --- /dev/null +++ b/evcache-core/src/main/java/com/netflix/evcache/EvCacheNoSerializingTranscoder.java @@ -0,0 +1,2 @@ +package com.netflix.evcache;public class EvCacheNoSerializingTranscoder { +} From c02c9b670bd349fbba1b2be5759cbaabfbb16b9d Mon Sep 17 00:00:00 2001 From: srrangarajan Date: Tue, 30 Sep 2025 10:22:46 -0700 Subject: [PATCH 2/2] fix hit rate metrics --- .../main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java | 2 -- .../com/netflix/evcache/EvCacheNoSerializingTranscoder.java | 2 -- 2 files changed, 4 deletions(-) delete mode 100644 evcache-core/src/main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java delete mode 100644 evcache-core/src/main/java/com/netflix/evcache/EvCacheNoSerializingTranscoder.java diff --git a/evcache-core/src/main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java b/evcache-core/src/main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java deleted file mode 100644 index bb3ae218..00000000 --- a/evcache-core/src/main/java/com/netflix/evcache/EVCacheNoOpTranscoder.java +++ /dev/null @@ -1,2 +0,0 @@ -package com.netflix.evcache;public class EVCacheNoOpTranscoder { -} diff --git a/evcache-core/src/main/java/com/netflix/evcache/EvCacheNoSerializingTranscoder.java b/evcache-core/src/main/java/com/netflix/evcache/EvCacheNoSerializingTranscoder.java deleted file mode 100644 index b8f4afdd..00000000 --- a/evcache-core/src/main/java/com/netflix/evcache/EvCacheNoSerializingTranscoder.java +++ /dev/null @@ -1,2 +0,0 @@ -package com.netflix.evcache;public class EvCacheNoSerializingTranscoder { -}