CustomDiscs doesn't boot on Minecraft 1.21.5

[Psora1]

First off, great plugin! Members of my server love it, and we're currently on Paper 1.21.4. Testing with Spigot 1.21.5 (for when Paper 1.21.5 releases) and the plugin refuses to boot, so I figured I'd submit a report here just so it's on your radar. The error message in console is pasted below. Thanks!

[18:11:43] [Server thread/ERROR]: Error occurred while enabling CustomDiscs v4.3 (Is it up to date?)
java.lang.IllegalStateException: Tried to access CommandAPIHandler instance, but it was null! Are you using CommandAPI features before calling CommandAPI#onLoad?
at me.navoei.customdiscsplugin.commandapi.CommandAPIHandler.getInstance(CommandAPIHandler.java:172) ~[?:?]
at me.navoei.customdiscsplugin.commandapi.CommandAPI.onEnable(CommandAPI.java:154) ~[?:?]
at me.Navoei.customdiscsplugin.CustomDiscs.onEnable(CustomDiscs.java:51) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:267) ~[spigot-api-1.21.5-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:342) ~[spigot-api-1.21.5-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:492) ~[spigot-api-1.21.5-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_21_R4.CraftServer.enablePlugin(CraftServer.java:578) ~[spigot-1.21.5-R0.1-SNAPSHOT.jar:4477-Spigot-e339edc-ba251cc]
at org.bukkit.craftbukkit.v1_21_R4.CraftServer.enablePlugins(CraftServer.java:492) ~[spigot-1.21.5-R0.1-SNAPSHOT.jar:4477-Spigot-e339edc-ba251cc]
at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:652) ~[spigot-1.21.5-R0.1-SNAPSHOT.jar:4477-Spigot-e339edc-ba251cc]
at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:437) ~[spigot-1.21.5-R0.1-SNAPSHOT.jar:4477-Spigot-e339edc-ba251cc]
at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:268) ~[spigot-1.21.5-R0.1-SNAPSHOT.jar:4477-Spigot-e339edc-ba251cc]
at net.minecraft.server.MinecraftServer.y(MinecraftServer.java:1007) ~[spigot-1.21.5-R0.1-SNAPSHOT.jar:4477-Spigot-e339edc-ba251cc]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:325) ~[spigot-1.21.5-R0.1-SNAPSHOT.jar:4477-Spigot-e339edc-ba251cc]
at java.base/java.lang.Thread.run(Unknown Source) [?:?]

[Athar42]

You get the second error, not the initial one which state (well, at least with the newly released Paper builds, in Beta) :
"me.navoei.customdiscsplugin.commandapi.exceptions.UnsupportedVersionException: This version of Minecraft is unsupported: 1.21.5"

Like previous MC updates, this plugin will need to be updated, and here it seems to be as simple as updating its dependencies (the CommandAPI).

This got an update to support 1.21.5, so should be fixable easily.

Edit : Looking at it right now, yes, easy fix on the surface, but some odd behaviors need to be checked before any release :')

Edit 2 : Pushed a PR that add support to 1.21.5, waiting on @Navoei to review if all is OK 😊

[2piotrek]

When can we expect the update?

[Athar42]

@2piotrek I could release a temporary version based on my PR, but before it get merged here, I think we should wait for Paper to be in stable release and ensure it's all working fine then (no one should update to Paper 1.21.5 yet, not for production at least (testing, OK, production, NO), it lack of some importants features).

[2piotrek]

@Athar42 If you could release a temporary version I would be very grateful

[Athar42]

@2piotrek : You can find the build here : https://github.com/Athar42/CustomDiscs/releases/tag/4.4

[2piotrek]

@Athar42 Thank you, it's working perfectly fine

[2piotrek]

Hi, Im now getting this error and plugin doesn't work anymore:

[Server thread/ERROR]: [CustomDiscs] Error initializing plugin 'custom-discs-4.4.jar' in folder 'plugins/.paper-remapped' (Is it up to date?)
java.lang.NullPointerException: Cannot invoke "java.lang.reflect.Constructor.newInstance(Object[])" because "me.navoei.customdiscsplugin.commandapi.PaperCommandRegistration.pluginCommandNodeConstructor" is null
at custom-discs-4.4.jar/me.navoei.customdiscsplugin.commandapi.PaperCommandRegistration.asPluginCommand(PaperCommandRegistration.java:168) ~[custom-discs-4.4.jar:?]
at custom-discs-4.4.jar/me.navoei.customdiscsplugin.commandapi.PaperCommandRegistration.registerCommandNode(PaperCommandRegistration.java:121) ~[custom-discs-4.4.jar:?]
at custom-discs-4.4.jar/me.navoei.customdiscsplugin.commandapi.CommandAPIBukkit.registerCommandNode(CommandAPIBukkit.java:462) ~[custom-discs-4.4.jar:?]
at custom-discs-4.4.jar/me.navoei.customdiscsplugin.commandapi.CommandAPIHandler.register(CommandAPIHandler.java:618) ~[custom-discs-4.4.jar:?]
at custom-discs-4.4.jar/me.navoei.customdiscsplugin.commandapi.AbstractCommandAPICommand.register(AbstractCommandAPICommand.java:307) ~[custom-discs-4.4.jar:?]
at custom-discs-4.4.jar/me.navoei.customdiscsplugin.commandapi.CommandAPICommand.register(CommandAPICommand.java:60) ~[custom-discs-4.4.jar:?]
at custom-discs-4.4.jar/me.Navoei.customdiscsplugin.CustomDiscs.onLoad(CustomDiscs.java:44) ~[custom-discs-4.4.jar:?]
at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:59) ~[paper-1.21.5.jar:1.21.5-75-d2ad2e6]
at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:18) ~[paper-1.21.5.jar:1.21.5-75-d2ad2e6]
at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:39) ~[paper-1.21.5.jar:1.21.5-75-d2ad2e6]
at io.papermc.paper.plugin.entrypoint.LaunchEntryPointHandler.enter(LaunchEntryPointHandler.java:39) ~[paper-1.21.5.jar:1.21.5-75-d2ad2e6]
at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:567) ~[paper-1.21.5.jar:1.21.5-75-d2ad2e6]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:235) ~[paper-1.21.5.jar:1.21.5-75-d2ad2e6]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1161) ~[paper-1.21.5.jar:1.21.5-75-d2ad2e6]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:308) ~[paper-1.21.5.jar:1.21.5-75-d2ad2e6]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

[Athar42]

Like I said earlier :

no one should update to Paper 1.21.5 yet, not for production at least (testing, OK, production, NO

I spotted that issue when I did update to the latest 1.21.5 build, but still not ready for production (You can see there that it's not yet to come out of "unstable" branch : PaperMC/Paper#12289 )

Anyways, seems it need some fix from Command API (which is a dependency).
There is a 2 days old update of it, I'll see if it fix that issue.

Edit : as expected, is fixed with the latest release of CommandAPI, can be found there : https://github.com/Athar42/CustomDiscs/releases/tag/4.4.1

[Navoei]

Thanks Athar for helping with the plugin. I am waiting for 1.21.5 to have a stable build.

[Athar42]

Yeah, just keeping it up to date with latest release, not too hard for now 😋

Still waiting on Paper to implement new functions so we can finally use custom horn the same way as the discs.

As long as I keep my MC servers running, I'll still help this project 😊

[2piotrek]

Hi, it still doesn't work on version 1.21.5, now the console doesn't show any error but when playing the disc nothing happens

[Athar42]

It's working just fine on my server (1.21.5-101).
With CD4.4 (https://github.com/Navoei/CustomDiscs/releases/tag/v4.4) and updated VoiceChat 2.5.30.

[2piotrek]

yeah sorry I investigate it further and the issue was that voicechat mod changed my headphones for some other devices

[Ibotmealot]

@Athar42 Hey, thanks for your work on keeping this plugin updated. My server used your 1.21.5 version; however, we recently updated and were wondering if you had a 1.21.6 version publicly available?