-
Notifications
You must be signed in to change notification settings - Fork 27
Description
Need tests for wind performance models
Wind performance models do not have standalone tests at the moment. There are no tests checking expected behavior (such as values being set properly) and no tests for the outputs of the wind performance models. One of the wind performance models is used in tested examples, but these mostly test outputs such as LCOE and LCOH, which also depend on cost and finance models. If something changes in the wind performance models, there is no way to gaurantee that changes to the tested outputs of LCOE, LCOH, total Capex, etc are directly due to changes in the wind performance model rather than some other accidental change or bug.
h2integrate/converters/wind/wind_plant.py:WindPlantPerformanceModelis a wrapper for the hopp wind plant model. This is used (and therefore somewhat tested) in Example 5, 6, 14, 15. This is also used in Examples 8 and 10, which do not have tests at the moment.h2integrate/converters/wind/wind_plant_pysam.py:PYSAMWindPlantPerformanceModelis a very basic implementation of the PySAM Windpower module that does not have any modifiable design parameters at a config or input level. There are no examples that use this model or tests for this model.
Proposed solution
Create unit tests for WindPlantPerformanceModel and PYSAMWindPlantPerformanceModel that should live in h2integrate/converters/wind/test/*
Alternatives considered
Additional context
This issue became clear with development done in PR #245