From 0bbdf80a5b372083647c7564d38c7fac073e8264 Mon Sep 17 00:00:00 2001 From: Miguel Pena Date: Tue, 17 Feb 2026 17:45:10 -0800 Subject: [PATCH 1/5] fixing boost version in code scan --- .github/workflows/ngwpc-cicd.yml | 45 +++++++++++++++++++++++++++----- 1 file changed, 39 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ngwpc-cicd.yml b/.github/workflows/ngwpc-cicd.yml index a02ad7048a..86809ac19f 100644 --- a/.github/workflows/ngwpc-cicd.yml +++ b/.github/workflows/ngwpc-cicd.yml @@ -130,7 +130,7 @@ jobs: - name: Install build dependencies run: | sudo apt-get update - sudo apt-get install -y cmake g++ mpi-default-bin libopenmpi-dev libboost-all-dev libudunits2-dev libnetcdf-dev libnetcdf-c++4-dev + sudo apt-get install -y cmake g++ mpi-default-bin libopenmpi-dev libudunits2-dev libnetcdf-dev libnetcdf-c++4-dev python3 -m pip install numpy==1.26.4 netcdf4 bmipy pandas torch pyyaml pyarrow #python3 -m pip install -r extern/test_bmi_py/requirements.txt #python3 -m pip install -r extern/t-route/requirements.txt @@ -139,12 +139,47 @@ jobs: uses: github/codeql-action/init@v4 with: languages: cpp - # Build (replicate your CMake build commands from Dockerfile or local builds) + - name: Install Boost 1.86.0 + shell: bash + run: | + set -euo pipefail + sudo apt-get update + sudo apt-get install -y --no-install-recommends \ + build-essential curl ca-certificates bzip2 python3-dev + + BOOST_VER=1.86.0 + BOOST_UNDERSCORE=1_86_0 + PREFIX=/opt/boost-${BOOST_VER} + + curl -fL --retry 5 --retry-delay 2 \ + -o /tmp/boost.tar.bz2 \ + "https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VER}/source/boost_${BOOST_UNDERSCORE}.tar.bz2" + + tar -xjf /tmp/boost.tar.bz2 -C /tmp + cd "/tmp/boost_${BOOST_UNDERSCORE}" + + ./bootstrap.sh --prefix="${PREFIX}" + + # Build only common compiled libs (adjust if you need more) + ./b2 -j"$(nproc)" install \ + --with-system \ + --with-filesystem \ + --with-program_options \ + --with-thread \ + --with-regex \ + --with-date_time + + echo "BOOST_ROOT=${PREFIX}" >> "$GITHUB_ENV" + echo "CMAKE_PREFIX_PATH=${PREFIX}:${CMAKE_PREFIX_PATH:-}" >> "$GITHUB_ENV" + - name: Build C++ code env: PYTHONPATH: ${{ env.PYTHONPATH }} run: | cmake -B cmake_build -S . \ + -DCMAKE_PREFIX_PATH="${BOOST_ROOT}" \ + -DBoost_NO_SYSTEM_PATHS=ON \ + -DBOOST_ROOT="${BOOST_ROOT}" \ -DPYTHON_EXECUTABLE=$(which python3) \ -DNGEN_WITH_MPI=ON \ -DNGEN_WITH_NETCDF=ON \ @@ -156,9 +191,7 @@ jobs: -DNGEN_WITH_TESTS=OFF \ -DNGEN_WITH_ROUTING=ON \ -DNGEN_QUIET=ON \ - -DNGEN_UPDATE_GIT_SUBMODULES=OFF \ - # Using boost from apt for simplicity and code scanning - #-DBOOST_ROOT=/opt/boost + -DNGEN_UPDATE_GIT_SUBMODULES=OFF cmake --build cmake_build --target all - name: Perform CodeQL Analysis uses: github/codeql-action/analyze@v4 @@ -312,7 +345,7 @@ jobs: "docker://${IMAGE_BASE}:${TEST_TAG}" "docker://${IMAGE_BASE}:${ALIAS_TAG}" # tag with 'latest' on development branch push - if [ "$GITHUB_EVENT_NAME" = "push" ] && [ "$GITHUB_REF_NAME" = "development" ]; then + if [ "$GITHUB_REF_NAME" = "development" ]; then skopeo copy \ --src-creds "${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}" \ --dest-creds "${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}" \ From c31ecd2e5dac1e2405150a70d201f20a94c71022 Mon Sep 17 00:00:00 2001 From: Miguel Pena Date: Tue, 17 Feb 2026 18:07:29 -0800 Subject: [PATCH 2/5] fixing boost version in code scan --- .github/workflows/ngwpc-cicd.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ngwpc-cicd.yml b/.github/workflows/ngwpc-cicd.yml index 86809ac19f..f7e3f05194 100644 --- a/.github/workflows/ngwpc-cicd.yml +++ b/.github/workflows/ngwpc-cicd.yml @@ -139,7 +139,7 @@ jobs: uses: github/codeql-action/init@v4 with: languages: cpp - - name: Install Boost 1.86.0 + - name: Install Boost shell: bash run: | set -euo pipefail @@ -151,9 +151,9 @@ jobs: BOOST_UNDERSCORE=1_86_0 PREFIX=/opt/boost-${BOOST_VER} - curl -fL --retry 5 --retry-delay 2 \ + curl -fL --retry 10 --retry-delay 2 --max-time 600 \ -o /tmp/boost.tar.bz2 \ - "https://boostorg.jfrog.io/artifactory/main/release/${BOOST_VER}/source/boost_${BOOST_UNDERSCORE}.tar.bz2" + "https://sourceforge.net/projects/boost/files/boost/${BOOST_VER}/boost_${BOOST_UNDERSCORE}.tar.bz2/download" tar -xjf /tmp/boost.tar.bz2 -C /tmp cd "/tmp/boost_${BOOST_UNDERSCORE}" From 767ddfe4443e5190889e63331dfc66948c1e540e Mon Sep 17 00:00:00 2001 From: Miguel Pena Date: Tue, 17 Feb 2026 19:17:11 -0800 Subject: [PATCH 3/5] fixing boost version in code scan --- .github/workflows/ngwpc-cicd.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ngwpc-cicd.yml b/.github/workflows/ngwpc-cicd.yml index f7e3f05194..a921cdeeb9 100644 --- a/.github/workflows/ngwpc-cicd.yml +++ b/.github/workflows/ngwpc-cicd.yml @@ -167,7 +167,8 @@ jobs: --with-program_options \ --with-thread \ --with-regex \ - --with-date_time + --with-date_time \ + --with-serialization echo "BOOST_ROOT=${PREFIX}" >> "$GITHUB_ENV" echo "CMAKE_PREFIX_PATH=${PREFIX}:${CMAKE_PREFIX_PATH:-}" >> "$GITHUB_ENV" From 33a77d01125c5fbc1b932780f8c242f9c6eb3b42 Mon Sep 17 00:00:00 2001 From: Miguel Pena Date: Tue, 17 Feb 2026 19:28:04 -0800 Subject: [PATCH 4/5] cicd updates --- .github/workflows/ngwpc-cicd.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ngwpc-cicd.yml b/.github/workflows/ngwpc-cicd.yml index a921cdeeb9..ba166cba2c 100644 --- a/.github/workflows/ngwpc-cicd.yml +++ b/.github/workflows/ngwpc-cicd.yml @@ -160,7 +160,7 @@ jobs: ./bootstrap.sh --prefix="${PREFIX}" - # Build only common compiled libs (adjust if you need more) + # Build Boost libraries ./b2 -j"$(nproc)" install \ --with-system \ --with-filesystem \ @@ -169,7 +169,6 @@ jobs: --with-regex \ --with-date_time \ --with-serialization - echo "BOOST_ROOT=${PREFIX}" >> "$GITHUB_ENV" echo "CMAKE_PREFIX_PATH=${PREFIX}:${CMAKE_PREFIX_PATH:-}" >> "$GITHUB_ENV" From c7d0a393fde108f52eaddb598eef6a58bf44f2e1 Mon Sep 17 00:00:00 2001 From: Miguel Pena Date: Tue, 17 Feb 2026 20:19:57 -0800 Subject: [PATCH 5/5] cicd updates --- .github/workflows/ngwpc-cicd.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ngwpc-cicd.yml b/.github/workflows/ngwpc-cicd.yml index ba166cba2c..2e293bef98 100644 --- a/.github/workflows/ngwpc-cicd.yml +++ b/.github/workflows/ngwpc-cicd.yml @@ -344,7 +344,7 @@ jobs: --all \ "docker://${IMAGE_BASE}:${TEST_TAG}" "docker://${IMAGE_BASE}:${ALIAS_TAG}" - # tag with 'latest' on development branch push + # tag with 'latest' on development branch if [ "$GITHUB_REF_NAME" = "development" ]; then skopeo copy \ --src-creds "${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}" \