Skip to content

Misleading comment #28

@scottctaylor12

Description

@scottctaylor12

Misleading Comment

I am using the Python mythic-container v0.6.0 package.

In the SendMythicRPCOperationEventLogCreate code, there is a misleading comment on line 19:

MessageLevel: str = "info",  # info, debug, auth, api, agent_message

However, MessageLevel actually accepts info, warning, and debug according to the documentation (which aligns with my testing):
https://docs.mythic-c2.net/mythicrpc/mythicrpc#sendmythicrpcoperationeventlogcreate

https://github.com/MythicMeta/MythicContainerPyPi/blob/fed745ef3e0cf52770f32f0f937e22d96ee77a60/mythic_container/MythicGoRPC/send_mythic_rpc_operationeventlog_create.py#L19C18-L19C30

Unused field

As an aside, the Warning field is not processed when set. For example, I set MessageLevel to "info" and Warning to True, but the message did not appear as a warning in the console. Alternatively, I set the MessageLevel to "warning" and Warning to False, but the message appears as a warning.

class MythicRPCOperationEventLogCreateMessage:
    def __init__(self,
                 TaskID: int = None,
                 CallbackID: int = None,
                 AgentCallbackID: str = None,
                 OperationID: int = None,
                 Message: str = None,
                 MessageLevel: str = "info",  # info, debug, auth, api, agent_message
                 Warning: bool = False,
                 **kwargs):

That said, is the Warning field necessary?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions