Review

[gabyx]

Hi, we eare using so far your nice effort here in this repository as external source, and we kind of reviewed it a bit. We came across the following:

• Global variables NINJA_PATH should be documented what they are supposed to do, there are some more.

• It would be really nice, to have only functions in your include cmake files , e.g. NuGet.cmake etc...
  and include them and then use the functions in the corresponding toolchain. No global logic inside the includes, so that other users can also use these functions. IMO not good.

• Maybe also structure the files into msc++ stands for MS standard library, not using Windows because its clear that this repo is about windows toolchains )

  • toolchain/msvc-msc++.cmake (wouldn't use multiple dots in filenames..)
  • toolchain/clang-msc++.cmake
  • toolchain/clang-libstdc++.cmake (as a thought: tdm-gcc)

  Includes:

  • toolchain/common/Ninja.cmake etc...
  • toolchain/support/...

• Another toolchain we were thinking of was

Would be cool to see these improvements.

[MarkSchofield]

Thanks for the review, @gabyx. Sorry I haven't had a chance to work through the feedback, but it all looks reasonable. I'll try and take a look shortly.

[MarkSchofield]

I think it'll take a few transforms to encapsulate better. Some I'll track as separate issues (for example, I just filed #27), where I need to add functionality to better encapsulate.