Godots crashes if a project in the Projects list has a UID icon, but the .godot cache folder for that project has been cleared

[comfiestsofa]

The UID icon reading feature in #135 and #138 is a really nice addition, but I've found that it will cause Godots to crash if any project in the list has its .godot cache folder cleared.

How to reproduce:

• Have a Godot project with a UID icon
• Delete .godot folder in the project to clear its cache (cleaning a Git repo will do this)
• Godots crashes instantly on launch

To fix this, open the Godot Editor manually and open up the project to regenerate the cache.

Ideally the behaviour from the Godot Editor should be replicated, where if a UID icon cannot be found it just uses the default icon.

[etherealxx]

Hey, i could recreate this!
and it works again if either i move my problematic project away from the scanned directory, or just like author said, regenerate the cache. (was made with custom built 4.5.2.rc)

here's the Godots' error log btw

Godot Engine v4.5.stable.official.876b29033 - https://godotengine.org
WARNING: Unable to initialize Windows common controls. Native dialogs may not work properly.
   at: DisplayServerWindows (platform/windows/display_server_windows.cpp:6940)
OpenGL API 3.3.0 Core Profile Context 25.9.1.250822 - Compatibility - Using Device: ATI Technologies Inc. - AMD Radeon(TM) Graphics

Run window mode
ERROR: Invalid new child index: 5.
   at: move_child (scene/main/node.cpp:507)

[DeeJayLSP]

Ideally the behaviour from the Godot Editor should be replicated, where if a UID icon cannot be found it just uses the default icon.

Oops, my mistake.

When I wrote #135, I indeed tried to follow Godot's own step-by-step as closely as possible, but didn't realize the result of FileAccess.open() would be that different from the C++ version.

A one-line fix is linked up there.