Skip to content

Commit a33b0cd

Browse files
committed
Fix in busy wait generated inside BoardConfiguration Window
* Also, the toy_problem was modified to add a component of noise to the problem
1 parent 20140d9 commit a33b0cd

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

MLC/GUI/Experiment/ArduinoConfigManager/ArduinoBoardManager.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ def __init__(self, protocol_config, serial_config, close_handler, parent_win=Non
4444
self.__connection_config = serial_config
4545
self.__main_window = BoardConfigurationWindow(self, boards.types, self.__setup, parent=parent_win)
4646
self.__connectino_status = None
47-
self.__sch = QTimer()
4847
self.PARITY_BITS = [serial.PARITY_NONE, serial.PARITY_EVEN,
4948
serial.PARITY_EVEN, serial.PARITY_MARK, serial.PARITY_SPACE]
5049
self.STOP_BITS = [serial.STOPBITS_ONE, serial.STOPBITS_ONE_POINT_FIVE, serial.STOPBITS_TWO]
@@ -72,7 +71,6 @@ def start_connection(self):
7271

7372
def start(self):
7473
self.__main_window.show()
75-
self.__sch.start()
7674

7775
def insert_digital_pin(self, pin_index, pin, type_idx):
7876
if pin_index < 0:
@@ -134,13 +132,9 @@ def remove_analog_pin(self, pin):
134132
self.__setup.analog_output_pins.remove(pin)
135133

136134
def check_connection(self):
137-
self.__connection_status = self.__main_window.create_connection_dialog(
138-
)
135+
self.__connection_status = self.__main_window.create_connection_dialog()
139136
conn_checker = threading.Thread(target=self.conn_check)
140137
conn_checker.start()
141-
# self.__sch.push_task(self.dummy_conn_check)
142-
# self.__sch.timeout.connect(self.dummy_conn_check)
143-
# self.__sch.start(100)
144138
self.__connection_status.exec_()
145139
conn_checker.join()
146140

0 commit comments

Comments
 (0)