From df81b89c9ac63c16c08d8daf1e835be16ae433be Mon Sep 17 00:00:00 2001 From: Nils Schimmelmann Date: Fri, 19 Dec 2025 15:40:27 -0600 Subject: [PATCH 1/2] add back Visual C++ Redistributable to NSIS This broke when we added AppX support in a86804cc6c1f57eae272a181d4e474574ea248d4 --- src/CMakeLists.txt | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 2d24b447a..22aa29011 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -1002,18 +1002,24 @@ if(WIN32) USE_SOURCE_PERMISSIONS PATTERN "*.exe" EXCLUDE ) - if(MSVC) - set(CPACK_NSIS_EXTRA_INSTALL_COMMANDS "${CPACK_NSIS_EXTRA_INSTALL_COMMANDS} - ExecWait '\\$INSTDIR\\\\vc_redist.x64.exe /q /norestart' - Delete '\\$INSTDIR\\\\vc_redist.x64.exe' - ") - endif() set(CPACK_SOURCE_GENERATOR "ZIP") - if(WITH_UPDATER) + if(PACKAGE_TYPE_NORMALIZED STREQUAL "Nsis") set(CPACK_GENERATOR "NSIS") + if(MSVC AND NOT MMAPPER_IS_DEBUG) + install(FILES + "${WINDEPLOYQT_STAGING}/vc_redist.x64.exe" + DESTINATION . + COMPONENT libraries + ) + set(CPACK_NSIS_EXTRA_INSTALL_COMMANDS "${CPACK_NSIS_EXTRA_INSTALL_COMMANDS} + ExecWait '\\$INSTDIR\\\\vc_redist.x64.exe /q /norestart' + Delete '\\$INSTDIR\\\\vc_redist.x64.exe' + ") + endif() + # Windows (NSIS) Settings set(CPACK_NSIS_EXECUTABLES_DIRECTORY ".") set(CPACK_NSIS_MENU_LINKS "mmapper.exe;MMapper") @@ -1052,7 +1058,7 @@ if(WIN32) endif() # NSIS always displays a license page set(CPACK_RESOURCE_FILE_LICENSE "${PROJECT_SOURCE_DIR}/COPYING.txt") - else() + elseif(PACKAGE_TYPE_NORMALIZED STREQUAL "AppX") # Windows AppX Settings set(CPACK_GENERATOR "External") set(APPX_NAME "${PROJECT_NAME}") From 701409f6cc9bc03b32fd7dcea90bcc6570f6d316 Mon Sep 17 00:00:00 2001 From: Nils Schimmelmann Date: Fri, 19 Dec 2025 15:54:42 -0600 Subject: [PATCH 2/2] fix version fallback when git tags are missing This helps the CI pipeline build for new contributors who did not push tags to their fork. --- CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 874af8346..e0189b41d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -219,7 +219,11 @@ if(EXISTS "${PROJECT_SOURCE_DIR}/.git") set(MMAPPER_BETA "false") else() message(STATUS "Building from branch ${GIT_BRANCH} with ref ${GIT_TAG_COMMIT_HASH}") - set(MMAPPER_VERSION_STRING "${GIT_TAG_COMMIT_HASH}") + if(NOT GIT_TAG_COMMIT_HASH MATCHES "^v") + set(MMAPPER_VERSION_STRING "v${MMAPPER_VERSION}-${GIT_TAG_COMMIT_HASH}") + else() + set(MMAPPER_VERSION_STRING "${GIT_TAG_COMMIT_HASH}") + endif() set(MMAPPER_BETA "true") endif() endif()