Rework developer mode (Non-FN)

[SaintWish]

We need to rework the developer mode (which is mostly script side) to be locked behind a server side convar, granted this should ONLY be for Non-FN servers because we don't want to allow that stuff at all on FN obviously.

To my knowledge we'll need to create the convar on the game code side then, allow scripts to be able to read the value of said convar.

Currently the old system allows anyone to run developer mode stuff as long as their SteamID is whitelisted, which makes it difficult for mappers among other developers to test stuff without recompiling the scripts to add their SteamID in.

[tschumann]

I've started having a look at this in #300 but may have some questions - looks like there's already an ms_dev_mode and various other flags around connection to FuzzNet.

[SaintWish]

Yeah a majority of the ms dev mode logic is done in the scripts and basically enable "developer cheats" which is also all done in the scripts. TBH I wouldn't even be opposed to just locking it behind sv_cheats, but IDK and haven't actually looked into the script side of it at all yet.

To clarify what I mean in the original report is, currently the developer cheats can be enabled in any server by anyone who knows the dev password (or might be by SteamID now, but same concept none the less), and I would like to basically lock those developer cheats behinds a server side cvar so not just anyone can hop in any non-FN server and use developer cheats without the server operator even knowing.

[tschumann]

Yep makes sense - what script handles the Steam ID stuff?

[SaintWish]

I'll find it today/tomorrow hopefully and get back to you.

[SaintWish]

Yep makes sense - what script handles the Steam ID stuff?

So these are the scripts that handle the developer commands: https://github.com/MSRevive/MSCScripts/tree/MSR-Scripts/scripts/developer
It seems it planned to switch to to be a SteamID system but that never happened so it still uses the old "developer password" system using dev_on <PASSWORD> (https://github.com/MSRevive/MSCScripts/blob/MSR-Scripts/scripts/developer/devcmds.script)

The plan is to allow those developer commands to be used with a server side CVAR so it's entirely up to the server. I'm not entirely sure if those commands are server side or client did or if it'd require a rewrite of that (in which case probably best to wait for the AS implementation to be finished).