-
Notifications
You must be signed in to change notification settings - Fork 0
Description
To: mad-issues@mit.edu
Cc: Oliver Thomas othomas@mit.edu
Reply-To:
From: Oliver Thomas othomas@mit.edu
Date: Wed, 9 Oct 2024 17:18:16 +0000
I’d like to start logging the value of tmp_id as returned by the card reader. Right now we're logging it if it’s not an HID reader and if the split() causes an exception. I’m thinking we want to log it right after it is set in line 200. Maybe even log it before the lower() conversion and put that in a separate statement. My thinking is we want to collect a list of many reader output values exactly as passed. We don’t need to log associated user info so there is no security risk. The collection will be helpful for automated test cases so we can send reader values at the code at random intervals for testing, given how difficult it is to volume test otherwise.