From 8bd8b912f9e50c735a03675efc5c0d6dca7a17c8 Mon Sep 17 00:00:00 2001 From: Lunarantic <26676464+Lunarantic@users.noreply.github.com> Date: Sat, 13 Oct 2018 19:13:23 -0400 Subject: [PATCH] Remove redundant check of list in getMean() --- extensions/datatypes/Lists.java | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/extensions/datatypes/Lists.java b/extensions/datatypes/Lists.java index 9ffb57f..96c1c6f 100644 --- a/extensions/datatypes/Lists.java +++ b/extensions/datatypes/Lists.java @@ -52,26 +52,10 @@ public static String getSum(List list) { This function returns the mean when a list is passed **/ public static String getMean(List list) { - if(Commons.isElementNumericalDatatype(list)) { - - BigDecimal mean = BigDecimal.ZERO; - BigDecimal sum = new BigDecimal(getSum(list)); - BigDecimal len = new BigDecimal(list.size()); - mean = sum.divide(len); - - return mean.toString(); - - } else { - StackTraceElement[] stackTraceElements = Thread.currentThread().getStackTrace(); - System.err.println(stackTraceElements[1].getClassName() + "."+ stackTraceElements[1].getMethodName() - + "() :: Should contain all elements Numerical"); - for (int i = 2; i < stackTraceElements.length; i++ ) - System.err.println(stackTraceElements[i].toString()); + String sum = getSum(list); + if (!Commons.isEmpty(sum)) { + return (new BigDecimal(sum)).divide(new BigDecimal(list.size())).toString(); } - - return null; - + return null; } - - }