Payment applied sync model not actually nullable

[sfwatanabe]

The PaymentAppliedSyncModel allows for a nullable type. Documentation indicates this is a required field.

lockstep-sdk-csharp/src/models/PaymentAppliedSyncModel.cs

Line 83 in 05fd935

public DateTime? ApplyToInvoiceDate { get; set; }

[tspence]

I have gone back and forth on this for a while! I'm not sure it makes sense to flag all required fields as non-nullable in C#. I've done some testing using example programs and I haven't settled on a perfect solution. When I tried making everything non-nullable, a lot of data structures were very hard to use because the constructors insisted on those fields being set.

Open to your ideas though!

[sfwatanabe]

That makes sense to me. As a user of the package I would find it more frustrating to be required to populate fields not currently in use. I would find it more informational if I simply received an error message back from the api.

[tspence]

Per discussion, we'd like to keep this conversation going. Right now we favor nullability, but we may make some decisions to adjust that preference in the future.

[KieranFoot]

I think you may need to settle on definition of "Required". If a field is required, it should always contain a value. Otherwise, it can be nullable.

Also, for such cases, standard practice is to set it's default value to default!. That way there are no compiler warnings relating to uninitialized or possibly null values.