From de60761cd0b877656f80f2bef61681e77fbc13ac Mon Sep 17 00:00:00 2001 From: naty55 <64107292+naty55@users.noreply.github.com> Date: Sun, 26 Apr 2020 21:05:51 +0300 Subject: [PATCH] Update weather_get.py Just tried t oconver to python 3 because python 2 is dead --- python-weather/weather_get.py | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/python-weather/weather_get.py b/python-weather/weather_get.py index ac74d45..d15302d 100644 --- a/python-weather/weather_get.py +++ b/python-weather/weather_get.py @@ -21,32 +21,29 @@ # MA 02110-1301, USA. # # -import urllib +import requests import json previous_weather_file = "weather_log.txt" previous_weather = "" try: - log = open(previous_weather_file,"r") - previous_weather = log.read() - log.close() + with open(previous_weather_file, 'r') as log: + previous_weather = log.read() except: - print "No previous data" - -f = urllib.urlopen("http://api.openweathermap.org/data/2.5/weather?q=Cheltenham,uk") -weather = f.read() - -log = open(previous_weather_file,'w') -log.write(weather) -log.close() + print("No previous data") +f = requests.get("http://api.openweathermap.org/data/2.5/weather?q=Cheltenham,uk") +weather = f.content +with open(previous_weather_file,'w') as log: + log.write(weather) + weather_json = json.loads(weather) #print weather #print weather_json['weather'] curr_temp = float(weather_json['main']['temp'])-273.13 -print "Temperature is: %.2f degrees C" % (curr_temp) +print("Temperature is: %.2f degrees C" % (curr_temp)) if (not previous_weather == ""): @@ -54,7 +51,7 @@ prev_temp = float(prev_weather_json['main']['temp'])-273.13 temp_diff = curr_temp - prev_temp - if not( temp_diff == 0.0): - print "Temperature has changed by: %.2f degrees C" % (temp_diff) + if not temp_diff == 0.0: + print("Temperature has changed by: %.2f degrees C" % (temp_diff))