Compatibility With Charm

[Kasprenius]

The title says it, for some reason I can't load charm and this together ;-; this is one of my favorite mods! Please save me!!

[KrisCris]

Crash log, or any link to the mod?

[kr-old]

Can confirm, my game launches fine if charm is disabled with allstackable enabled, and vice versa.
Crash log when both mods are enabled here: https://paste.ee/p/nR4ko
Charm Mod on CurseForge

[Kasprenius]

I actually think I know the issue, charm has its own stack modifier modules, haven’t tried yet but maybe disabling them will let Allstackable work! Or not, but what charm lets me modify is really all I wanted to anyways 😂

[KrisCris]

[00:37:48] [main/WARN]: @Redirect conflict. Skipping charm.mixins.json:stackable_enchanted_books.FixAnvilBookStackMixin from mod charm->@Redirect::anvilUpdateHook(Lnet/minecraft/class_1263;ILnet/minecraft/class_1799;)V with priority 1000, already redirected by allstackable.mixins.json:MixinAnvilScreenHandler from mod allstackable->@Redirect::decrementOne(Lnet/minecraft/class_1263;ILnet/minecraft/class_1799;Lnet/minecraft/class_1657;Lnet/minecraft/class_1799;)V with priority 1000

Critical injection failure: Redirector anvilUpdateHook(Lnet/minecraft/class_1263;ILnet/minecraft/class_1799;)V in charm.mixins.json:stackable_enchanted_books.FixAnvilBookStackMixin from mod charm failed injection check, (0/1) succeeded.

Both mods are trying to fix issues related to stacked enchanted books using on Anvil, probably that’s the reason

Update: Also the potion fix

[AstraDrift]

Fixed this by deleting anything related to stacking in charm jar (svenhjol/charm/mixin/ stackable folders) and also mixins json. Now both mods work. MC 1.18.2 Fabric
Not really a fix, I know

[KrisCris]

Fixed this by deleting anything related to stacking in charm jar (svenhjol/charm/mixin/ stackable folders) and also mixins json. Now both mods work. MC 1.18.2 Fabric Not really a fix, I know

This is definately a workaround, tho far from perfect lol. I need to figure out how to conditionally disable a mixin.

In the meantime, MAYBE instead of deleting all mixins and the json file, you can try comment out certain line of mixins (e.g. FixAnvilBookStackMixin) in that json file.
e.g.

1. Open the .jar file with an zip browser

• 

2. open charm.mixins.json with any text editor

3. remove these three lines of code:

• 

[SnowedInOwl]

So is this being worked on?

[chimericdream]

I need to figure out how to conditionally disable a mixin.

I had to do this recently, and it turned out to be much simpler than I expected. You need a mixin plugin. Here's mine.

[KrisCris]

So is this being worked on?

Yes and no... I was trying to make it working but the game keeps crashing when I launch it via IntelliJ. So I put it aside and enjoyed playing MHRiseSunbreak with my friends for almost the entire month.. LOL

I promise you I will figure it out soon :)

[KrisCris]

I need to figure out how to conditionally disable a mixin.

I had to do this recently, and it turned out to be much simpler than I expected. You need a mixin plugin. Here's mine.

Thanks man, this is really HELPFUL! Finally know how to enable the plugin in mixins.json 😂

Btw, do you know how to run Minecraft from the IDE with other mods, like charm?

[SnowedInOwl]

Ok nice LOL that sounds like something I've done but with Valorant

[KrisCris]

Ok nice LOL that sounds like something I've done but with Valorant

Can you test if the mod is now compatible with Charm? @SnowedInOwl

AllStackable-v1.5.6_CharmCompat-3-1.19.zip

[KrisCris]

https://github.com/svenhjol/Charm/issues/801

[KrisCris]

But I really think Charm should disable their anvil fix when allstackable is loaded cuz the latter includes more fixes on item usages on anvil.
Original:

• 

Allstackable Fixes:

• 
• 
• And rename vanilla stacakble items still working:
  • 

Or you can just disable their mixins by doing these #32 (comment)
charm-fabric-1.19-4.1.2_modified.zip

[SnowedInOwl]

Ok nice LOL that sounds like something I've done but with Valorant

Can you test if the mod is now compatible with Charm? @SnowedInOwl

AllStackable-v1.5.6_CharmCompat-3-1.19.zip

@KrisCris Sure sorry i was asleep when you asked but i can do that now

[SnowedInOwl]

It works fine now @KrisCris

[chimericdream]

Btw, do you know how to run Minecraft from the IDE with other mods, like charm?

Yep. Basically, you add the Maven repo for the mod in question, then add a modImplementation line in the dependencies. Here is my build.gradle file, where I'm doing that for a few dependencies. On occasion, I have added other mods (ones I want to add items for) to there to make it easier to test as I go.