Trying to run examples with devel2 branch

[Trophime]

Hi,
I would like to use ngspice 44 with pyspice.
I'm trying to run examples and I run into this kind of problems:

python spice-parser/bootstrap-example.py
2025-02-05 10:34:49,149 - PySpice.Doc.ExampleTools.find_libraries - INFO - SPICE library path is /workspaces/PySpice/examples/spice-library
2025-02-05 10:34:49,149 - PySpice.Spice.Library.Library.Library.__init__ - INFO - Initialize library...
2025-02-05 10:34:49,149 - PySpice.Spice.Library.Library.Library.scan - INFO - Scan /workspaces/PySpice/examples/spice-library...
2025-02-05 10:34:49,149 - PySpice.Spice.Library.SpiceInclude.SpiceInclude.load_yaml - INFO - Load /workspaces/PySpice/examples/spice-library/discrete-semiconductors/transistors/ptm_65nm_pmos_bulk.yaml
2025-02-05 10:34:49,150 - PySpice.Spice.Library.SpiceInclude.SpiceInclude.load_yaml - INFO - Load /workspaces/PySpice/examples/spice-library/discrete-semiconductors/transistors/ptm_65nm_nmos_bulk.yaml
2025-02-05 10:34:49,151 - PySpice.Spice.Library.SpiceInclude.SpiceInclude.load_yaml - INFO - Load /workspaces/PySpice/examples/spice-library/discrete-semiconductors/transistors/2N2222A.yaml
2025-02-05 10:34:49,152 - PySpice.Spice.Library.SpiceInclude.SpiceInclude.parse - INFO - Parse /workspaces/PySpice/examples/spice-library/discrete-semiconductors/transistors/MOSFET/irf150.lib
line=[22:22] ELEMENT / CONTROL COMMAND
    M1 9 7 8 8 MM L=100u W=100u ;  ast=M1 9 7 8 8 MM L=100u W=100u first_set_position=5
ElementData.elements=dict_keys([])
self._letter=M
Traceback (most recent call last):
  File "/workspaces/PySpice/examples/spice-parser/bootstrap-example.py", line 27, in <module>
    spice_library = SpiceLibrary(libraries_path)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Library/Library.py", line 87, in __init__
    self.scan()
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Library/Library.py", line 172, in scan
    self._handle_library(path)
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Library/Library.py", line 177, in _handle_library
    spice_include = SpiceInclude(path)
                    ^^^^^^^^^^^^^^^^^^
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Library/SpiceInclude.py", line 278, in __init__
    self.parse()
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Library/SpiceInclude.py", line 365, in parse
    spice_file = SpiceFile(self._path)
                 ^^^^^^^^^^^^^^^^^^^^^
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Parser/HighLevelParser.py", line 1278, in __init__
    self.parse_file(path)
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Parser/HighLevelParser.py", line 1167, in parse_file
    self._parse()
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Parser/HighLevelParser.py", line 1152, in _parse
    self.analyse()
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Parser/HighLevelParser.py", line 1102, in analyse
    obj = cls(line, ast)
          ^^^^^^^^^^^^^^
  File "/workspaces/PySpice/pyspicedev-env/lib/python3.11/site-packages/PySpice-1.6-py3.11.egg/PySpice/Spice/Parser/HighLevelParser.py", line 319, in __init__
    data = ElementData.elements[self._letter]
           ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
KeyError: 'M'

I haven't any idea how to fix this.
Could you help me out?
Best

[Kreijstal]

you mean the devel branch, that one was left untouched by @FabriceSalvaire, I tried to use it but I did have issues, right now I'm using patch-2 branch my goal is to eventually find time to merge the openspice changes, there are some things that do break on the openspice branch. It's not a nice situation that pyspice finds itself in, however I found that it is greatly hackable.

In you error, it seems ElementData doesn't contain nmos pmos transistors, they'd have to be added. I dont know how much the devel branch changes things from the 1.5 version, however.

[tapegoji]

The way ElementData class is handled in 1.5 is quite different. I am trying to fix this bug on my side. A few more days. I hope

[Kreijstal]

The way ElementData class is handled in 1.5 is quite different. I am trying to fix this bug on my side. A few more days. I hope

let us know how it works out for you!

[tapegoji]

@Trophime you can use this branch. I add a little fix. need more work but it's working for now

https://github.com/tapegoji/PySpice/tree/elementdata_fix

[Kreijstal]

@Trophime you can use this branch. I add a little fix. need more work but it's working for now

https://github.com/tapegoji/PySpice/tree/elementdata_fix

I'll test this

[tapegoji]

@Kreijstal I'd like to propose to work on one branch and try to go from there. What do you think? Which branch is the one you are working on?

[Kreijstal]

@Kreijstal I'd like to propose to work on one branch and try to go from there. What do you think? Which branch is the one you are working on?

unfortunately for me it is hard to change as I use circuit.simulator

[tapegoji]

is patch-2 branch the most up-to-date one? is that the one you are using?

[Kreijstal]

yeah that's what I was using

kreijstal@kreijstalnuc:~/git/PySpice$ git diff patch-2:PySpice/Spice/NgSpice/Simulation.py elementdata_fix:PySpice/Spice/NgSpice/Simulator.py
diff --git a/PySpice/Spice/NgSpice/Simulation.py b/PySpice/Spice/NgSpice/Simulator.py
index 617a7b6..6787dcd 100644
--- a/PySpice/Spice/NgSpice/Simulation.py
+++ b/PySpice/Spice/NgSpice/Simulator.py
@@ -4,17 +4,17 @@
 # Copyright (C) 2014 Fabrice Salvaire
 #
 # This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
+# it under the terms of the GNU Affero General Public License as published by
 # the Free Software Foundation, either version 3 of the License, or
 # (at your option) any later version.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
+# GNU Affero General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
 #
 ####################################################################################################

@@ -27,7 +27,7 @@ import logging

 ####################################################################################################

-from ..Simulation import CircuitSimulator
+from ..Simulator import Simulator
 from .Server import SpiceServer
 from .Shared import NgSpiceShared

@@ -37,63 +37,56 @@ _module_logger = logging.getLogger(__name__)

 ####################################################################################################

-class NgSpiceCircuitSimulator(CircuitSimulator):
-
+class NgSpiceSimulator(Simulator):
     SIMULATOR = 'ngspice'

-    ##############################################
-
-    def __init__(self, circuit, **kwargs):
-
-        super().__init__(circuit, **kwargs)
-
-        if kwargs.get('pipe', True):
-            self.options('NOINIT')
-            self.options(filetype='binary')
-
 ####################################################################################################

-class NgSpiceSubprocessCircuitSimulator(NgSpiceCircuitSimulator):
+class NgSpiceSubprocessSimulator(NgSpiceSimulator):

-    _logger = _module_logger.getChild('NgSpiceSubprocessCircuitSimulator')
+    _logger = _module_logger.getChild('NgSpiceSubprocessSimulator')

     ##############################################

-    def __init__(self, circuit, **kwargs):
-
-        super().__init__(circuit, pipe=True, **kwargs)
-
+    def __init__(self, **kwargs):
+        # super().__init__(**kwargs)
         # Fixme: to func ?
         server_kwargs = {x:kwargs[x] for x in ('spice_command',) if x in kwargs}
         self._spice_server = SpiceServer(**server_kwargs)

     ##############################################

-    def _run(self, analysis_method, *args, **kwargs):
+    @property
+    def version(self):
+        # Fixme: How to implement ?
+        return ''
+
+    ##############################################

-        super()._run(analysis_method, *args, **kwargs)
+    def customise(self, simulation):
+        # quicker to subclass...
+        simulation.options('NOINIT')
+        simulation.options(filetype='binary')

-        raw_file = self._spice_server(spice_input=str(self))
-        self.reset_analysis()
-        raw_file.simulation = self
+    ##############################################

+    def run(self, simulation, *args, **kwargs):
diff --git a/PySpice/Spice/NgSpice/Simulation.py b/PySpice/Spice/NgSpice/Simulator.py
index 617a7b6..6787dcd 100644
--- a/PySpice/Spice/NgSpice/Simulation.py
+++ b/PySpice/Spice/NgSpice/Simulator.py
@@ -4,17 +4,17 @@
 # Copyright (C) 2014 Fabrice Salvaire
 #
 # This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
+# it under the terms of the GNU Affero General Public License as published by
 # the Free Software Foundation, either version 3 of the License, or
 # (at your option) any later version.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
+# GNU Affero General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
 #
 ####################################################################################################

@@ -27,7 +27,7 @@ import logging

 ####################################################################################################

-from ..Simulation import CircuitSimulator
+from ..Simulator import Simulator
 from .Server import SpiceServer
 from .Shared import NgSpiceShared

@@ -37,63 +37,56 @@ _module_logger = logging.getLogger(__name__)

 ####################################################################################################

-class NgSpiceCircuitSimulator(CircuitSimulator):
-
+class NgSpiceSimulator(Simulator):
     SIMULATOR = 'ngspice'

-    ##############################################
-
-    def __init__(self, circuit, **kwargs):
-
-        super().__init__(circuit, **kwargs)
-
-        if kwargs.get('pipe', True):
-            self.options('NOINIT')
-            self.options(filetype='binary')
-
 ####################################################################################################

-class NgSpiceSubprocessCircuitSimulator(NgSpiceCircuitSimulator):
+class NgSpiceSubprocessSimulator(NgSpiceSimulator):

-    _logger = _module_logger.getChild('NgSpiceSubprocessCircuitSimulator')
+    _logger = _module_logger.getChild('NgSpiceSubprocessSimulator')

     ##############################################

-    def __init__(self, circuit, **kwargs):
-
-        super().__init__(circuit, pipe=True, **kwargs)
-
+    def __init__(self, **kwargs):
+        # super().__init__(**kwargs)
         # Fixme: to func ?
         server_kwargs = {x:kwargs[x] for x in ('spice_command',) if x in kwargs}
         self._spice_server = SpiceServer(**server_kwargs)

     ##############################################

-    def _run(self, analysis_method, *args, **kwargs):
+    @property
+    def version(self):
+        # Fixme: How to implement ?
+        return ''
+
+    ##############################################

-        super()._run(analysis_method, *args, **kwargs)
+    def customise(self, simulation):
+        # quicker to subclass...
+        simulation.options('NOINIT')
+        simulation.options(filetype='binary')

-        raw_file = self._spice_server(spice_input=str(self))
-        self.reset_analysis()
-        raw_file.simulation = self
+    ##############################################

+    def run(self, simulation, *args, **kwargs):
+        raw_file = self._spice_server(spice_input=str(simulation))
+        raw_file.simulation = simulation
         # for field in raw_file.variables:
         #     print field
-
         return raw_file.to_analysis()

 ####################################################################################################

-class NgSpiceSharedCircuitSimulator(NgSpiceCircuitSimulator):
+class NgSpiceSharedSimulator(NgSpiceSimulator):

-    _logger = _module_logger.getChild('NgSpiceSharedCircuitSimulator')
+    _logger = _module_logger.getChild('NgSpiceSharedSimulator')

     ##############################################

-    def __init__(self, circuit, **kwargs):
-
-        super().__init__(circuit, pipe=False, **kwargs)
-
+    def __init__(self, **kwargs):
+        # super().__init__(**kwargs)
         ngspice_shared = kwargs.get('ngspice_shared', None)
         if ngspice_shared is None:
             self._ngspice_shared = NgSpiceShared.new_instance()
@@ -108,24 +101,25 @@ class NgSpiceSharedCircuitSimulator(NgSpiceCircuitSimulator):

     ##############################################

-    def _run(self, analysis_method, *args, **kwargs):
-        background = kwargs.pop('background', False)
+    @property
+    def version(self):
+        return self._ngspice_shared.ngspice_version
+
+    ##############################################

-        super()._run(analysis_method, *args, **kwargs)
+    def run(self, simulation):

+        # Release the memory holding the output data
         self._ngspice_shared.destroy()
+
         # load circuit and simulation
         # Fixme: Error: circuit not parsed.
-        self._ngspice_shared.load_circuit(str(self))
-        self._ngspice_shared.run(background=background)
+        self._ngspice_shared.load_circuit(str(simulation))
+        self._ngspice_shared.run()
         self._logger.debug(str(self._ngspice_shared.plot_names))
-        if not background:
-            self.reset_analysis()

-            plot_name = self._ngspice_shared.last_plot
-            if plot_name == 'const':
-                raise NameError('Simulation failed')
-        else:
-            return True #Nothing to show yet!
+        plot_name = self._ngspice_shared.last_plot
+        if plot_name == 'const':
+            raise NameError('Simulation failed')

-        return self._ngspice_shared.plot(self, plot_name).to_analysis()
+        return self._ngspice_shared.plot(simulation, plot_name).to_analysis()

As you can see the 1.6 version doesn't allow background running, which I use for async simulations, if you have any idea how background simulations work, let me know.

[tapegoji]

I don't really know how it works. I did not have a lot of success with background simulations even in 1.5 version. 1.6 branch is breaking on many fronts. It's frustrating to fix someone else half done code.

[Kreijstal]

I don't really know how it works. I did not have a lot of success with background simulations even in 1.5 version. 1.6 branch is breaking on many fronts. It's frustrating to fix someone else half done code.

is there a a feature 1.6 has that 1.5 doesn't?

[tapegoji]

He made a lot of commits to it, around 194 commits ahead of master (1.5). The code structure is quite different, specially the way it parses spice libraries.

[Kreijstal]

He made a lot of commits to it, around 194 commits ahead of master (1.5). The code structure is quite different, specially the way it parses spice libraries.

Hmm, I see, I don't think I can help much there, I rebased the code to test on my application https://github.com/Kreijstal/PySpice/tree/element_data_fix_kreijstal but I do need the background running... which I couldn't figure out how to use... I'll assume not all commits here will be useful, but some of them may be. Enjoy... And if you can figure out 1.6 better, let us know!

[tapegoji]

for background simulation you need to pass True or False. here is the modified lines for that might work. If you send me your file I can try to test it on my side.

You can check out this branch for the little change:

https://github.com/tapegoji/PySpice/tree/element_data_fix

 `  background = True
    self._ngspice_shared.run(background=background)
    self._logger.debug(str(self._ngspice_shared.plot_names))
    if not background:
        simulation.reset_analysis()`

[Kreijstal]

@tapegoji Alright, do you use jupyter? for this one you might have to.

jupytext, you can use jupytext to convert this into a ipython notebook

# ---
# jupyter:
#   jupytext:
#     formats: ipynb,py:light
#     text_representation:
#       extension: .py
#       format_name: light
#       format_version: '1.5'
#       jupytext_version: 1.16.7
#   kernelspec:
#     display_name: Python 3 (ipykernel)
#     language: python
#     name: python3
# ---

# +
import anywidget
import traitlets
import json
import time
from collections import defaultdict

class AnimatedFnWidget(anywidget.AnyWidget):
    # Trait for sending new data points to JavaScript
    new_data_points = traitlets.Unicode('{}').tag(sync=True)
    
    # Trait for initial configuration
    config = traitlets.Unicode('{"xMin": 0, "xMax": 10, "yMin": -1.5, "yMax": 1.5, "series": {}}').tag(sync=True)
    
    _esm = """
    function render({ model, el }) {
    const container = document.createElement('div');
    container.style.width = '100%';
    container.style.height = '400px';
    container.style.border = '1px solid #ccc';
    container.style.position = 'relative';
    el.appendChild(container);
    
    const canvas = document.createElement('canvas');
    canvas.style.width = '100%';
    canvas.style.height = '100%';
    container.appendChild(canvas);
    
    function resizeCanvas() {
        const rect = container.getBoundingClientRect();
        canvas.width = rect.width * window.devicePixelRatio;
        canvas.height = rect.height * window.devicePixelRatio;
        redrawPlot();
    }
    
    window.addEventListener('resize', resizeCanvas);
    
    let allData = {};
    let config = JSON.parse(model.get('config'));
    const colors = ['#3498db', '#e74c3c', '#2ecc71', '#9b59b6', '#f1c40f', '#e67e22'];
    
    model.on('change:config', () => {
        config = JSON.parse(model.get('config'));
        allData = {};
        Object.keys(config.series).forEach(series => {
            allData[series] = { x: [], y: [] };
        });
        redrawPlot();
    });
    
    model.on('change:new_data_points', () => {
        const newData = JSON.parse(model.get('new_data_points'));
        if (Object.keys(newData).length === 0) return;
        
        Object.entries(newData).forEach(([series, points]) => {
            if (!allData[series]) {
                allData[series] = { x: [], y: [] };
            }
            allData[series].x = allData[series].x.concat(points.x);
            allData[series].y = allData[series].y.concat(points.y);
            
            if (allData[series].x.length > 0) {
                const maxX = Math.max(...Object.values(allData).map(d => Math.max(...d.x)));
                if (maxX > config.xMax) {
                    config.xMin = Math.max(0, maxX - 10);
                    config.xMax = maxX;
                }
            }
        });
        
        redrawPlot();
    });
    
    function redrawPlot() {
        const ctx = canvas.getContext('2d');
        const width = canvas.width;
        const height = canvas.height;
        
        // Compute yMin and yMax dynamically if not specified
        let yMin, yMax;
        if (typeof config.yMin === 'number' && typeof config.yMax === 'number') {
            yMin = config.yMin;
            yMax = config.yMax;
        } else {
            // Auto-scale y-axis
            let allYValues = [];
            Object.values(allData).forEach(series => {
                allYValues = allYValues.concat(series.y);
            });
            if (allYValues.length === 0) {
                yMin = -1;
                yMax = 1;
            } else {
                let dataMin = Math.min(...allYValues);
                let dataMax = Math.max(...allYValues);
                if (dataMin === dataMax) {
                    yMin = dataMin - 1;
                    yMax = dataMax + 1;
                } else {
                    let padding = (dataMax - dataMin) * 0.1;
                    yMin = dataMin - padding;
                    yMax = dataMax + padding;
                }
            }
        }
        
        ctx.clearRect(0, 0, width, height);
        
        // Draw grid
        ctx.strokeStyle = '#ccc';
        ctx.lineWidth = 1 * window.devicePixelRatio;
        ctx.beginPath();
        const gridStep = width / 10;
        for (let i = 0; i <= 10; i++) {
            const x = i * gridStep;
            ctx.moveTo(x, 0);
            ctx.lineTo(x, height);
        }
        const yGridStep = height / 6;
        for (let i = 0; i <= 6; i++) {
            const y = i * yGridStep;
            ctx.moveTo(0, y);
            ctx.lineTo(width, y);
        }
        ctx.stroke();
        
        // Draw axes
        ctx.strokeStyle = '#000';
        const yZero = height * (1 - (0 - yMin) / (yMax - yMin));
        ctx.beginPath();
        ctx.moveTo(0, yZero);
        ctx.lineTo(width, yZero);
        ctx.stroke();
        
        const xZero = width * (0 - config.xMin) / (config.xMax - config.xMin);
        ctx.beginPath();
        ctx.moveTo(xZero, 0);
        ctx.lineTo(xZero, height);
        ctx.stroke();
        
        function dataToCanvas(x, y) {
            return {
                x: width * (x - config.xMin) / (config.xMax - config.xMin),
                y: height * (1 - (y - yMin) / (yMax - yMin))
            };
        }
        
        // Draw all series (no config.series check)
        Object.entries(allData).forEach(([series, data], index) => {
            if (data.x.length > 1) {
                const visibleData = data.x.map((x, i) => ({x, y: data.y[i]}))
                    .filter(point => point.x >= config.xMin && point.x <= config.xMax);
                
                if (visibleData.length > 0) {
                    ctx.beginPath();
                    const startPoint = dataToCanvas(visibleData[0].x, visibleData[0].y);
                    ctx.moveTo(startPoint.x, startPoint.y);
                    
                    for (let i = 1; i < visibleData.length; i++) {
                        const point = dataToCanvas(visibleData[i].x, visibleData[i].y);
                        ctx.lineTo(point.x, point.y);
                    }
                    
                    ctx.strokeStyle = colors[index % colors.length];
                    ctx.lineWidth = 2 * window.devicePixelRatio;
                    ctx.stroke();
                    
                    // Draw legend with fallback label
                    ctx.fillStyle = colors[index % colors.length];
                    ctx.fillRect(10, 10 + index * 20, 10, 10);
                    ctx.fillStyle = '#000';
                    ctx.font = `${12 * window.devicePixelRatio}px Arial`;
                    const label = config.series[series] ? config.series[series].label : series;
                    ctx.fillText(label, 25, 20 + index * 20);
                }
            }
        });
        
        // Draw axes labels
        ctx.fillStyle = '#000';
        ctx.font = `${12 * window.devicePixelRatio}px Arial`;
        ctx.fillText(`t`, width - 15, yZero - 5);
        ctx.fillText(`${config.xMin.toFixed(1)}`, 5, yZero - 5);
        ctx.fillText(`${config.xMax.toFixed(1)}`, width - 30, yZero - 5);
        ctx.fillText(`${yMax.toFixed(1)}`, xZero + 5, 15);
        ctx.fillText(`${yMin.toFixed(1)}`, xZero + 5, height - 5);
    }
    
    setTimeout(resizeCanvas, 0);
}

export default { render };
    """

    def __init__(self, update_interval_ms=100, **kwargs):
        super().__init__(**kwargs)
        self.update_interval = update_interval_ms / 1000
        self.last_update_time = 0
        self.buffer = defaultdict(lambda: {'x': [], 'y': []})
        
    def update_config(self, config_dict):
        """Update the plot configuration"""
        self.config = json.dumps(config_dict)
        
    def add_points(self, series_name, x_values, y_values):
        """Add points for a specific series"""
        if len(x_values) != len(y_values):
            raise ValueError("x_values and y_values must have the same length")
            
        self.buffer[series_name]['x'].extend(x_values)
        self.buffer[series_name]['y'].extend(y_values)
        
        current_time = time.time()
        if current_time - self.last_update_time >= self.update_interval:
            self._flush_buffer()
            self.last_update_time = current_time
            
    def _flush_buffer(self):
        """Send buffered data to JavaScript"""
        if not self.buffer:
            return
            
        self.new_data_points = json.dumps(dict(self.buffer))
        for series in self.buffer:
            self.buffer[series]['x'].clear()
            self.buffer[series]['y'].clear()

# Example usage with sine wave
def test_sine_wave(widget):
    import numpy as np
    config = {
        "xMin": 0,
        "xMax": 10,
        "yMin": -1.5,
        "yMax": 1.5,
        "series": {
            "sine": {"label": "Sine Wave"}
        }
    }
    widget.update_config(config)
    
    t = 0
    dt = 0.05
    points_per_update = 5
    
    while t < 20:
        x_values = [t + i * dt for i in range(points_per_update)]
        y_values = [np.sin(2 * np.pi * x) for x in x_values]
        widget.add_points("sine", x_values, y_values)
        t += dt * points_per_update
        time.sleep(widget.update_interval)


# -

anim_widget = AnimatedFnWidget(update_interval_ms=100)
anim_widget

test_sine_wave(anim_widget) #if this doesn't work then forget it

# +
from PySpice.Spice.Netlist import Circuit
from PySpice.Unit import *

# Create a circuit
circuit = Circuit('My Circuit')

# Add components to the circuit
circuit.R('res1', 'k', 'y', 1@u_Ω)  # Resistor R1 between nodes 'k' and 'y' with 1 Ω
circuit.C('cap1', 0, 'k', 1@u_F, ic=0.0)  # Capacitor C1 between nodes 0 and 'k' with 1 F, initial condition 0.0
circuit.V('vdc', 0, 'y', 1@u_V)  # Voltage source V1 between nodes 0 and 'y' with 1 V

# Print the circuit to verify
print(circuit)

# -

def couple_with_ngspice(widget, simulator, start, end, step, y_range=(-2, 2)):
    """
    Couple the AnimatedFnWidget with an NGSpice simulation, plotting all available signals.
    
    Args:
        widget: AnimatedFnWidget instance
        simulator: PySpice simulator object
        start: Simulation start time
        end: Simulation end time
        step: Simulation time step
        y_range: Tuple of (min, max) values for y-axis
    """
    # Initial config with empty series; labels will use signal names
    config = {
        "xMin": start,
        "xMax": end,
        "yMin": y_range[0],
        "yMax": y_range[1],
        "series": {}
    }
    widget.update_config(config)
    
    def data_listener(actual_vector_values, number_of_vectors, ngspice_id):
        time_value = float(actual_vector_values['time'].real)
        for signal, value in actual_vector_values.items():
            if signal != 'time':
                widget.add_points(signal, [time_value], [float(value.real)])
    
    simulator._ngspice_shared.addListener("send_data", data_listener)
    display(widget)
    simulator.transient(step, end, start, use_initial_condition=True, background=True)


# +
from PySpice.Spice.Netlist import Circuit
from PySpice.Unit import *
from PySpice.Spice.NgSpice.Shared import NgSpiceShared
class MyNgSpiceShared(NgSpiceShared):
    def __init__(self, ngspice_id=0, send_data=False, verbose=False):
        super().__init__(ngspice_id=ngspice_id, send_data=send_data, verbose=verbose)
        self._listeners = {
            "send_data": [],
            "send_init_data": []
        }

    def addListener(self, event, listener):
        if event in self._listeners:
            self._listeners[event].append(listener)
        else:
            raise ValueError(f"Ev'ent '{event}' is not supported.")

    def removeListener(self, event, listener):
        if event in self._listeners:
            if listener in self._listeners[event]:
                self._listeners[event].remove(listener)
            else:
                raise ValueError(f"Listener '{listener.__name__}' is not registered for event '{event}'.")
        else:
            raise ValueError(f"Event '{event}' is not supported.")

    def _notify_listeners(self, event, *args, **kwargs):
        if event in self._listeners:
            for listener in self._listeners[event]:
                listener(*args, **kwargs)

    def send_data(self, actual_vector_values, number_of_vectors, ngspice_id):
        # Notify listeners for the 'send_data' event
        self._notify_listeners("send_data", actual_vector_values, number_of_vectors, ngspice_id)
        return 0

    def send_init_data(self, data, ngspice_id):
        # Notify listeners for the 'send_init_data' event
        self._notify_listeners("send_init_data", data, ngspice_id)
        return 0



MyNgSpiceShared.new_instance(send_data=True,ngspice_id=0)        

simulator = circuit.simulator(
    temperature=25,
    nominal_temperature=25,
    ngspice_shared=MyNgSpiceShared.new_instance(send_data=True)
)
anim_widget = AnimatedFnWidget(update_interval_ms=100)
couple_with_ngspice(anim_widget, simulator, 0, 12, 0.0001)# If your computer is too fast make this smaller.... if your computer is too slow make this bigger.
# -
simulator._ngspice_shared.halt() ## Execute these instructions when they are on the middle.

simulator._ngspice_shared.alter_device(device='Vvdc', dc=-1)


simulator._ngspice_shared.resume()

if you want to test with with 1.6 you might have to do somethning like

changes

`from PySpice.Spice import Simulator`

@@ -219,6 +212,12 @@ analysis = simulator.dc(Vvdc=slice(-2, 5, .01),background=False)
 #analysis = simulator.transient(0.001,1,0,background=False)
 #transient(self, step_time, end_time, start_time=0, max_time=None, use_initial_condition=False)

+# %%
+simulator =Simulator.Simulator.factory().simulation(circuit,temperature=25, nominal_temperature=25
+                             ,ngspice_shared=MyNgSpiceShared.new_instance(send_data=True)
+                             )
+analysis = simulator.dc(Vvdc=slice(-2, 5, .01))
+

instead of circuit.simulator

If you have the right timing you get something like this