WoW Error

[Schaka]

Packed up the current master branch into my own MPQ and got the following error:
http://i.imgur.com/WAEX26W.png

[Krack3n77]

Are you using the feenix .exe? If you are you may need to use one that hasn't been altered.

[Schaka]

I'm using an old Feenix client that shouldn't have been altered. As in, I connect to other servers. Will replace the exe anyway though.
What are the chances that this is caused by the Legion models?

[Koward]

I was able to reproduce the crash. I confirm this is indeed a bug linked to the patch. I don't know yet what exactly causes this.
It may be a bug with how the Bear2 model references a texture (the Brown one, just a name issue), I fixed the CSV (not commited yet) and I now need to convert it back to DBC but I can't check it before Friday.

[Schaka]

Take your time! I'm just glad I could help by testing this. If you commit anything, I'll continue to do so.
Might as well open a dev branch if you're worried about pushing to master too early.

[Koward]

As promised, I fixed the Bear2 reference, no crash so far but I'll let this issue open for a moment just to be sure.
If this really fixes it, then it's great because if a Texture.cpp crash happens in the future we'll immediately know what's wrong, thank you for reporting it Schaka.

[Schaka]

http://i.imgur.com/QIv1G7Q.jpg
Guess there are still errors.

Edit: For reference, packing the entire folder into an MPQ should be enough, correct? If not, that might be my problem in the first place.
The error also doesn't happen as often it seems. Also helps noting that when it happend (Darkshire) there was no bear model in sight.
Edit2: Probably doesn't depend on the location as it just crashed when closing the game (on login screen)

[Koward]

Found the crash there too, crashing when closing the game. I deleted the second half of the world folder and the bug disappeared so the bug is linked to one of the static models or textures, I will try to isolate the bad file.

[Ghaster]

The game crashes due to a texture has a resolution past 512x512. 512x512 is the highest resolution vanilla and tbc can load.

[Koward]

I think I now fixed this. Two textures seemed too high (1024x1024) :
World\EXPANSION05\DOODADS\HUMAN\DOODADS\map1.blp and
World\EXPANSION05\DOODADS\HUMAN\DOODADS\map6.blp
Thanks Ghaster.

[Neotmiren]

There are more too big textures (1024x1024 and 1024x512), which cause creatures to look completely green-skinned and which crash client the same way as described above.

Creature\Infernal2\Infernal2_Gray.blp
Creature\CoreHound2\corehoundmount2_fel.blp
Creature\CoreHound2\corehoundsaddle.blp
Creature\CoreHound2\corehoundsaddle_fel.blp
Creature\FelGuard2\Felguard2_01.blp
Creature\FelGuard2\felguard2_01black.blp
Creature\FelGuard2\Felguard2_01Red.blp
Creature\FelGuard2\felguard2_01white.blp
Creature\FelGuard2\Felguard2_01Yellow.blp
Creature\SeaGiant2\SeaGiant2.blp
Creature\SeaGiant2\SeaGiant2_Dark.blp
Creature\SeaGiant2\SeaGiant2_Green.blp
Creature\SeaGiant2\SeaGiant2_Pale.blp