Skip to content

[Proxy colonies M3] feat: implement versioning for all ColonyFundsMovedBetweenFundingPots events #4231

@bassgeta

Description

@bassgeta

Specification

Story

As a user using an older version of the colony, I can still move funds between domains.

Description

Since a new chainId argument was added to the ColonyFundsMovedBetweenFundingPots event, now when funds are moved, we need to make sure old colony versions will keep working.

Sagas:

  • All sagas for moving funds between pots need to be updated, if the colony runs on a new version, we need to add the chainId as the second to last argument, otherwise not
  • Funding an expenditure sagas should also use the same approach

Block ingestor:

  • For move funds actions, we need to implement a new handler for ColonyFundsMovedBetweenFundingPots events with chainId (basically the same as the old one)
  • for funding an expenditure, we need to update the multisig and motion handlers

Implementation

This issue is complete when...

  • Moving funds between domains still works as intended on old colony versions
  • Moving funds between domains as intended on new colony versions
  • Funding an expenditure still works as intended on old colony versions
  • Funding an expenditure works as intended on new colony versions

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions