From edb634b9a96d70a03a738ae4e5c84810e958b330 Mon Sep 17 00:00:00 2001 From: imaandrew <14946103+imaandrew@users.noreply.github.com> Date: Sat, 23 Aug 2025 15:45:16 -0400 Subject: [PATCH 1/2] Update practicerom repo install step in build actions --- .github/workflows/build-patches.yml | 4 +--- .github/workflows/check-code.yml | 8 ++++---- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-patches.yml b/.github/workflows/build-patches.yml index 9260417..9a50ba7 100644 --- a/.github/workflows/build-patches.yml +++ b/.github/workflows/build-patches.yml @@ -11,9 +11,7 @@ jobs: - uses: actions/checkout@v2 - name: Install prerequisite packages run: | - curl https://practicerom.com/public/packages/debian/pgp.pub | sudo apt-key add - - echo deb https://practicerom.com/public/packages/debian ./staging main | sudo tee /etc/apt/sources.list.d/practicerom.list - sudo apt-get update + sudo sh -c "$(curl -fsSL https://raw.githubusercontent.com/PracticeROM/packages/HEAD/scripts/install-debian_amd64.sh)" sudo apt-get install practicerom-dev xdelta3 ninja-build pip install --break-system-packages -r requirements.txt - name: Download ROMs diff --git a/.github/workflows/check-code.yml b/.github/workflows/check-code.yml index 5df3b7c..96e2bcf 100644 --- a/.github/workflows/check-code.yml +++ b/.github/workflows/check-code.yml @@ -14,15 +14,15 @@ jobs: - uses: actions/checkout@v3 - name: Install dependencies run: | - sudo sh -c '(curl https://practicerom.com/public/packages/debian/pgp.pub || wget -O - https://practicerom.com/public/packages/debian/pgp.pub) | apt-key add - && echo deb https://practicerom.com/public/packages/debian ./staging main >/etc/apt/sources.list.d/practicerom.list && apt update' - sudo apt install practicerom-dev ninja-build + sudo sh -c "$(curl -fsSL https://raw.githubusercontent.com/PracticeROM/packages/HEAD/scripts/install-debian_amd64.sh)" + sudo apt-get install practicerom-dev ninja-build pip install --break-system-packages -r requirements.txt - name: Test build run: | python3 configure.py - ninja -j16 us jp + ninja us jp python3 configure.py --cppflags='-DPAYLOAD=0x1c84d30 -DDMA_COPY=0x8002973c -DEND=0x01ccd110' --ldflags='-Wl,--defsym,start=0x8004ad7c' - ninja -j16 us_ldr jp_ldr + ninja us_ldr jp_ldr formatting-check: name: Formatting Check runs-on: ubuntu-latest From 73a8303577b245fccdf27ef260b65c31bc36b699 Mon Sep 17 00:00:00 2001 From: imaandrew <14946103+imaandrew@users.noreply.github.com> Date: Sat, 23 Aug 2025 15:54:42 -0400 Subject: [PATCH 2/2] ensure apt install doesn't prompt for confirmation --- .github/workflows/build-patches.yml | 2 +- .github/workflows/check-code.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-patches.yml b/.github/workflows/build-patches.yml index 9a50ba7..88d7f85 100644 --- a/.github/workflows/build-patches.yml +++ b/.github/workflows/build-patches.yml @@ -12,7 +12,7 @@ jobs: - name: Install prerequisite packages run: | sudo sh -c "$(curl -fsSL https://raw.githubusercontent.com/PracticeROM/packages/HEAD/scripts/install-debian_amd64.sh)" - sudo apt-get install practicerom-dev xdelta3 ninja-build + sudo apt-get install -y practicerom-dev xdelta3 ninja-build pip install --break-system-packages -r requirements.txt - name: Download ROMs run: | diff --git a/.github/workflows/check-code.yml b/.github/workflows/check-code.yml index 96e2bcf..e401449 100644 --- a/.github/workflows/check-code.yml +++ b/.github/workflows/check-code.yml @@ -15,7 +15,7 @@ jobs: - name: Install dependencies run: | sudo sh -c "$(curl -fsSL https://raw.githubusercontent.com/PracticeROM/packages/HEAD/scripts/install-debian_amd64.sh)" - sudo apt-get install practicerom-dev ninja-build + sudo apt-get install -y practicerom-dev ninja-build pip install --break-system-packages -r requirements.txt - name: Test build run: |