Skip to content

Uncaught TypeError: Cannot read property 'right' of undefined #122

@srgroves

Description

@srgroves

I noticed that in positionBeacons(), line 1399, it's accessing playerLocation.right without checking if playerLocation has been defined. It may not be, depending on what player.getClientRects returns. This causes the error in the title of this post. The last line below is 1399:

var playerLocation = player.getClientRects()[0];

// when we don't have an initial position, or the position hasn't changed 
if (lastPlayerLocation && playerLocation && (lastPlayerLocation.left === playerLocation.left && lastPlayerLocation.right === playerLocation.right && lastPlayerLocation.top === playerLocation.top && lastPlayerLocation.bottom === playerLocation.bottom)) {
    // no need to update positions
    return;
}

// save for next time
lastPlayerLocation = playerLocation;

var playerWidth = playerLocation.right - playerLocation.left;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions