From 600273f158cf1a331433dbe04d74355f1700501f Mon Sep 17 00:00:00 2001 From: Jim Myers Date: Wed, 27 Sep 2023 12:17:31 -0400 Subject: [PATCH 1/6] 7956 - display original file when ingested --- src/main/java/edu/harvard/iq/dataverse/DataFile.java | 12 ++++++++++-- src/main/webapp/file-info-fragment.xhtml | 9 +++++---- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/src/main/java/edu/harvard/iq/dataverse/DataFile.java b/src/main/java/edu/harvard/iq/dataverse/DataFile.java index 0f83ae3c5c8..032eeb2f9e6 100644 --- a/src/main/java/edu/harvard/iq/dataverse/DataFile.java +++ b/src/main/java/edu/harvard/iq/dataverse/DataFile.java @@ -445,6 +445,10 @@ public Long getOriginalFileSize() { return null; } + public String getFriendlyOriginalFileSize() { + return getFriendlySize(getOriginalFileSize()); + } + public String getOriginalFileName() { if (isTabularData()) { DataTable dataTable = getDataTable(); @@ -607,8 +611,12 @@ public void setFilesize(long filesize) { * @return */ public String getFriendlySize() { - if (filesize != null) { - return FileSizeChecker.bytesToHumanReadable(filesize); + return getFriendlySize(filesize); + } + + private String getFriendlySize(Long size) { + if (size != null) { + return FileSizeChecker.bytesToHumanReadable(size); } else { return BundleUtil.getStringFromBundle("file.sizeNotAvailable"); } diff --git a/src/main/webapp/file-info-fragment.xhtml b/src/main/webapp/file-info-fragment.xhtml index 33a8d2c3ca5..c9c73474254 100644 --- a/src/main/webapp/file-info-fragment.xhtml +++ b/src/main/webapp/file-info-fragment.xhtml @@ -48,11 +48,11 @@ - #{fileMetadata.label} + #{fileMetadata.datafile.originalFileName} - #{fileMetadata.label} + #{fileMetadata.datafile.originalFileName} @@ -60,7 +60,7 @@ - +
@@ -71,7 +71,7 @@
-
+
+ Date: Wed, 27 Sep 2023 12:33:23 -0400 Subject: [PATCH 2/6] typo --- src/main/webapp/file-info-fragment.xhtml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/webapp/file-info-fragment.xhtml b/src/main/webapp/file-info-fragment.xhtml index c9c73474254..314b5b0da50 100644 --- a/src/main/webapp/file-info-fragment.xhtml +++ b/src/main/webapp/file-info-fragment.xhtml @@ -48,11 +48,11 @@ - #{fileMetadata.datafile.originalFileName} + #{fileMetadata.dataFile.originalFileName} - #{fileMetadata.datafile.originalFileName} + #{fileMetadata.dataFile.originalFileName}
From db450ec60e844d26d12b0c92936e5f83a59eedf3 Mon Sep 17 00:00:00 2001 From: Jim Myers Date: Wed, 27 Sep 2023 13:03:56 -0400 Subject: [PATCH 3/6] fix name, size, update file page and file citation --- src/main/java/edu/harvard/iq/dataverse/DataCitation.java | 2 +- src/main/java/edu/harvard/iq/dataverse/DataFile.java | 5 +++-- src/main/java/edu/harvard/iq/dataverse/FileMetadata.java | 8 ++++++++ src/main/webapp/file-info-fragment.xhtml | 6 +++--- src/main/webapp/file.xhtml | 6 +++--- 5 files changed, 18 insertions(+), 9 deletions(-) diff --git a/src/main/java/edu/harvard/iq/dataverse/DataCitation.java b/src/main/java/edu/harvard/iq/dataverse/DataCitation.java index 9b4b89db44f..7774d9326a1 100644 --- a/src/main/java/edu/harvard/iq/dataverse/DataCitation.java +++ b/src/main/java/edu/harvard/iq/dataverse/DataCitation.java @@ -108,7 +108,7 @@ public DataCitation(FileMetadata fm, boolean direct) { getCommonValuesFrom(dsv); // file Title for direct File citation - fileTitle = fm.getLabel(); + fileTitle = fm.getLabelForOriginal(); DataFile df = fm.getDataFile(); // File description diff --git a/src/main/java/edu/harvard/iq/dataverse/DataFile.java b/src/main/java/edu/harvard/iq/dataverse/DataFile.java index 032eeb2f9e6..e51ee6c75c8 100644 --- a/src/main/java/edu/harvard/iq/dataverse/DataFile.java +++ b/src/main/java/edu/harvard/iq/dataverse/DataFile.java @@ -446,7 +446,8 @@ public Long getOriginalFileSize() { } public String getFriendlyOriginalFileSize() { - return getFriendlySize(getOriginalFileSize()); + Long size = (getOriginalFileSize()==null) ? filesize : getOriginalFileSize(); + return getFriendlySize(size); } public String getOriginalFileName() { @@ -461,7 +462,7 @@ public String getOriginalFileName() { } - private String getDerivedOriginalFileName() { + public String getDerivedOriginalFileName() { FileMetadata fm = getFileMetadata(); String filename = fm.getLabel(); String originalExtension = FileUtil.generateOriginalExtension(getOriginalFileFormat()); diff --git a/src/main/java/edu/harvard/iq/dataverse/FileMetadata.java b/src/main/java/edu/harvard/iq/dataverse/FileMetadata.java index 461c8b14e46..554a7451043 100644 --- a/src/main/java/edu/harvard/iq/dataverse/FileMetadata.java +++ b/src/main/java/edu/harvard/iq/dataverse/FileMetadata.java @@ -142,6 +142,14 @@ public void setLabel(String label) { this.label = label; } + public String getLabelForOriginal() { + if(dataFile.isTabularData()) { + return dataFile.getDerivedOriginalFileName(); + } else { + return label; + } + } + public FileMetadata() { variableMetadatas = new ArrayList(); varGroups = new ArrayList(); diff --git a/src/main/webapp/file-info-fragment.xhtml b/src/main/webapp/file-info-fragment.xhtml index 314b5b0da50..2427006c938 100644 --- a/src/main/webapp/file-info-fragment.xhtml +++ b/src/main/webapp/file-info-fragment.xhtml @@ -48,18 +48,18 @@ - #{fileMetadata.dataFile.originalFileName} + #{fileMetadata.labelForOriginal} - #{fileMetadata.dataFile.originalFileName} + #{fileMetadata.labelForOriginal}
- +
diff --git a/src/main/webapp/file.xhtml b/src/main/webapp/file.xhtml index 5a60afef60c..34c42860c17 100644 --- a/src/main/webapp/file.xhtml +++ b/src/main/webapp/file.xhtml @@ -42,7 +42,7 @@
- #{FilePage.fileMetadata.label} + #{FilePage.fileMetadata.labelForOriginal}
@@ -560,11 +560,11 @@ #{FilePage.file.embargo.reason} - + #{bundle['file.metadataTab.fileMetadata.size.label']} - #{FilePage.file.friendlySize} + #{FilePage.file.friendlyOriginalFileSize} From 7fbbfd06e26d8d3e75f0d831a5b20834ffed7b00 Mon Sep 17 00:00:00 2001 From: Jim Myers Date: Wed, 27 Sep 2023 13:17:01 -0400 Subject: [PATCH 4/6] add ': ' --- src/main/webapp/file-info-fragment.xhtml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/webapp/file-info-fragment.xhtml b/src/main/webapp/file-info-fragment.xhtml index 2427006c938..a6ce4d01737 100644 --- a/src/main/webapp/file-info-fragment.xhtml +++ b/src/main/webapp/file-info-fragment.xhtml @@ -85,7 +85,7 @@
- + Date: Tue, 10 Feb 2026 16:31:12 -0500 Subject: [PATCH 5/6] cleanup space changes --- src/main/webapp/file.xhtml | 68 +++++++++++++++++++------------------- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/src/main/webapp/file.xhtml b/src/main/webapp/file.xhtml index d9ffa0621ed..a24556860f1 100644 --- a/src/main/webapp/file.xhtml +++ b/src/main/webapp/file.xhtml @@ -46,7 +46,7 @@
#{FilePage.fileMetadata.labelForOriginal} - +
@@ -67,7 +67,7 @@

- + @@ -78,13 +78,13 @@ - + + value="#{bundle['file.DatasetVersion']} #{FilePage.fileMetadata.datasetVersion.versionNumber}.#{FilePage.fileMetadata.datasetVersion.minorVersionNumber}"/>
@@ -103,9 +103,9 @@ - -
@@ -150,11 +150,11 @@ - - -
@@ -197,7 +197,7 @@
-
@@ -493,7 +493,7 @@
-
@@ -505,7 +505,7 @@ #{bundle['file.metadata.filetags']} -
+
@@ -514,7 +514,7 @@
- + @@ -650,8 +650,8 @@ - - + +

#{bundle['file.share.tip']}

@@ -660,7 +660,7 @@ #{bundle.close}
- + @@ -671,7 +671,7 @@ - + @@ -686,7 +686,7 @@ - + @@ -705,7 +705,7 @@ #{bundle.close}
- +

#{bundle['file.compute.fileAccessDenied']}

@@ -717,7 +717,7 @@