From e3d26ade289f06add90c1e8ef9de34c94cdcb4dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Saracca?= Date: Mon, 2 Jun 2025 14:59:19 -0300 Subject: [PATCH 1/2] return citationHtml instead of citation plain text --- .../infra/repositories/transformers/DatasetPreviewPayload.ts | 1 + .../repositories/transformers/datasetPreviewsTransformers.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/datasets/infra/repositories/transformers/DatasetPreviewPayload.ts b/src/datasets/infra/repositories/transformers/DatasetPreviewPayload.ts index 42652222..99f764a5 100644 --- a/src/datasets/infra/repositories/transformers/DatasetPreviewPayload.ts +++ b/src/datasets/infra/repositories/transformers/DatasetPreviewPayload.ts @@ -9,6 +9,7 @@ export interface DatasetPreviewPayload { updatedAt: string published_at?: string citation: string + citationHtml: string description: string type?: string publicationStatuses: string[] diff --git a/src/datasets/infra/repositories/transformers/datasetPreviewsTransformers.ts b/src/datasets/infra/repositories/transformers/datasetPreviewsTransformers.ts index 26d59c66..8b60828d 100644 --- a/src/datasets/infra/repositories/transformers/datasetPreviewsTransformers.ts +++ b/src/datasets/infra/repositories/transformers/datasetPreviewsTransformers.ts @@ -44,7 +44,7 @@ export const transformDatasetPreviewPayloadToDatasetPreview = ( releaseTime: new Date(datasetPreviewPayload.published_at) }) }, - citation: datasetPreviewPayload.citation, + citation: datasetPreviewPayload.citationHtml, description: datasetPreviewPayload.description, publicationStatuses: publicationStatuses, parentCollectionAlias: datasetPreviewPayload.identifier_of_dataverse, From bcfdaf47ef8862c4de0b2217db489eb6c72261ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Saracca?= Date: Mon, 2 Jun 2025 15:25:51 -0300 Subject: [PATCH 2/2] fix: tests --- test/testHelpers/datasets/datasetPreviewHelper.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/testHelpers/datasets/datasetPreviewHelper.ts b/test/testHelpers/datasets/datasetPreviewHelper.ts index fb61d792..ee162d9a 100644 --- a/test/testHelpers/datasets/datasetPreviewHelper.ts +++ b/test/testHelpers/datasets/datasetPreviewHelper.ts @@ -11,6 +11,9 @@ const DATASET_RELEASE_TIME_STR = '2023-05-15T08:21:03Z' const DATASET_CITATION = 'Doe, John, 2023, "Test Dataset 1", https://doi.org/10.5072/FK2/XXXXXX, Root, V1, UNF:6:AAc5A5tAI9AVodAAAsOysA== [fileUNF]' +const DATASET_CITATION_HTML = + 'Finch, Fiona; Spruce, Sabrina; Poe, Edgar Allen; Mulligan, Hercules, 2019, "Darwin\'s Finches", https://doi.org/10.70122/FK2/MB5VGR, Root, V3' + export const createDatasetPreviewModel = (): DatasetPreview => { const datasetPreviewModel: DatasetPreview = { type: CollectionItemType.DATASET, @@ -25,7 +28,7 @@ export const createDatasetPreviewModel = (): DatasetPreview => { lastUpdateTime: new Date(DATASET_UPDATE_TIME_STR), releaseTime: new Date(DATASET_RELEASE_TIME_STR) }, - citation: DATASET_CITATION, + citation: DATASET_CITATION_HTML, description: 'test', publicationStatuses: [PublicationStatus.Draft, PublicationStatus.Unpublished], parentCollectionAlias: 'parentCollection', @@ -47,6 +50,7 @@ export const createDatasetPreviewPayload = (): DatasetPreviewPayload => { updatedAt: DATASET_UPDATE_TIME_STR, published_at: DATASET_RELEASE_TIME_STR, citation: DATASET_CITATION, + citationHtml: DATASET_CITATION_HTML, description: 'test', type: 'dataset', publicationStatuses: ['Draft', 'Unpublished'],