-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Tasks/Guidelines
- Team and Task Cohesion
- maintain all work and images in github (move all intermediates from MSWord until we get to finalization of formatting)
- Each section below gets a Github issue in this
baseflow_storagerepository - Move all code (ReivewApp.R, MainAnalysis.R, function files) into
baseflow_storagerepository.
- Each section below gets a Github issue in this
- What functions do we have? (We must insure a single common code-base)
- Individual Functions should have their own files, named
[function].R(exception would be if one person is maintaining all of a related set of functions you can combine in a file). - Event ID.
- Sub-event Analysis.
- Plotting.
- Individual Functions should have their own files, named
- Function Maintainer: How do we make sure that everyone is using the exact same live copy?
- maintainer is responsible for insuring up to date code and communication, but teammates are responsible for submitting PRs and bug reports
- Code linking: remote web link:
source("https://raw.githubusercontent.com/HARPgroup/hydro-tools/master/R/fac_utils.R")
- maintain all work and images in github (move all intermediates from MSWord until we get to finalization of formatting)
- Final products for the end of the week review. Detailed individuals assigned.
- File Locations:
- All images and tables will go into Github initially, and as we move towards the end of the week, we may put tables into text files, and images uploaded into images directory in
baseflow_storagegithub
- All images and tables will go into Github initially, and as we move towards the end of the week, we may put tables into text files, and images uploaded into images directory in
- Gage/Model Flow CSVs / From NWIS
- Coote's Store:
- Mount Jackson
- Strasburg
- DEQ add links to model files for this
- Maintainer: @ilonah22 @willprokopik @benhdye
- All Event identifier function (events, metrics/stat summary columns or file)
- Named/Built-on
MainAnalysis.R - Pass in gage or CSV as argument
- Maintainer: @ilonah22 @willprokopik @benhdye
- Separate functions from routines that call functions, i.e. Strasburg, Mount J, Coote's all call
flag_stable_baseflow() - TBD: we will have an Rmarkdown doc that accepts a list of gage ids as input, and generates all report tables and charts.
- event_identification, updated version of MainAnalysis.R
- analyze_recession
- MainAnalysisFunctionsPt1
- Separate functions from routines that call functions, i.e. Strasburg, Mount J, Coote's all call
- Include links to function files next to function name above
- Named/Built-on
- Sub-event Analysis (accepts event time series flow, criteria (kin/max agwrc, dAgwrc), returns set of descriptive stats and coefficients
- Called in the All Event identifier function file
- Accepts event data frame as argument, returns updated copy with new columns containing analysis metrics
- attach_event_stats, adds calculated AGWRC from each event and its
$R^2$ value. Would be pretty easy to include other stats or coefficients as well if we want. - Maintainer: @ilonah22
- Flag events as good/bad (do we already have a data model for this in the CSV?) based on:
- estimated AGWRC > 1.0 (for the mean value or whatever we are using tfor the overall event AGWRC)
- Slope to AGWRC (from @ilonah22 obserations below, but maybe have exception for asymptotic shape)
- Include links to function files next to function name above
- Single central copy of event dataset (separate files for each gage analyzed)
- Maintainers: @ilonah22 @willprokopik @benhdye
- Coote's Store
- Strasburg
- Mount Jackson
- Include links to CSVs in each gage location bullet above
- Single Event plotter(s)
- Maintainer: @willprokopik
- function name(s)
bfd=base flow drought:)- Apply same framework to other plots in review app -> e.g. create standalone functions for each plot shown in the review application
-
AGWRC & dAGWRC = f(t) - Others (maintainer indicate here)
- ReviewAppSkeleton updated "skeleton" version of the app that handles the now separated functions
- ReviewAppFunctions (ensure_review_columns; event_window; build_flow_plot; build_agwr_plot; event_summary_text; event_summary_footer)
- All Event plotter(s) & Analysis
-
$AGWRC = f(Q)$ - bfd_cfq_all(): creates plot of
$AGWRC = f(Q)$ for entire df of flows submitted - bfd_cfq_seasonal(): create 4-up plot of
$AGWRC = f(Q)$ for df of flows separated by season (may callbfd_cfq_all()) - AGWRC = f(t)
- bfd_cfq_all(): creates plot of
- Maintainer: @ilonah22
- Include links to function files next to function name above
-
- Projection tables function (when Q=q, AGWRC=c, AGWS=y, Q30=z1, Q60=z2,... generalized and specific examples for individual drought scenarios/
- Maintainer: @benhdye
- Overall Results breakdown
- 2 copies for each gage location: events, and by R-squared criteria
- A plot of
$AGWRC = f(Q)$ - A plot of AGWRC over time where each event's AGWRC is shown on the plot
- Maintainer: @benhdye
- Case Studies (will later merge into methods)
- ID Maintainer(s) of methods (collaborate with DEQ)
- Case studies (1930s, 2002, 2023, 2025),
- show projections at various points in drought.
- when do we get it right?
- What AGWRC value do we use?
- Maintainers: @ilonah22 @willprokopik @benhdye
- Relationship to previous work
- MLLR events for the winter prior to the event in question (see Image 2 below)
- (lower priority) Overall report generator
- Based in part on
MainAnalysis.R:- Accepts a list of gage ids as input, and generates all report tables and charts.
- Based in part on
- (lower priority) Methods documentation and scientific validity
- Document case studies from above
- Identification methods applied to modeled simulation.
- Does method capture 0.0 AGWin?
- What do charts of
AGWRC = f(Q)look like? Similar range in the points?
- Relationship to previous work
- File Locations:
Metadata
Metadata
Assignees
Labels
No labels