Closed
Conversation
nat-henderson
force-pushed
the
puppet-deletion-ordering
branch
2 times, most recently
from
edbd43c to
0b4263d
Compare
nat-henderson
force-pushed
the
puppet-deletion-ordering
branch
from
bc41bf2 to
4651d99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, as seen in discussion on #429, Puppet deletes things in entirely the wrong order. It will try to delete the things at the bottom of the dependency tree (e.g. disk) before the things at the top (e.g. instance). This is because Puppet doesn't understand that
ensure => absentmeans 'delete this resource' - we need to make that make sense to puppet by changing the autorequires and autobefores based on whether the resource is to be created or deleted.This is an experiment at the moment - no need to review until requested since I haven't tested it thoroughly.
[all]
[terraform]
[puppet]
Ensure correct ordering of deletions.
[puppet-bigquery]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-spanner]
[chef-sql]
[chef-storage]
[ansible]