Scraping: Filename search shouldn't have leftover extensions #205
Description
Describe the bug
The file ManicMiner.tzx.zip (filename you get from downloading from ZXInfo) gets searched as ManicMiner.tzx, with the .tzx leftover. ZXInfo search fails:
$ Skyscraper -p zxspectrum -s zxinfo -i "$(realpath .)" ManicMiner.tzx.zip
...
#34/39 (T2) Pass 1 ---- Game 'ManicMiner.tzx' not found :( ----
Presence of --flags unpack does not make a difference (it is screenscraper exclusive I think)
Merely renaming the zip file to ManicMiner.tzx (removing the double extension, not even unzipping it) makes the search match something:
#1/1 (T1) Pass 1 ---- Game 'ManicMiner' found! :) ----
Scraper: zxinfo (formerly: worldofspectrum)
From cache: NO
Search match: 90 %
Compare title: 'ManicMiner'
Result title: 'Manic Miner' ()
Platform: 'zxspectrum' ()
Release Date: '1992-01-01' ()
To Reproduce
I think all scrapers should be affected, though screenscraper searches usually still succeed because it gets a match on the checksum.
$ Skyscraper -p zxspectrum -s zxinfo -i "$(realpath .)" ManicMiner.tzx.zip
vs. (without modifying file or checksum)
$ Skyscraper -p zxspectrum -s zxinfo -i "$(realpath .)" ManicMiner.tzx
Expected behavior
Removing all extensions before searching, not just the "first" one. Alternatively a special case for .zip files (perhaps if the --flags unpack is used).
Special circumstances
Nothing unusual, though I'm a newbie.
Terminal output
$ Skyscraper -p zxspectrum -s zxinfo -i "$(realpath .)" ManicMiner.tzx.zip
------------------------------------------------------------
Running Skyscraper v3.18.1 by Lars Muldjord and contributors
------------------------------------------------------------
WARN: QString::arg: Argument missing: skipped-{1}-{2}.txt, zxspectrum
WARN: QString::arg: Argument missing: skipped-{1}-{2}.txt, worldofspectrum
Platform: 'zxspectrum'
Scraping module: 'worldofspectrum'
Input folder: '/var/shared/games/zxspectrum'
Game list folder: '~/RetroPie/roms/zxspectrum'
Cache folder: '~/.skyscraper/cache/zxspectrum'
DID YOU KNOW: When importing ratings ("-s import") you can use
either 5-star like scale (0.5, 1, 1.5, ... , 5) or decimal numbers scale (0.0
to 1.0) for the rating value.
Reading and parsing quick id xml, please wait... Done!
Building file lookup cache, please wait... Done!
Cached 179 files
Reading and parsing resource cache, please wait... Done!
Successfully parsed 766 resources!
Looking for optional 'priorities.xml' file in cache folder... Found!
Priorities loaded successfully!
Starting scraping run on 1 files using 4 threads.
Sit back, relax and let me do the work! :)
#1/1 (T1) Pass 1 ---- Game 'ManicMiner.tzx' not found :( ----
#1/1, (0/1)
Elapsed time : 00:00:00
Est. time left : 00:00:00
---- Resource gathering run completed! YAY! ----
Writing quick id xml, please wait... Done!
Writing 766 (0 new) resources to cache, please wait... Done!
---- And here are some neat stats :) ----
Total completion time: 00:00:00
Total number of games: 1
Successfully processed games: 0
Skipped games: 1 (Filenames saved to '~/.skyscraper/skipped-{1}-{2}.txt')
Technical information
- Configuration switches applied to Skyscraper (config.ini, commandline, ...): I've only changed
relativePathsto true in config.ini. - Internet connection: Relatively slow Wi-Fi
Skyscraper: 3.18.1
Qt: 6.9.3
Architecture: x86_64
Kernel: linux 6.17.13-200.fc42.x86_64
Operating System: Fedora Linux 42 (Workstation Edition)
Additional context