SessionMethods need to be functional in Rowan V4 ...

[dalehenrich]

The current Session method behavior does not match the behavior seen in a standard tode image.

To start with, the Rowan# image does not have SessionMethods enabled from the get go. Here's an annotated doit to show the behavior in 2 different use cases:

Use case 1

Validate that the a method can be compiled against Behavior as DataCurator ... SystemUser is tested mainly to determine if there is a difference between the behavior between DataCuratorandSystemUser`:

login

run
GsPackagePolicy currentOrNil.

GsPackagePolicy current enable.

Behavior compileMethod: 'xxx ^true'.

Object xxx.

System abort.

"tode_375_h DataCurator ... virgin tODE extent MNU"
Object xxx.

"rowan3_dev_h SystemUser ... standard Rowan V3 extent MNU"
"rowan3_dev_h DataCurator ... standard Rowan V3 extent MNU"
Behavior removeSelector: #'xxx'
%

In a tODE image, the session method does not survive across an abort ... as expected.

In a Rowan V3 3.7.5 extent, the method is still present after an abort, however, even though the Object class responds to the message xxx, it is not possible to remove the selector once it has been added.

Use case 2

In this case, we perform an abort at a later point.

run
GsPackagePolicy currentOrNil.

GsPackagePolicy current enable.

Behavior compileMethod: 'xxx ^true'.

Object xxx.
"rowan3_dev_h SystemUser ... standard Rowan V3 extent ERROR"
"rowan3_dev_h DataCurator ... standard Rowan V3 extent ERROR"
Behavior removeSelector: #'xxx'.

"tode_375_h DataCurator ... virgin tODE extent MNU"
Object xxx.

System abort.

Object xxx.
Behavior removeSelector: #'xxx'
%

In a tODE image, the session method is removed as expected.

In a Rowan V3 3.7.5 extent, again we see that in neither the SystemUser case nor the DataCurator are we able to remove the session method.

Summary

The interesting things to learn from these use cases, is that for Rowan SystemUser we do not expect SessionMethods to be invoked, since only DataCurator should require SessionMethods ... and DataCurator should behave indentically to tODE DataCurator ...

Project for use cases

The project used in the above use was derived from RowanSamplle9V4:spec_0004 using the following 3 workspaces (each delineated by "****************...********************":

"****************COPY********************"
| resolvedProject  definedProject |

resolvedProject := RwResolvedProject
	projectFromUrl: 'https://raw.githubusercontent.com/dalehenrich/RowanSample9V4/refs/heads/master/specs/spec_0004.ston' 
	projectsHome:  '/bosch1/users/dhenrich/_stones/git'.

definedProject := resolvedProject defined.

definedProject _concreteProject diskRepositoryRoot: '/bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/', definedProject projectName.

definedProject write

"****************READ/UPDATE/WRTIE********************"
| resolvedProject definedProject  package packageDef classExtensionDef |

resolvedProject := RwResolvedProject
	projectFromUrl:  'file:///bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/RowanSample9V4/rowan/specs/spec_0004.ston' 
	projectsHome:  '/bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/'.
	
definedProject := resolvedProject defined.
packageDef := definedProject  
	addPackageNamed: 'RowanSample9V4-Base-Extensions'
	toComponentNamed: 'Core1'.
(definedProject componentNamed: 'Core2') removeComponentNamed: 'Core1'.
definedProject
	gemstoneSetDefaultUseSessionMethodsForExtensionsForUser: 'DataCurator' 
		to: true;
	gemstoneSetSymbolDictName: 'Globals' 
		forPackageNamed: 'RowanSample9V4-Base-Extensions'.
classExtensionDef := packageDef addClassExtensionNamed: 'Behavior'.
classExtensionDef 
	addInstanceMethod: 'sample1' 
	protocol: '*', packageDef name.

definedProject write.

"****************LOAD********************"
| resolvedProject |

resolvedProject := RwResolvedProject
	projectFromUrl:  'file:///bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/RowanSample9V4/rowan/specs/spec_0004.ston' 
	projectsHome:  '/bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/'.

resolvedProject load.

Behavior sample1.

The SessionMethod support has not been tested against multiple users up to this point in time ... and it is a bit suprising that is almost functional 😎

[dalehenrich]

When running as DataCurator and modifying a method that is managed by a package owned by SystemUser -- the standard use case for using session methods -- I get a walkback (after rerouting the method compilation to Rowan):

The package 'GemStone-Rowan-Extensions-Tools' was not found

[1] ProcessorScheduler >> _switchFrom:to: @2 line 8
[2] ProcessorScheduler >> _reschedule @7 line 7
[3] ProcessorScheduler >> _suspendProcess: @8 line 8
[4] GsProcess >> suspend @7 line 8
[5] [] in RowanService >> setDebugActionBlock @47 line 46
[6] ExecBlock1 (ExecBlock) >> cull: @7 line 7
[7] UserDefinedError (AbstractException) >> _signalToDebugger @8 line 5
[8] UserDefinedError (AbstractException) >> defaultAction @2 line 18
[9] UserDefinedError (AbstractException) >> _defaultAction @4 line 4
[10] UserDefinedError (AbstractException) >> _signal @2 line 20
[11] UserDefinedError (AbstractException) >> signal @2 line 47
[12] RwGsImage class (Object) >> error: @6 line 7
[13] [] in RwGsImage class >> loadedRegistryForPackageNamed: @9 line 6
[14] RwGsImage class >> loadedRegistryForPackageNamed:ifAbsent: @4 line 10
[15] RwGsImage class >> loadedRegistryForPackageNamed: @2 line 5
[16] RwGsLoadedSymbolDictPackage >> propertiesForDefinition @6 line 5
[17] RwGsLoadedSymbolDictPackage (RwLoadedPackage) >> asDefinition @2 line 5
[18] [] in RwLoadedThing >> definitionsFor: @10 line 6
[19] [] in KeyValueDictionary >> do: @6 line 6
[20] KeyValueDictionary >> keysAndValuesDo: @23 line 20
[21] KeyValueDictionary >> do: @2 line 6
[22] RwGsLoadedSymbolDictResolvedProjectV2 (RwLoadedThing) >> definitionsFor: @5 line 6
[23] RwGsLoadedSymbolDictResolvedProjectV2 (RwLoadedProject) >> loadedPackageDefinitions @2 line 5
[24] RwGsLoadedSymbolDictResolvedProjectV2 >> asDefinition @5 line 7
[25] [] in RwAbstractTool >> definitionsForClassNamed:ifFound:ifAbsent: @10 line 8
[26] RwGsImage class >> loadedClassNamed:ifFound:ifAbsent: @11 line 11
[27] RwPrjBrowserToolV2 (RwAbstractTool) >> definitionsForClassNamed:ifFound:ifAbsent: @3 line 4
[28] RwPrjBrowserToolV2 >> addOrUpdateMethod:dictionaries:inProtocol:forClassNamed:isMeta:inPackageNamed: @17 line 74
[29] Behavior class (Behavior) >> rwCompileMethod:dictionaries:category:packageName: @8 line 26
[30] Behavior class (Behavior) >> _rwCompileMethodForConditionalPackaging:symbolList:category:environmentId:ifUnpackagedDo: @74 line 101
[31] Behavior class (Behavior) >> compileMethod:dictionaries:category:environmentId: @32 line 55
[32] Executed Code  @12 line 11
[33] GsNMethod >> _executeInContext: @1 line 11
[34] [] in RowanAnsweringService >> basicExec:context:shouldDebug:returningString: @38 line 17
[35] ExecBlock0 (ExecBlock) >> ensure: @2 line 12
[36] RowanAnsweringServiceServer (RowanAnsweringService) >> basicExec:context:shouldDebug:returningString: @19 line 22
[37] RowanAnsweringServiceServer (RowanAnsweringService) >> basicExecReturningPrintString:context:shouldDebug: @2 line 3
[38] RowanAnsweringServiceServer (RowanAnsweringService) >> execReturningPrintString:context:shouldDebug: @2 line 3
[39] RowanAnsweringServiceServer (Object) >> perform:withArguments: @1 line 12
[40] RowanAnsweringServiceServer (RowanService) >> servicePerform:withArguments:shouldUpdate: @5 line 7
[41] RowanAnsweringServiceServer (RowanService) >> servicePerform:withArguments: @2 line 4
[42] [] in RowanService >> executeCommand @21 line 11
[43] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[44] [] in RowanService >> executeCommand @10 line 12
[45] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[46] RowanAnsweringServiceServer (RowanService) >> executeCommand @4 line 19
[47] RowanAnsweringServiceServer (Object) >> perform:withArguments: @1 line 12
[48] RsrMessageSend >> perform @5 line 4
[49] [] in RsrSendMessage >> perform:answerUsing: @9 line 6
[50] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[51] RsrSendMessage >> perform:answerUsing: @3 line 9
[52] [] in RsrSendMessage >> executeFor: @34 line 21
[53] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[54] [] in RsrSendMessage >> executeFor: @9 line 22
[55] ExecBlock0 (ExecBlock) >> ensure: @2 line 12
[56] RsrSendMessage >> executeFor: @4 line 26
[57] [] in RsrConnection >> _receivedCommand: @10 line 7
[58] [] in RsrProcessModel >> fork:named: @7 line 5
[59] ExecBlock >> valueWithArguments: @1 line 7
[60] GsProcess >> _start @7 line 16
[61] GsNMethod class >> _gsReturnToC @1 line 11

Looks like in the neighborhood of [15] RwGsImage class >> loadedRegistryForPackageNamed: we need to start thinking about session methods ...

Maybe a lookup along the lines of loadedRegistryForPackageNamed:byUserNamed:?

[dalehenrich]

Oh ... in order to force the stack above you have to pass session method responsibility to Rowan by making the following change to Behavior>>compileMethod:dictionaries:category:environmentId as SystemUser:

Change:
	line 40:		mDict
	line 41:			ifNotNil: [ 
To:
	line 40:		nil
	line 41:			ifNotNil: [ 

Then execute the following as DataCurator:

GsPackagePolicy enabled
	ifTrue: [ self halt: 'sessions methods already enabled' ].

GsPackagePolicy currentOrNil.

GsPackagePolicy current enable.
GsPackagePolicy loadSessionMethodDictionary.

Behavior addCategory: 'session methods' environmentId: 0. 		"category added with session methods enabled in rowan image"
Behavior 
	compileMethod: 'xxx ^true'
	dictionaries: GsCurrentSession currentSession symbolList
	category: 'session methods'
	environmentId: 0.

[dalehenrich]

A more realistic and interesting example is to load a project that is built to use the Rowan session method features... in 3 steps

Step 1: create a local disk copy of project RowanSample9V4:spec_0004

"****************COPY********************"
| resolvedProject  definedProject |

resolvedProject := RwResolvedProject
	projectFromUrl: 'https://raw.githubusercontent.com/dalehenrich/RowanSample9V4/refs/heads/master/specs/spec_0004.ston' 
	projectsHome:  '/bosch1/users/dhenrich/_stones/git'.

definedProject := resolvedProject defined.

definedProject _concreteProject diskRepositoryRoot: '/bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/', definedProject projectName.

definedProject write

Step 2: update the copied project to use session methods to extend Behavior

"****************READ/UPDATE/WRITE********************"
| resolvedProject definedProject  package packageDef classExtensionDef |

resolvedProject := RwResolvedProject
	projectFromUrl:  'file:///bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/RowanSample9V4/rowan/specs/spec_0004.ston' 
	projectsHome:  '/bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/'.
	
definedProject := resolvedProject defined.
packageDef := definedProject  
	addPackageNamed: 'RowanSample9V4-Base-Extensions'
	toComponentNamed: 'Core1'.
(definedProject componentNamed: 'Core2') removeComponentNamed: 'Core1'.
definedProject
	gemstoneSetDefaultUseSessionMethodsForExtensionsForUser: 'DataCurator' 
		to: true;
	gemstoneSetSymbolDictName: 'Globals' 
		forPackageNamed: 'RowanSample9V4-Base-Extensions'.
classExtensionDef := packageDef addClassExtensionNamed: 'Behavior'.
classExtensionDef 
	addInstanceMethod: 'sample1' 
	protocol: '*', packageDef name.

definedProject write.

Step 3: enable session methods

"****************ENABLE********************"
GsPackagePolicy enabled
	ifFalse: [ 
		GsPackagePolicy current enable.
		GsPackagePolicy loadSessionMethodDictionary ].

Step 4: load the project as DataCurator

"****************LOAD********************"
| resolvedProject |

resolvedProject := RwResolvedProject
	projectFromUrl:  'file:///bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/RowanSample9V4/rowan/specs/spec_0004.ston' 
	projectsHome:  '/bosch1/users/dhenrich/_stones/37x/stones/rowan3_dev_h/sandbox/'.

resolvedProject load.

Behavior sample1.

note that the above session method API may change during the course implementing the feature...

[dalehenrich]

Here's the stack that gets produced when running Step 4: load the project as DataCurator:

a SecurityError occurred (error 2116), An attempt was made to modify the object aKeyValueDictionary( '...') in objectSecurityPolicyId 1 with insufficient authorization.

[1] ProcessorScheduler >> _switchFrom:to: @2 line 8
[2] ProcessorScheduler >> _reschedule @7 line 7
[3] ProcessorScheduler >> _suspendProcess: @8 line 8
[4] GsProcess >> suspend @7 line 8
[5] [] in RowanService >> setDebugActionBlock @47 line 46
[6] ExecBlock1 (ExecBlock) >> cull: @7 line 7
[7] SecurityError (AbstractException) >> _signalToDebugger @8 line 5
[8] SecurityError (AbstractException) >> defaultAction @2 line 18
[9] SecurityError (AbstractException) >> _defaultAction @4 line 4
[10] SecurityError (AbstractException) >> _signalFromPrimitive @2 line 10
[11] KeyValueDictionary (AbstractDictionary) >> _basicAt:put: @1 line 12
[12] KeyValueDictionary >> atHash:putKey:value: @8 line 15
[13] KeyValueDictionary >> at:put: @13 line 15
[14] RwGsSymbolDictionaryRegistry_ImplementationV2 class >> createLoadedPackageNamed:properties:instance: @14 line 9
[15] RwGsSymbolDictionaryRegistry_ImplementationV2 class >> createLoadedPackageFromDefinition:instance: @4 line 4
[16] RwGsSymbolDictionaryRegistryV2 >> createLoadedPackageFromDefinition:implementationClass: @2 line 5
[17] RwGsPackageAdditionSymbolDictPatchV2 >> createLoadedPackage @4 line 5
[18] [] in RwGsPatchSet_V2 >> addAndUpdateLoadedPackages @5 line 5
[19] [] in Set >> do: @7 line 11
[20] KeyValueDictionary >> keysDo: @19 line 18
[21] Set >> do: @3 line 11
[22] RwGsPatchSet_V2 >> addAndUpdateLoadedPackages @2 line 5
[23] RwGsPatchSet_V2 >> apply @17 line 20
[24] RwGsImage class >> applyModification_V2:visitorClass:instanceMigrator:symbolList: @11 line 9
[25] RwGsImage class >> applyModification_V2:instanceMigrator:symbolList: @8 line 12
[26] RwPrjLoadToolV2 >> _loadProjectSetDefinition:instanceMigrator:symbolList: @17 line 51
[27] [] in RwPrjLoadToolV2 >> _doProjectSetLoad:instanceMigrator:symbolList:originalProjectSet:processedClassNames: @20 line 6
[28] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[29] RwPrjLoadToolV2 >> _doProjectSetLoad:instanceMigrator:symbolList:originalProjectSet:processedClassNames: @6 line 9
[30] RwPrjLoadToolV2 >> _loadProjectDefinition:customConditionalAttributes:instanceMigrator:symbolList: @16 line 20
[31] RwResolvedProjectV2 >> load: @10 line 9
[32] RwResolvedProjectV2 >> load @4 line 10
[33] RwResolvedProject (RwAbstractUnloadedProject) >> load @3 line 10
[34] Executed Code  @4 line 7
[35] GsNMethod >> _executeInContext: @1 line 11
[36] [] in RowanAnsweringService >> basicExec:context:shouldDebug:returningString: @38 line 17
[37] ExecBlock0 (ExecBlock) >> ensure: @2 line 12
[38] RowanAnsweringServiceServer (RowanAnsweringService) >> basicExec:context:shouldDebug:returningString: @19 line 22
[39] RowanAnsweringServiceServer (RowanAnsweringService) >> basicExecReturningPrintString:context:shouldDebug: @2 line 3
[40] RowanAnsweringServiceServer (RowanAnsweringService) >> execReturningPrintString:context:shouldDebug: @2 line 3
[41] RowanAnsweringServiceServer (Object) >> perform:withArguments: @1 line 12
[42] RowanAnsweringServiceServer (RowanService) >> servicePerform:withArguments:shouldUpdate: @5 line 7
[43] RowanAnsweringServiceServer (RowanService) >> servicePerform:withArguments: @2 line 4
[44] [] in RowanService >> executeCommand @21 line 11
[45] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[46] [] in RowanService >> executeCommand @10 line 12
[47] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[48] RowanAnsweringServiceServer (RowanService) >> executeCommand @4 line 19
[49] RowanAnsweringServiceServer (Object) >> perform:withArguments: @1 line 12
[50] RsrMessageSend >> perform @5 line 4
[51] [] in RsrSendMessage >> perform:answerUsing: @9 line 6
[52] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[53] RsrSendMessage >> perform:answerUsing: @3 line 9
[54] [] in RsrSendMessage >> executeFor: @34 line 21
[55] ExecBlock0 (ExecBlock) >> on:do: @3 line 44
[56] [] in RsrSendMessage >> executeFor: @9 line 22
[57] ExecBlock0 (ExecBlock) >> ensure: @2 line 12
[58] RsrSendMessage >> executeFor: @4 line 26
[59] [] in RsrConnection >> _receivedCommand: @10 line 7
[60] [] in RsrProcessModel >> fork:named: @7 line 5
[61] ExecBlock >> valueWithArguments: @1 line 7
[62] GsProcess >> _start @7 line 16
[63] GsNMethod class >> _gsReturnToC @1 line 11