From 038bf3eff60987903138ed3aaf489329581be946 Mon Sep 17 00:00:00 2001 From: Allie Collow <31133739+acollow@users.noreply.github.com> Date: Fri, 6 Feb 2026 11:52:34 -0500 Subject: [PATCH 1/4] Update CONTRIBUTING.md Specify instructions for regression testing to be completed prior to submitting a PR. --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9d2eda1d..39d339d5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,6 @@ # Contributing to GOCART -Contributing code to GOCART should be done via a Pull Request to this repository. +Contributing code to GOCART should be done via a Pull Request (PR) to this repository. Prior to submitting a for zero-diff change, testing following guidelines at https://github.com/GEOS-ESM/GEOSgcm_GridComp/wiki/Zero-diff-changes must be completed. ## Contributor License Agreement (CLA) From e817137fd56b755fe716387dc449466c01af6e8c Mon Sep 17 00:00:00 2001 From: Allie Collow <31133739+acollow@users.noreply.github.com> Date: Fri, 6 Feb 2026 11:53:54 -0500 Subject: [PATCH 2/4] fix typo --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 39d339d5..1ce0809c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,6 @@ # Contributing to GOCART -Contributing code to GOCART should be done via a Pull Request (PR) to this repository. Prior to submitting a for zero-diff change, testing following guidelines at https://github.com/GEOS-ESM/GEOSgcm_GridComp/wiki/Zero-diff-changes must be completed. +Contributing code to GOCART should be done via a Pull Request (PR) to this repository. Prior to submitting a PR for a zero-diff change, testing following guidelines at https://github.com/GEOS-ESM/GEOSgcm_GridComp/wiki/Zero-diff-changes must be completed. ## Contributor License Agreement (CLA) From aad51e2ea43298deadc5141b01f31582e10cbd0d Mon Sep 17 00:00:00 2001 From: Allie Collow <31133739+acollow@users.noreply.github.com> Date: Fri, 6 Feb 2026 14:25:41 -0500 Subject: [PATCH 3/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ae1905c4..ea3f8817 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed ### Added - +- Guidance for submitting PRs on contributing guidelines ## [v2.6.0] - 2026-02-05 ### Changed From 6132d5e6656dc2f5663dd664d6a64f753fdcc8f2 Mon Sep 17 00:00:00 2001 From: Allie Collow <31133739+acollow@users.noreply.github.com> Date: Tue, 17 Feb 2026 14:51:02 -0500 Subject: [PATCH 4/4] Update CONTRIBUTING.md take 2! --- CONTRIBUTING.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1ce0809c..52fc9c5f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,13 @@ # Contributing to GOCART -Contributing code to GOCART should be done via a Pull Request (PR) to this repository. Prior to submitting a PR for a zero-diff change, testing following guidelines at https://github.com/GEOS-ESM/GEOSgcm_GridComp/wiki/Zero-diff-changes must be completed. +Contributing code to GOCART should be done via a Pull Request (PR) to this repository. + +Prior to submitting a PR, testing must be performed for start-stop and layout regression. Regression testing can be accomplished by running gcm_regress.j in the regress subdirectory of an experiment setup. Regression testing will take about thirty minutes to complete, and text files will be generated that indicate either PASS or FAIL for each regression test. + +For zero-diff PRs, it must be documented that the change is zero-diff by running three sets of one day simulations using the executable before and after the changes were made: 1) an AMIP, 2) a replay, and 3) a zero-increment replay. The zero-increment replay should also be identical to the AMIP simulation. More information on how to run these types of simulations can be found at https://github.com/GEOS-ESM/GEOSgcm_GridComp/wiki/How-to-Run-GEOS-Zero-Diff-Tests. + +The impacts of non zero-diff PRs must be clearly documented for consideration. + ## Contributor License Agreement (CLA)