Suggestive comments + mirror and addFairlead methods in project.py:

- should the node in famodel_base be three-dimensional?
- the way the load function seems to create the fairlead dictionary seems erroneous. I suggested an alternative as a comment. This is how it is done in conceptDesign2.
- the addFairlead updates the fairlead position and reflects the absolute location of fairlead positions 'fl.r' which can be helpful later. Especially when connecting to moorings.
- Update to the  function to make it work with the new base work with the shared lines.

Author: Yuksel-Rudy

famodel/famodel_base.py

@@ -98,7 +98,7 @@ def __init__(self, id):
         self.part_of = None  # whether this object is part of an Edge group
 
         # position/orientation variables
-        self.r = np.zeros(2)  # position [m]
+        self.r = np.zeros(2)  # position [m]  <<< Rudy: Can we consider 3D here??
         self.theta = 0  # heading [rad] CCW+
         self.R = np.eye(2)  # rotation matrix
 

famodel/mooring/mooring.py

@@ -706,88 +706,78 @@ def positionSubcomponents(self):
                             else:
                                 print('end of parallel')
                                 breakpoint()
-    
-    def mirror(self,create_subsystem=True):
-        ''' Mirrors a half design dictionary. Useful for symmetrical shared mooring lines where 
-        only half of the line is provided 
 
-        Parameters
-        ----------
-        create_subsystem : bool, optional
-            Controls whether to create a new subsystem after mirroring dd.
-            Default is True
+    def mirror(self, create_subsystem=True):
         '''
-        # disconnect all sections and connectors
-        # TODO: update to work with dd['subcomponents']
+        Mirrors a half design to create a full line (symmetry assumption).
+        Works with self.sections() and self.connectors() instead of self.dd.
+        '''
+
+        # detach existing subcomponents
         for i in self.i_sec:
             sec = self.getSubcomponent(i)
             sec.detachFrom(end='a')
             sec.detachFrom(end='b')
-        # find out if the connector at end A (center of line) is empty 
-        if not self.dd['connectors'][0] or self.dd['connectors'][0]['m']==0:
-            # do not double the middle section length
-            doubleL = True
+
+        # copy base sections and connectors
+        sections = deepcopy(self.sections())
+        connectors = deepcopy(self.connectors())
+
+        # check middle connector (connector[0] assumed at line center)
+        if not connectors[0] or connectors[0].get('m', 0) == 0:
+            doubleL = True   # double the middle section length instead
         else:
-            # double the middle section length 
-            doubleL = False
-        from copy import deepcopy
-        # sections list is currently reversed (second half of full list)
-        addSections = deepcopy(self.dd['sections'])
-        addConns = deepcopy(self.dd['connectors'])
-        # reverse to get first half of full list
-        self.dd['sections'].reverse()
-        self.dd['connectors'].reverse()
-        # combine middle mirrored sections into one by removing from add list and doubling length
+            doubleL = False  # double connector mass/volume instead
+
+        # prepare mirrored versions
+        addSections = deepcopy(sections)
+        addConns = deepcopy(connectors)
+
+        # handle the middle connector
         if doubleL:
-            # remove mirror section and connector in middle, double length of middle section
+            # drop first section + connector, double middle section length
             addSections.pop(0)
             addConns.pop(0)
-            self.dd['connectors'].pop(-1)
-            self.dd['sections'][-1]['L'] = self.dd['sections'][-1]['L']*2
+            connectors.pop(0)  # drop first original connector
+            sections[0]['L'] *= 2
         else:
+            # drop first mirrored connector, double last connector’s props
             addConns.pop(0)
-            self.dd['connectors'][-1]['m'] *= 2
-            self.dd['connectors'][-1]['v'] *= 2
+            connectors[0]['m'] *= 2
+            connectors[0]['v'] *= 2
 
-            
-        # combine addSections and current reversed sectiosn list
-        self.dd['sections'].extend(addSections)
-        self.dd['connectors'].extend(addConns)
+        # reverse and extend lists
+        sections.reverse()
+        connectors.reverse()
+        sections.extend(addSections)
+        connectors.extend(addConns)
+
+        # update Mooring design dictionary with these sections and connectors
 
-        # create Section objects for ALL sections and connectors
-        for i, sec in enumerate(self.dd['sections']):
-            self.dd['sections'][i] = Section('Section'+str(i),**self.dd['sections'][i])
-        
-        for i,con in enumerate(self.dd['connectors']):
-            if con and 'type' in con:
-                Cid=con['type']+str(i)
-            else:
-                Cid = 'Conn'+str(i)
-                
-            self.dd['connectors'][i] = Connector(Cid,**self.dd['connectors'][i])        
-        
-        # Connect them and store them in self(Edge).subcomponents!
-        subcons = []  # temporary list of node-edge-node... to pass to the function
-        for i in range(len(self.dd['sections'])):
-            subcons.append(self.dd['connectors'][i])
-            subcons.append(self.dd['sections'][i])
-        subcons.append(self.dd['connectors'][-1])
-        self.addSubcomponents(subcons)  # Edge method to connect and store em
-        
-        self.n_sec = len(self.dd['sections'])
-        # Indices of connectors and sections in self.subcomponents list
-        self.i_con = list(range(0, 2*self.n_sec+1, 2))
-        self.i_sec = list(range(1, 2*self.n_sec+1, 2))
-    
 
-        # creat subsystem if asked
+
+        # -----------------------------
+        # build alternating subcomponent list
+        # [C0, S0, C1, S1, ..., Sn, Cn+1], where n is the number of sections.
+        # -----------------------------
+        subs_list = []
+        for i in range(len(sections)):
+            subs_list.append(connectors[i])
+            subs_list.append(sections[i])
+        subs_list.append(connectors[-1])
+
+        # convert dicts into Section/Connector objects
+        self.dd['subcomponents'] = subs_list
+        self.subcomponents = []
+        self.i_con = []  # reset indices
+        self.i_sec = []        
+        self.convertSubcomponents(subs_list)        
+        self.addSubcomponents(self.dd['subcomponents'])
+        # create subsystem if asked
         if create_subsystem:
             self.createSubsystem(case=1)
 
 
-
-        
-    
     """
     # rough method ideas...maybe not necessary or can use existing dict methods
     def ddApply():

famodel/project.py

@@ -1667,7 +1667,7 @@ def addFairlead(self, id=None, platform=None, r_rel=[0,0,0],
         # attach subordinately to platform and provide relative location
         if platform:
             platform.attach(fl, r_rel=r_rel)
-            
+            fl.r = platform.r + r_rel # absolute location
         # attach equally to mooring end connector
         if mooring:
             if end in ['a','A',0]:
@@ -4282,8 +4282,14 @@ def unload(self,file='project.yaml'):
             ts_loc = 0
             msys = []
             newms = True
-            fairleads = [att['r_rel'] for att in pf.attachments.values() if isinstance(att['obj'], Fairlead)]
-            jtubes = [att['r_rel'] for att in pf.attachments.values() if isinstance(att['obj'], Jtube)]
+            fairleads = [att['r_rel'] for att in pf.attachments.values() if isinstance(att['obj'], Fairlead)]  # Rudy: this line is getting att['r_rel'] only. But in LoadDesign, it's looking for the 'heading' or 'r_rel' attribute of the fairlead. Therefore, I omitted '[r_rel']' here and passed the att object as a whole.
+            # Rudy: maybe consider this instead:
+            # pf_dd_['fairleads'] = [
+            #                 {'r_rel': att['r_rel']} 
+            #                 for att in platform.attachments.values() 
+            #                 if isinstance(att['obj'], Fairlead)
+            #                       ]            
+            jtubes = [att['r_rel'] for att in pf.attachments.values() if isinstance(att['obj'], Jtube)]  # Rudy: perhaps same here too???
             if not 'type' in pf.dd:                    
                 pf_type_info = [pf.rFair, pf.zFair, pf.entity, fairleads, jtubes]
                 if not pf_type_info in pf_types:

setup.py

@@ -4,7 +4,7 @@
     long_description = fh.read()
 
 setuptools.setup(
-    name="FAModel",
+    name="famodel",
     version="0.1.0",
     author="National Renewable Energy Laboratory",
     author_email="matthew.hall@nrel.gov",