From 9135d9d509b323dc9dd89549378b093c42bda43b Mon Sep 17 00:00:00 2001 From: jckhoe Date: Fri, 6 Feb 2026 19:46:22 +0800 Subject: [PATCH 1/2] update asserts for role --- systemtest/tests/auth.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/systemtest/tests/auth.go b/systemtest/tests/auth.go index 25039dd..c28c94a 100644 --- a/systemtest/tests/auth.go +++ b/systemtest/tests/auth.go @@ -24,7 +24,7 @@ func TestRegister(t *testing.T, router *gin.Engine, jwtSecret string) { var resp dto.RegisterResponse require.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp)) assert.Equal(t, "testuser", resp.Username) - assert.Equal(t, "Student", resp.Role) + assert.Equal(t, "User", resp.Role) assert.NotEmpty(t, resp.ID) }) @@ -69,7 +69,7 @@ func TestLogin(t *testing.T, router *gin.Engine, jwtSecret string) { claims, err := auth.ValidateToken(jwtSecret, resp.Token) require.NoError(t, err) assert.Equal(t, "loginuser", claims.Username) - assert.Equal(t, "Student", claims.Role) + assert.Equal(t, "User", claims.Role) }) t.Run("wrong password", func(t *testing.T) { From edff8d8f58ec8d9b93aaf017289a6964e161f1ff Mon Sep 17 00:00:00 2001 From: Jason Lee Date: Sat, 7 Feb 2026 11:09:33 +0800 Subject: [PATCH 2/2] use enum --- systemtest/tests/auth.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/systemtest/tests/auth.go b/systemtest/tests/auth.go index c28c94a..7d9bf24 100644 --- a/systemtest/tests/auth.go +++ b/systemtest/tests/auth.go @@ -9,6 +9,7 @@ import ( "github.com/EternisAI/silo-proxy/internal/api/http/dto" "github.com/EternisAI/silo-proxy/internal/auth" + "github.com/EternisAI/silo-proxy/internal/db/sqlc" "github.com/gin-gonic/gin" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" @@ -24,7 +25,7 @@ func TestRegister(t *testing.T, router *gin.Engine, jwtSecret string) { var resp dto.RegisterResponse require.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp)) assert.Equal(t, "testuser", resp.Username) - assert.Equal(t, "User", resp.Role) + assert.Equal(t, sqlc.UserRoleUser, resp.Role) assert.NotEmpty(t, resp.ID) }) @@ -69,7 +70,7 @@ func TestLogin(t *testing.T, router *gin.Engine, jwtSecret string) { claims, err := auth.ValidateToken(jwtSecret, resp.Token) require.NoError(t, err) assert.Equal(t, "loginuser", claims.Username) - assert.Equal(t, "User", claims.Role) + assert.Equal(t, sqlc.UserRoleUser, claims.Role) }) t.Run("wrong password", func(t *testing.T) {