Fix SwiftUI ViewBuilder and Syntax Errors

[DrunkOnJava]

Issue Description

Multiple SwiftUI-related syntax errors are preventing successful compilation, primarily related to ViewBuilder context, brace mismatches, and return statement issues.

Types of SwiftUI Errors

ViewBuilder Context Issues

• Expressions are not allowed at the top level
• Cannot use explicit 'return' statement in the body of result builder 'ViewBuilder'
• Logic or variable declarations incorrectly placed inside ViewBuilder blocks

Brace Mismatch Issues

• Expected declaration
• Extraneous '}' at top level
• Missing { or extra } causing parsing errors

Opaque Return Type Issues

• Function declares an opaque return type, but has no return statements in its body from which to infer an underlying type
• Functions returning some View without proper return statements

Affected Files

• Features-Locations/Sources/FeaturesLocations/ViewModels/LocationsListViewModel.swift (lines 198, 201)
• UI-Components/Sources/UIComponents/Cards/ItemCard.swift (lines 74, 94, 101)
• UI-Components/Sources/UIComponents/Search/EnhancedSearchBar.swift (lines 32, 252, 262)

Specific Error Examples

LocationsListViewModel.swift

Line 198: Expected declaration
Line 201: Extraneous '}' at top level

ItemCard.swift

Line 74: Function declares an opaque return type, but has no return statements
Line 94: Expressions are not allowed at the top level  
Line 101: Extraneous '}' at top level

EnhancedSearchBar.swift

Line 32: Expected declaration
Line 252: Extraneous '}' at top level
Line 262: Cannot use explicit 'return' statement in the body of result builder 'ViewBuilder'

Root Cause

1. Brace Mismatches: Missing or extra braces causing parser confusion
2. ViewBuilder Violations: Complex logic placed directly in ViewBuilder contexts
3. Missing Return Statements: Functions returning some View without returns
4. Incorrect Return Usage: Explicit return in ViewBuilder where not needed

Solution Plan

1. Fix Brace Mismatches

• Use Xcode's code folding to identify unmatched braces
• Ensure every { has a corresponding }
• Verify proper nesting of closures and function bodies

2. Restructure ViewBuilder Code

// Instead of logic directly in ViewBuilder:
var body: some View {
    let someValue = complexCalculation()
    VStack {
        Text(someValue)
    }
}

// Move logic outside ViewBuilder:
var body: some View {
    VStack {
        Text(computedValue)
    }
}

private var computedValue: String {
    return complexCalculation()
}

3. Fix Return Statements

// For single-expression views, omit return:
var body: some View {
    Text("Hello")  // No return needed
}

// For complex views, ensure all paths return a View:
var body: some View {
    if condition {
        Text("A")
    } else {
        Text("B")
    }
}

// If no view should be shown:
var body: some View {
    if condition {
        Text("Something")
    } else {
        EmptyView()  // Explicit empty view
    }
}

4. Use Group for Complex Logic

var body: some View {
    Group {
        if complexCondition {
            VStack {
                // Complex view hierarchy
            }
        } else {
            HStack {
                // Alternative view hierarchy
            }
        }
    }
}

Priority

Medium - These errors prevent UI compilation but don't affect core functionality.

Acceptance Criteria

• All "Expected declaration" errors are resolved
• All "Extraneous '}' at top level" errors are resolved
• All "Expressions are not allowed at the top level" errors are resolved
• All functions returning some View have proper return statements
• ViewBuilder contexts only contain valid SwiftUI view code
• All SwiftUI views compile successfully
• UI components render correctly in the app