-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Issue Description
Multiple types claim to conform to protocols but are missing required properties or methods, causing compilation failures.
ServiceError Protocol Conformance Issues
The following error types need to implement the telemetryData property:
NetworkErrorExportErrorSyncErrorBarcodeLookupErrorAuthenticationErrorStorageErrorSecurityErrorMonitoringError
Required: var telemetryData: TelemetryData { get }
Repository Protocol Conformance Issues
MockItemRepository missing methods:
fetchInDateRange(from:to:)updateAll(_:)search(_:)(incorrect argument labels)findByBarcode(_:)
MockCategoryRepository missing methods:
fetchBuiltIn()fetchCustom()canDelete(_:)fetch(id:)
MockSoundService missing methods:
playHapticFeedback(_:)
MockScanHistory missing methods:
search(_:)findByBarcode(_:)
MockOfflineScanQueue missing methods:
getAllPendingScans()add(_:)remove(_:)clearAll()getPendingCount()
MockNetworkMonitor missing properties:
connectionStatusStream
MockBarcodeLookupService missing methods:
lookupItem(barcode:)lookupBatch(_:)isSupported(barcode:)
MockReceiptRepository missing methods:
remove(forKey:)fetchByDateRange(from:to:)fetchByStore(_:)fetchByItemId(_:)fetchAboveAmount(_:)
SwiftUI View Conformance Issues
VoiceSearchViewmissingbodyproperty for View protocol
ObservableObject Conformance Issues
Classes used with @StateObject/@ObservedObject missing ObservableObject conformance:
LocationsListViewModelAnalyticsDashboardViewModelReceiptsListViewModelBatchScannerViewModelDocumentScannerViewModelBarcodeScannerViewModelInventoryCoordinatorLocationsCoordinatorAnalyticsCoordinator
Method Signature Issues
ItemRepository.search(query:)vs requiredsearch(_:)- incorrect argument labels
Root Cause
- Protocols updated but conforming types not updated
- Mock implementations missing required methods
- Incorrect method signatures in protocol conformance
- Missing ObservableObject conformance for ViewModels
- TelemetryData type not defined
Solution Plan
- Define TelemetryData struct in Foundation-Core
- Implement telemetryData property for all ServiceError conforming types
- Add missing methods to all mock repository implementations
- Fix method signatures to match protocol requirements
- Add ObservableObject conformance to all ViewModels
- Implement missing View body for SwiftUI views
- Update argument labels to match protocol definitions
Priority
High - These errors prevent successful compilation and proper protocol usage.
Acceptance Criteria
- All "does not conform to protocol" errors are resolved
- TelemetryData type is properly defined and implemented
- All mock repositories have complete method implementations
- All ViewModels conform to ObservableObject
- All SwiftUI Views have proper body implementations
- Method signatures match protocol requirements exactly
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working