Refactor: Extract magic numbers and improve logging in SearchService

[DrunkOnJava]

Background

PR #217 successfully implemented item name suggestions in SearchService, but code review identified several improvements that should be made:

Tasks

• Extract magic numbers as named constants:
  • Base score (0.8)
  • Position penalty (0.02)
  • Minimum score (0.1)
• Replace print statements with proper logging using os_log or logging framework
• Fix test brittleness by avoiding hardcoded expectation counts
• Clarify misleading comments about item limits

Suggested Implementation

private enum ScoringConstants {
    static let baseScore = 0.8
    static let positionPenalty = 0.02
    static let minimumScore = 0.1
}

// Use os_log for error logging
import os.log
os_log("Error fetching suggestions: %{public}@", log: .default, type: .error, String(describing: error))

Related

• Original PR: feat: Implement actual item name suggestions in SearchService #217
• Original issue: Implement actual item name suggestions in SearchService #196