Skip to content

Consider making maxTokens configurable based on model capabilities #69

@DimitriGilbert

Description

@DimitriGilbert

CodeRabbit
Consider making maxTokens configurable based on model capabilities

The hardcoded maxTokens: 4096 might not be suitable for all models. Some models support more, while others support less.

+      // Get model-specific max tokens or use a reasonable default
+      const modelMaxTokens = modelInstance.maxOutputTokens || 4096;
+      const maxTokens = Math.min(modelMaxTokens, 4096); // Cap at 4096 for code generation
+      
       const result = await AIService.generateCompletion({
         model: modelInstance,
         system: systemPrompt,
         messages: [{ role: "user", content: userPrompt }],
         temperature: 0.1,
-        maxTokens: 4096,
+        maxTokens: maxTokens,
       });

settings... i might have to ask suno for something...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions