-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Description
A list of updates to make to Tabs, Tab, TabList, and TabPanel after doing a group code review.
- Change onSelect to onChange in Tabs.js
- Add onBeforeChange
- Replace cwrp with componentDidUpdate
- Change selectedIndex to activeIndex
- Kill TabList if possible
- Ignore selected prop in Tab docs if only used as pass through from parent, otherwise kill
- Change setSelectedTab in Tab to onChange and return active state
- Move padding from .bordered to .tabPanel in TabPanel
- Change bordered prop to border
- Kill icon prop
- Kill tabIndex prop
- Ignore vertical prop in Tab docs
- Change Tabs to TabList
- Kill Tab
- Rename TabPanel to Tab and offer title prop which accepts a node
- TabList (new) will loop through Tab components, get titles, and create Tab Header div
Metadata
Metadata
Assignees
Labels
No labels