Skip to content

float input Deprecated for math.factorial #1

@jasonfan1997

Description

@jasonfan1997

Hi @ElimThompsonFDA , I tried running the example script on my python environment and https://github.com/DIDSR/QuCAD/blob/main/scripts/tools/calculator.py#L137 threw me a type error.

From, https://docs.python.org/3/library/math.html#math.factorial

It seems math.factorial float input support is deprecated in Python 3.9 and above. I think the easiest way to handle it is to change all math.factorial to numpy.math.factorial since numpy is required and imported here anyway.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions