getDeviceType is inconsistent

[nmiglio]

I think there are a few issues with the device type detection. as it is now seems that everything smaller than "small" is detected as a watch. what is between small and large is a phone and what is bigger than large can be a desktop or a tablet.
Why use 2 breakpoints (small and large) to discriminate between 4 device types? And classifiyng everything smaller than 600 logical pixel as a watch is a bit too rough..

In addition I tested the library, setting the breakpoints at 600 and 900, having a tablet with 768 logical pixels. the result is that I cannot detect my device as a tablet. you can actually only force the tablet detection with sizes bigger than "large". this goes against some of the documentation of the library (and makes it not usable in my case - not at least as it is..).

I would suggest to use at least 3 breakpoints. maybe you can keep the option to force a tablet or a desktop with the biggest screen sizes, but is it useful?

[ppamorim]

@nmiglio Thank you for your feedback.

now seems that everything smaller than "small" is detected as a watch. -> I am not sure how applicable is that, if you check the original source code, the function used to detect the watch size is the very same you can find in this library. I still think that detecting the device type by the screen size was incorrect, there are so many other metrics that could be used to better represent the device type.

Why use 2 breakpoints (small and large) to discriminate between 4 device types? -> I get your point and I will review this implementation, I believe we should restore the normal (what is normal after all?) size and also change how watch devices are detected, with the inclusion of a fallback using the screen size as a guide too.

In addition I tested the library, setting the breakpoints at 600 and 900, having a tablet with 768 logical pixels. -> Are you sure this is the case? The library now detects the device by the platform it's running with the option to bypass the verification if necessary. We have no issues in running our application on real tablet devices or simulator and the library correctly detects the iPad as tablet in my tests (including other iPad from the Xcode Simulator).

@nmiglio Could you please review the PR #7 and let me know if this change is satisfactory?