From fb2014afff289bd3325ffa669ecf8911261a8221 Mon Sep 17 00:00:00 2001 From: Nicolas Bonduel Date: Fri, 14 Feb 2020 15:38:03 +0100 Subject: [PATCH] Switch from /v2/users to /users endpoint on user creation --- src/collection/resources/users.js | 9 ++------- test/collection/user.js | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/src/collection/resources/users.js b/src/collection/resources/users.js index 47116a7..17a6ccb 100644 --- a/src/collection/resources/users.js +++ b/src/collection/resources/users.js @@ -1,6 +1,7 @@ const Components = require('./_resources'); const User = require('../objects/user'); const { + create, getFromId, get, set, @@ -10,7 +11,7 @@ const { class Users extends Components { constructor(request) { - super([getFromId, get, set, del, update]); + super([create, getFromId, get, set, del, update]); this.request = request; this.apiPath = 'users'; this.ResConstructor = User; @@ -19,12 +20,6 @@ class Users extends Components { // The `Create` and the `Authenticate` functions are functionnaly identical. // No need to `Authenticate` after `Create`. - create(body, { urlParams, json = false } = {}, done) { - return this.query({ - type: 'post', apiPath: 'v2/users', urlParams, body, json, - }, done); - } - authenticate(body, { urlParams, json = false } = {}, done) { return this.create(body, { urlParams, json }, done); } diff --git a/test/collection/user.js b/test/collection/user.js index a48b8d2..dec9054 100644 --- a/test/collection/user.js +++ b/test/collection/user.js @@ -32,6 +32,26 @@ describe('User related tests', () => { done(); }).catch(console.log); }); + it('Should create user', (done) => { + nock(endpoint) + .post('/users') + .reply(200, userFile); + sa.users.create({}).then((userRes) => { + assert.ok((userRes.first_name === userFile.first_name)); + assert.ok(userRes.constructor.name === 'User'); + done(); + }); + }); + it('Should authenticate user', (done) => { + nock(endpoint) + .post('/users') + .reply(200, userFile); + sa.users.authenticate({}).then((userRes) => { + assert.ok((userRes.first_name === userFile.first_name)); + assert.ok(userRes.constructor.name === 'User'); + done(); + }); + }); it('Should return me', (done) => { nock(endpoint) .get('/users/me')