Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Non-empty selection of empty dataset. #322

@1uc

Description

@1uc

I'm looking at:

if (selection.ranges().empty() || dset.getElementCount() == 0) {

The question is should a non-empty selection of an empty dataset return an empty vector, or should it throw, since we've not returned the requested element? One possible answer is that it's fine since they're all out-of-range and we ignore anything out of range in edge_index too. However, I think that prior to 70559bc out-of-bounds selections would have been an exception for this particular routine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions