Fix call to register_activation_hook()

[guix77]

Hi,

There is currently this error:

register_uninstall_hook was called incorrectly. Only a static class method or function can be used in an uninstall hook.

[jnaklaas]

@guix77 That is not a proper way to fix it. This way, the Install and Uninstall methods are not called at all from the hooks.

Since the register_install_hook accepts class methods, that does not need a fix. Only the register_uninstall_hook no longer accepts class methods, only static class methods or functions (the error says it all).

A working solution is to change the Uninstall method to a static method, and then pass it properly to the uninstall hook.

public static function Uninstall(){
    global $wpdb;
    $wpdb->query("DELETE FROM `" . $wpdb->prefix . "options` WHERE `option_name` LIKE '" . self::$prefix . "%'");
}

// ...

register_uninstall_hook($this->Path_Get('plugin_file_index'), array(MW_Polylang_Theme_Strings::class, 'Uninstall'));

[arisonadim]

In case if someone needs to install this plugin with composer and use with Bedrock Sage theme — here is working fork. I've just add this tiny fixes makes it work in recent WP 6.7.1

https://github.com/arisonadim/wp-polylang-theme-strings

add to composer.json in repositories section:

"repositories": [ { "type": "vcs", "url": "https://github.com/arisonadim/wp-polylang-theme-strings" }, ... ],

and in require section:
"benjaminmedia/wp-polylang-theme-strings": "dev-master",

Then composer update

[steveariss]

Many thanks @arisonadim !