From 23bf1930007771843505a1b29e2ab5fe8a36b0c0 Mon Sep 17 00:00:00 2001 From: doubiez <31129629+doubiez@users.noreply.github.com> Date: Fri, 18 Aug 2017 12:42:02 +0200 Subject: [PATCH] just... no Declare those damn variables at top ffs! This is nowhere near "clean code" as advertised! --- .../FileExplorer/PathList/FileExplorerFrame.java | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/example/ben/fileexplorer/FileExplorer/PathList/FileExplorerFrame.java b/app/src/main/java/com/example/ben/fileexplorer/FileExplorer/PathList/FileExplorerFrame.java index 416ae25..a476fe9 100644 --- a/app/src/main/java/com/example/ben/fileexplorer/FileExplorer/PathList/FileExplorerFrame.java +++ b/app/src/main/java/com/example/ben/fileexplorer/FileExplorer/PathList/FileExplorerFrame.java @@ -26,9 +26,11 @@ public class FileExplorerFrame extends Fragment { @Override public void onViewCreated(View view, Bundle savedInstanceState) { + DirectoryIterator iterator; + super.onViewCreated(view, savedInstanceState); lv = (ListView) view.findViewById(R.id.lvFiles); - DirectoryIterator iterator =new DirectoryIterator(); + iterator = new DirectoryIterator(); switch (getArguments().getString("filetype")) { case "Pictures": { @@ -42,18 +44,21 @@ public void onViewCreated(View view, Bundle savedInstanceState) { break; } } + initListView(); } private void initListView() { - //lv = (ListView) getActivity().findViewById(R.id.lvFiles); lv.setAdapter(new PathListViewAdapter(getActivity(), R.layout.file_list_row, values)); lv.setOnItemClickListener(new AdapterView.OnItemClickListener() { @Override public void onItemClick(AdapterView parent, View view, int position, long id) { if (new File(values.get(position).getPath()).isDirectory()) { - FileGridViewFragment fragment = new FileGridViewFragment(); - Bundle b = new Bundle(); + FileGridViewFragment fragment; + Bundle b; + + fragment = new FileGridViewFragment(); + b = new Bundle(); b.putString("dir", values.get(position).getPath()); b.putString("filetype",getArguments().getString("filetype")); fragment.setArguments(b);