From e58059a4063abdca81eeb7334604f8ce01cf105e Mon Sep 17 00:00:00 2001
From: undemian <undemian@gmail.com>
Date: Tue, 3 Apr 2018 17:31:18 +0300
Subject: [PATCH] Add global constants file

---
 package.json                     |  2 +-
 src/constants.js                 | 11 +++++++++++
 src/form.js                      |  5 +----
 src/lib/auth/index.js            |  2 +-
 src/lib/auth/strategies/index.js |  6 ------
 5 files changed, 14 insertions(+), 12 deletions(-)
 create mode 100644 src/constants.js

diff --git a/package.json b/package.json
index 81d28468..4e6b0624 100644
--- a/package.json
+++ b/package.json
@@ -31,7 +31,7 @@
     "dev:npm:css:main": "node-sass src/form.scss | postcss --config postcss.config.json -u autoprefixer -u postcss-custom-properties --no-map -o targets/npm/happychat.css",
     "dev:npm:css:woo": "node-sass src/ui/css/themes/_woo.scss | postcss --config postcss.config.json -u autoprefixer -u postcss-custom-properties --no-map -o targets/npm/woo.css",
     "dev:npm:css:jpop": "node-sass src/ui/css/themes/_jpop.scss | postcss --config postcss.config.json -u autoprefixer -u postcss-custom-properties --no-map -o targets/npm/jpop.css",
-    "dev:npm:serve-css": "NODE_ENV=development webpack-dev-server --config webpack.npm.config.js",
+    "dev:npm:css:serve": "NODE_ENV=development webpack-dev-server --config webpack.npm.config.js",
 
     "dev:wordpress": "run-p dev:wordpress:*",
     "dev:wordpress:js": "NODE_ENV=development webpack-dev-server --config webpack.wordpress.config.js",
diff --git a/src/constants.js b/src/constants.js
new file mode 100644
index 00000000..f91638ff
--- /dev/null
+++ b/src/constants.js
@@ -0,0 +1,11 @@
+// Auth strategies
+export const AUTH_TYPE_WPCOM_OAUTH_BY_TOKEN = 'wpcom-oauth-by-token';
+export const AUTH_TYPE_WPCOM_PROXY_IFRAME = 'wpcom-proxy-iframe';
+
+// Layouts
+export const LAYOUT_FULLSCREEN = 'fullscreen';
+export const LAYOUT_PANEL = 'panel';
+
+// Entry
+export const ENTRY_CHAT = 'chat';
+export const ENTRY_FORM = 'form';
diff --git a/src/form.js b/src/form.js
index ba2bdcbb..72b97808 100644
--- a/src/form.js
+++ b/src/form.js
@@ -12,6 +12,7 @@ import { connect } from 'react-redux';
  */
 import config from 'src/config';
 import authenticator from 'src/lib/auth';
+import { ENTRY_FORM } from 'src/constants';
 
 // actions
 import {
@@ -62,9 +63,6 @@ import CompactCard from 'src/ui/components/card/compact';
 import FormLabel from 'src/ui/components/form-label';
 import SpinnerLine from 'src/ui/components/spinner-line';
 
-const ENTRY_FORM = 'form';
-const ENTRY_CHAT = 'chat';
-
 class ChatComponent {
 	constructor( props ) {
 		this.props = props;
@@ -422,4 +420,3 @@ const mapDispatch = {
 };
 
 export default connect( mapState, mapDispatch )( mockLocalize( Form ) );
-export { ENTRY_FORM, ENTRY_CHAT };
diff --git a/src/lib/auth/index.js b/src/lib/auth/index.js
index 68e429d6..ec4545f7 100644
--- a/src/lib/auth/index.js
+++ b/src/lib/auth/index.js
@@ -11,7 +11,7 @@ import debugFactory from 'debug';
 import {
 	AUTH_TYPE_WPCOM_OAUTH_BY_TOKEN,
 	AUTH_TYPE_WPCOM_PROXY_IFRAME,
-} from './strategies';
+} from 'src/constants';
 import WPcomOAuth from './strategies/wpcom/oauth';
 import WPcomProxyIframe from './strategies/wpcom/proxy-iframe';
 
diff --git a/src/lib/auth/strategies/index.js b/src/lib/auth/strategies/index.js
index c450464d..ce902078 100644
--- a/src/lib/auth/strategies/index.js
+++ b/src/lib/auth/strategies/index.js
@@ -1,11 +1,5 @@
 /** @format */
 
-/**
- * Constants representing allowed and implemented authentication strategies
- */
-export const AUTH_TYPE_WPCOM_OAUTH_BY_TOKEN = 'wpcom-oauth-by-token';
-export const AUTH_TYPE_WPCOM_PROXY_IFRAME = 'wpcom-proxy-iframe';
-
  /**
   * "Abstract" class representing a base strategy, it should be extended by implemented strategies
   * as a fail safe that all exposed methods are implemented.