diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..7f442bd --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,59 @@ +# Pull request title + +| Status | Type | Env Vars Change | +| :--------: | :---------------------------------: | :-------------: | +| Ready/Hold | Feature/Bug/Tooling/Refactor/Hotfix | Yes/No | + +> ⚠️ NOTE: + +## Problem + + + +- problem 1 +- problem 2 + .... + +## Solution + + + +- solution 1 +- solution 2 + .... + +## Test results + + + +## Other changes + +- change 1 +- change 2 + .... + +## Deploy Notes + + + + +**New environment variables**: + +- `env var` : env var details + + +**New scripts**: + +- `script` : script (DB migrations, etc) details + + +**New dependencies**: + +- `dependency` : dependency details + + +**New dev dependencies**: + +- `dependency` : dependency details diff --git a/.github/instructions/PullRequest.instructions.md b/.github/instructions/PullRequest.instructions.md new file mode 100644 index 0000000..5bb5961 --- /dev/null +++ b/.github/instructions/PullRequest.instructions.md @@ -0,0 +1,73 @@ +--- +applyTo: '**' +--- + +Always ask for PR target branch(upstream), and the allowed targets branches are "development" and "main" branch +Always ask for the commits to be added to the PR in comma separated format and display the most reset commits using the following format: +`: ` +Analyze the selected commits by id when generating the PR description +PR title must be a summary of all the selected commit messages with emoji +PR description must be generated as MD code snippet +Always Use the following template when generating PR(Pull Request) description + +```md +# + +| Status | Type | Env Vars Change | +| :--------: | :---------------------------------: | :-------------: | +| Ready/Hold | Feature/Bug/Tooling/Refactor/Hotfix | Yes/No | + +> ⚠️ NOTE: + +## Problem + + + +- problem 1 +- problem 2 + .... + +## Solution + + + +- solution 1 +- solution 2 + .... + +## Test results + + + +## Other changes + +- change 1 +- change 2 + .... + +## Deploy Notes + + + + +**New environment variables **: + +- `env var` : env var details + + +**New scripts**: + +- `script` : script (DB migrations, etc) details + + +**New dependencies**: + +- `dependency` : dependency details + + +**New dev dependencies**: + +- `dependency` : dependency details +``` diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index 0c201e5..87f5301 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -1,5 +1,8 @@ name: Verify +env: + NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }} + on: push: branches: @@ -18,9 +21,6 @@ jobs: fetch-depth: 0 - uses: pnpm/action-setup@v4 - with: - version: 9 - # Cache node_modules - uses: actions/setup-node@v4 with: @@ -34,3 +34,5 @@ jobs: # - run: pnpm exec nx-cloud record -- echo Hello World # Nx Affected runs only tasks affected by the changes in this PR/commit. Learn more: https://nx.dev/ci/features/affected - run: pnpx nx affected -t build && pnpm build + - run: npx nx fix-ci + if: always() diff --git a/.vscode/extensions.json b/.vscode/extensions.json index b0b0368..511438b 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -15,8 +15,6 @@ "nrwl.angular-console", "stringham.move-ts", "pmneo.tsimporter", - "wallabyjs.quokka-vscode", - "wallabyjs.console-ninja", "antfu.vite", "mhutchie.git-graph", "shardulm94.trailing-spaces", @@ -37,4 +35,4 @@ "github.vscode-github-actions", "ms-playwright.playwright" ] -} \ No newline at end of file +} diff --git a/nx.json b/nx.json index d45d4f7..e40ddde 100644 --- a/nx.json +++ b/nx.json @@ -5,6 +5,17 @@ "build": { "dependsOn": [ "^build", + "minify", + "lint" + ], + "outputs": [ + "{projectRoot}/dist" + ], + "cache": true + }, + "minify": { + "dependsOn": [ + "^minify", "lint" ], "outputs": [ @@ -29,5 +40,5 @@ "sharedGlobals" ] }, - "nxCloudId": "681f1bf43845db51336764b6" + "nxCloudId": "66b806726340ec37c5b8ec1b" } \ No newline at end of file