From 0d59ccd41b0e163a8aeccf0e1b68957e5af0a4d0 Mon Sep 17 00:00:00 2001
From: Daniel Woodhead <daniel.woodhead@emishealth.com>
Date: Thu, 12 Jun 2025 10:39:18 +0100
Subject: [PATCH] fix: junit testcase failure message

---
 src/cli/send/junitUtils.spec.ts | 8 +++++---
 src/cli/send/junitUtils.ts      | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/cli/send/junitUtils.spec.ts b/src/cli/send/junitUtils.spec.ts
index 5a95bc81..c29629b1 100644
--- a/src/cli/send/junitUtils.spec.ts
+++ b/src/cli/send/junitUtils.spec.ts
@@ -231,7 +231,8 @@ describe('transformToJunit', () => {
               status: TestResultStatus.FAILED,
               message: 'Assertions fail',
               error: {
-                displayMessage: 'failed result',
+                displayMessage: 'failed result display',
+                message: 'failed result',
                 error: { message: 'test', name: 'unknown', stack: '' } as unknown as Error,
               },
             },
@@ -265,9 +266,10 @@ describe('transformToJunit', () => {
     </properties>
     <testcase name="Assertions fail" classname="test" time="0.000" assertions="1">
       <properties>
-        <property name="displayMessage" value="failed result"/>
+        <property name="displayMessage" value="failed result display"/>
+        <property name="message" value="failed result"/>
       </properties>
-      <failure message="Assertions fail" type="unknown">{"message":"test","name":"unknown","stack":""}</failure>
+      <failure message="failed result" type="unknown">{"message":"test","name":"unknown","stack":""}</failure>
     </testcase>
     <testcase name="status === 200" classname="test" time="0.000" assertions="1"/>
   </testsuite>
diff --git a/src/cli/send/junitUtils.ts b/src/cli/send/junitUtils.ts
index a789d727..ea7dedb0 100644
--- a/src/cli/send/junitUtils.ts
+++ b/src/cli/send/junitUtils.ts
@@ -103,7 +103,7 @@ function transformTestResultToTestcase(
   if ([TestResultStatus.ERROR, TestResultStatus.FAILED].includes(testResult.status)) {
     const failureNode = document.createElement('failure');
     root.appendChild(failureNode);
-    setAttribute(failureNode, 'message', testResult.message);
+    setAttribute(failureNode, 'message', testResult.error?.message ?? testResult.message);
     setAttribute(failureNode, 'type', testResult.error?.errorType ?? 'unknown');
     failureNode.textContent = utils.errorToString(testResult.error?.error) || '';
   } else if (testResult.status === TestResultStatus.SKIPPED) {