error updating project on berkeley instance

[tansaku]

I was just looking to see if any berkeley projects had been added and there was just one element with a missing key - I tried to add the key 'url' but got this error:

2016-10-12T13:50:01.288296+00:00 app[web.1]:   Rendered projects/_form.html.haml (25.9ms)
2016-10-12T13:50:01.288494+00:00 app[web.1]:   Rendered projects/edit.html.haml within layouts/application (26.4ms)
2016-10-12T13:50:01.289306+00:00 app[web.1]: Completed 200 OK in 37ms (Views: 13.2ms | ActiveRecord: 18.6ms)
2016-10-12T13:50:34.046148+00:00 app[web.1]: Started PATCH "/projects/3" for 86.145.234.60 at 2016-10-12 13:50:34 +0000
2016-10-12T13:50:34.053293+00:00 app[web.1]: Processing by ProjectsController#update as HTML
2016-10-12T13:50:34.053442+00:00 app[web.1]:   Parameters: {"utf8"=>"✓", "authenticity_token"=>"RMlb/xUnW6vt5tWL3lP8/BJhYKGJFe/PAw+JM1VkvyOzLLWAWQ6S2Se7WVWeM7tm6UBa9Dxg4BV1P1DWWz3d0A==", "project"=>{"name"=>"IPSR Mosaic", "configs_attributes"=>{"0"=>{"metric_name"=>"code_climate", "new"=>["", ""], "id"=>"11"}, "1"=>{"metric_name"=>"github", "options"=>["https://github.com/Pojostick/ipsr-mosaic"], "new"=>["url", "https://github.com/Pojostick/ipsr-mosaic"], "id"=>"12"}, "2"=>{"metric_name"=>"slack", "new"=>["", ""], "id"=>"13"}, "3"=>{"metric_name"=>"pivotal_tracker", "new"=>["", ""], "id"=>"14"}, "4"=>{"metric_name"=>"slack_trends", "new"=>["", ""], "id"=>"15"}}}, "commit"=>"Update Project", "id"=>"3"}
2016-10-12T13:50:34.136320+00:00 app[web.1]:   Project Load (7.1ms)  SELECT  "projects".* FROM "projects" WHERE "projects"."id" = $1 LIMIT 1  [["id", 3]]
2016-10-12T13:50:34.140387+00:00 app[web.1]:   Config Load (2.1ms)  SELECT "configs".* FROM "configs" WHERE "configs"."project_id" IN (3)
2016-10-12T13:50:34.223553+00:00 app[web.1]: Completed 500 Internal Server Error in 170ms (ActiveRecord: 9.2ms)
2016-10-12T13:50:34.224612+00:00 app[web.1]: 
2016-10-12T13:50:34.224615+00:00 app[web.1]: NoMethodError (undefined method `merge!' for ["https://github.com/Pojostick/ipsr-mosaic"]:Array):
2016-10-12T13:50:34.224615+00:00 app[web.1]:   app/controllers/projects_controller.rb:86:in `block in project_params'
2016-10-12T13:50:34.224617+00:00 app[web.1]:   app/controllers/projects_controller.rb:83:in `project_params'
2016-10-12T13:50:34.224617+00:00 app[web.1]:   app/controllers/projects_controller.rb:47:in `update'
2016-10-12T13:50:34.224618+00:00 app[web.1]: 
2016-10-12T13:50:34.224618+00:00 app[web.1]: 

[tansaku]

I went into the db and manually fixed it like this:

irb(main):006:0> p = Project.last
  Project Load (10.6ms)  SELECT  "projects".* FROM "projects"  ORDER BY "projects"."id" DESC LIMIT 1
  Project Load (10.6ms)  SELECT  "projects".* FROM "projects"  ORDER BY "projects"."id" DESC LIMIT 1
=> #<Project id: 3, name: "IPSR Mosaic", created_at: "2016-10-11 21:17:42", updated_at: "2016-10-11 21:17:42">
irb(main):007:0> p.config_for('github')
  Config Load (3.6ms)  SELECT  "configs".* FROM "configs" WHERE "configs"."project_id" = $1 AND "configs"."metric_name" = $2  ORDER BY "configs"."id" ASC LIMIT 1  [["project_id", 3], ["metric_name", "github"]]
  Config Load (3.6ms)  SELECT  "configs".* FROM "configs" WHERE "configs"."project_id" = $1 AND "configs"."metric_name" = $2  ORDER BY "configs"."id" ASC LIMIT 1  [["project_id", 3], ["metric_name", "github"]]
=> #<Config id: 12, project_id: 3, metric_name: "github", encrypted_options: "ixjz8yd5ZwgmAneNugzhCGOOQKqOdwxHsDQDdtRc9dcmKvu7w3...", created_at: "2016-10-11 21:17:42", updated_at: "2016-10-11 21:17:49", encrypted_options_iv: "W/N7cdIVEnjmWPYI\n">
irb(main):008:0> c = _
=> #<Config id: 12, project_id: 3, metric_name: "github", encrypted_options: "ixjz8yd5ZwgmAneNugzhCGOOQKqOdwxHsDQDdtRc9dcmKvu7w3...", created_at: "2016-10-11 21:17:42", updated_at: "2016-10-11 21:17:49", encrypted_options_iv: "W/N7cdIVEnjmWPYI\n">
irb(main):009:0> c.options
=> {""=>"https://github.com/Pojostick/ipsr-mosaic"}
irb(main):010:0> c.options = {'url'=>"https://github.com/Pojostick/ipsr-mosaic"}
=> {"url"=>"https://github.com/Pojostick/ipsr-mosaic"}
irb(main):011:0> c.save
   (1.4ms)  BEGIN
   (1.4ms)  BEGIN
  Config Exists (1.5ms)  SELECT  1 AS one FROM "configs" WHERE ("configs"."metric_name" = 'github' AND "configs"."id" != 12 AND "configs"."project_id" = 3) LIMIT 1
  Config Exists (1.5ms)  SELECT  1 AS one FROM "configs" WHERE ("configs"."metric_name" = 'github' AND "configs"."id" != 12 AND "configs"."project_id" = 3) LIMIT 1
  SQL (1.2ms)  UPDATE "configs" SET "encrypted_options_iv" = $1, "encrypted_options" = $2, "updated_at" = $3 WHERE "configs"."id" = $4  [["encrypted_options_iv", "Trgc8XL1j2jHMHgv\n"], ["encrypted_options", "xQ0Oh9RNOV6dAwG+hj/yJyWxrDMZJODF7yN0EkzK6SSwSlSvwmParUCzzoSC\nhsEwSWdZuL/kf45nanY1UqSjl6zbSyFngbaFxY6hALfE\n"], ["updated_at", "2016-10-12 13:55:41.463298"], ["id", 12]]
  SQL (1.2ms)  UPDATE "configs" SET "encrypted_options_iv" = $1, "encrypted_options" = $2, "updated_at" = $3 WHERE "configs"."id" = $4  [["encrypted_options_iv", "Trgc8XL1j2jHMHgv\n"], ["encrypted_options", "xQ0Oh9RNOV6dAwG+hj/yJyWxrDMZJODF7yN0EkzK6SSwSlSvwmParUCzzoSC\nhsEwSWdZuL/kf45nanY1UqSjl6zbSyFngbaFxY6hALfE\n"], ["updated_at", "2016-10-12 13:55:41.463298"], ["id", 12]]
   (2.1ms)  COMMIT
   (2.1ms)  COMMIT
=> true

I'm not sure what the underlying issue was - seems like we need docs for helping people set up

[armandofox]

let's touch base about this at friday morning telecon, which i should be able to make. we are starting to populate w/berkeley projects.

things like simple bug fixes (eg github metric gem crashes if project has no PRs) can be high-pri bugs for first iteration for our student team.

feature-wise, they will be adding "Login with your github id" and ability to select which projects appear on your own dashboard, which metrics you are interested in for those projects, and the ability to arrange/sort the project display