From 7eb6881c1bd2a0d41286bf9b76ab858cc9d15511 Mon Sep 17 00:00:00 2001 From: Eric Da Silva Date: Wed, 3 Dec 2025 09:14:00 +0100 Subject: [PATCH 1/2] add the Consent field as specified in OpenRTB 2.6 --- openrtb.go | 1 + 1 file changed, 1 insertion(+) diff --git a/openrtb.go b/openrtb.go index 8601c25..753e036 100644 --- a/openrtb.go +++ b/openrtb.go @@ -807,6 +807,7 @@ type User struct { CustomData string `json:"customdata,omitempty"` // Optional feature to pass bidder data that was set in the exchange's cookie. The string must be in base85 cookie safe characters and be in any format. Proper JSON encoding must be used to include "escaped" quotation marks. Geo *Geo `json:"geo,omitempty"` Data []Data `json:"data,omitempty"` + Consent string `json:"consent,omitempty"` // When GDPR regulations are in effect this attribute contains the Transparency and Consent Framework's Consent String data structure. Ext json.RawMessage `json:"ext,omitempty"` } From 01fec5332b6eba05a974d489f5f426ebfd43feed Mon Sep 17 00:00:00 2001 From: Eric Da Silva Date: Wed, 3 Dec 2025 09:18:27 +0100 Subject: [PATCH 2/2] update workflow --- .github/workflows/test.yml | 9 ++++----- audio_test.go | 2 +- bid_test.go | 4 ++-- bidrequest_test.go | 6 +++--- bidresponse_test.go | 4 ++-- impression_test.go | 4 ++-- seatbid_test.go | 2 +- video_test.go | 6 +++--- 8 files changed, 18 insertions(+), 19 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 18ff30b..4d7963a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,10 +8,10 @@ on: - main jobs: go: - runs-on: ubuntu-latest + runs-on: gha-rtg-adikteev-runners-large-amd64 strategy: matrix: - go-version: [1.18.x, 1.19.x] + go-version: [1.18.x, 1.19.x, 1.25.x] steps: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 @@ -25,8 +25,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 with: - go-version: 1.x - cache: true - - uses: golangci/golangci-lint-action@v3 + go-version: 1.19.x + - uses: golangci/golangci-lint-action@v6 with: version: latest diff --git a/audio_test.go b/audio_test.go index 1c7c9a8..5c5ee8b 100644 --- a/audio_test.go +++ b/audio_test.go @@ -56,7 +56,7 @@ func TestAudio_Validate(t *testing.T) { }, CompanionTypes: []CompanionType{CompanionTypeStatic, CompanionTypeHTML}, } - if exp, got := ErrInvalidAudioNoMIMEs, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidAudioNoMIMEs, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } } diff --git a/bid_test.go b/bid_test.go index 9b1d0f9..a613065 100644 --- a/bid_test.go +++ b/bid_test.go @@ -35,11 +35,11 @@ func TestBid(t *testing.T) { func TestBid_Validate(t *testing.T) { subject := &Bid{} - if exp, got := ErrInvalidBidNoID, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidBidNoID, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } subject = &Bid{ID: "BIDID"} - if exp, got := ErrInvalidBidNoImpID, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidBidNoImpID, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } } diff --git a/bidrequest_test.go b/bidrequest_test.go index 33ff7a4..ed935b8 100644 --- a/bidrequest_test.go +++ b/bidrequest_test.go @@ -74,15 +74,15 @@ func TestBidRequest_complex(t *testing.T) { func TestBidRequest_Validate(t *testing.T) { subject := &BidRequest{} - if exp, got := ErrInvalidReqNoID, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidReqNoID, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } subject = &BidRequest{ID: "RID"} - if exp, got := ErrInvalidReqNoImps, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidReqNoImps, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } subject = &BidRequest{ID: "A", Impressions: []Impression{{ID: "1"}}, Site: &Site{}, App: &App{}} - if exp, got := ErrInvalidReqMultiInv, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidReqMultiInv, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } } diff --git a/bidresponse_test.go b/bidresponse_test.go index 39fb075..e64459e 100644 --- a/bidresponse_test.go +++ b/bidresponse_test.go @@ -56,11 +56,11 @@ func TestBidResponse_complex(t *testing.T) { func TestBidResponse_Validate(t *testing.T) { subject := &BidResponse{} - if exp, got := ErrInvalidRespNoID, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidRespNoID, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } subject = &BidResponse{ID: "RID"} - if exp, got := ErrInvalidRespNoSeatBids, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidRespNoSeatBids, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } } diff --git a/impression_test.go b/impression_test.go index 95046a3..8309bcb 100644 --- a/impression_test.go +++ b/impression_test.go @@ -42,11 +42,11 @@ func TestImpression(t *testing.T) { func TestImpression_Validate(t *testing.T) { subject := &Impression{} - if exp, got := ErrInvalidImpNoID, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidImpNoID, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } subject = &Impression{ID: "IMPID", Banner: &Banner{}, Video: &Video{}} - if exp, got := ErrInvalidImpMultiAssets, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidImpMultiAssets, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } } diff --git a/seatbid_test.go b/seatbid_test.go index 9f73349..4addad3 100644 --- a/seatbid_test.go +++ b/seatbid_test.go @@ -9,7 +9,7 @@ import ( func TestSeatBid_Validate(t *testing.T) { subject := &SeatBid{} - if exp, got := ErrInvalidSeatBidBid, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidSeatBidBid, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } } diff --git a/video_test.go b/video_test.go index 4b9cbda..714eb2d 100644 --- a/video_test.go +++ b/video_test.go @@ -52,11 +52,11 @@ func TestVideo(t *testing.T) { func TestVideo_Validate(t *testing.T) { subject := &Video{} - if exp, got := ErrInvalidVideoNoMIMEs, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidVideoNoMIMEs, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } subject = &Video{MIMEs: []string{"video/mp4"}} - if exp, got := ErrInvalidVideoNoLinearity, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidVideoNoLinearity, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } subject = &Video{ @@ -65,7 +65,7 @@ func TestVideo_Validate(t *testing.T) { Linearity: VideoLinearityNonLinear, MIMEs: []string{"video/mp4"}, } - if exp, got := ErrInvalidVideoNoProtocols, subject.Validate(); !errors.Is(exp, got) { + if exp, got := ErrInvalidVideoNoProtocols, subject.Validate(); !errors.Is(got, exp) { t.Fatalf("expected %v, got %v", exp, got) } }