From 0ace1278679b01b5cab7449e2247274265bb8eaf Mon Sep 17 00:00:00 2001
From: the-snork <none>
Date: Sat, 4 Nov 2023 20:49:19 +0100
Subject: [PATCH 1/2] sdcc + clean make file

---
 Makefile    | 54 +++++++++++++++++++++++++----------------------------
 src/flash.c |  6 +++---
 src/flash.h |  4 ++--
 src/hal.c   | 14 +++++++-------
 src/hal.h   | 14 +++++++-------
 src/main.c  | 18 +++++++++---------
 src/usb.c   | 34 ++++++++++++++++-----------------
 src/usb.h   | 12 ++++++------
 8 files changed, 76 insertions(+), 80 deletions(-)

diff --git a/Makefile b/Makefile
index b68b8e2..3187943 100644
--- a/Makefile
+++ b/Makefile
@@ -20,6 +20,10 @@ ifdef DEBUG
 CFLAGS += --debug
 endif
 
+CHRONOS_FLAGS = -DRFCAT_CHRONOS
+DONS_FLAGS = -DRFCAT_DONSDONGLE
+YS1_FLAGS = -DRFCAT_YARDSTICKONE
+
 SRC = \
 	src/main.c \
 	src/usb.c \
@@ -30,13 +34,9 @@ SRC = \
 
 ASM_SRC = src/start.asm
 
-ADB = $(SRC:.c=.c.adb)
-ASM = $(SRC:.c=.c.asm)
-LNK = $(SRC:.c=.c.lnk)
-LST = $(SRC:.c=.c.lst)
-REL = $(SRC:.c=.c.rel)
-RST = $(SRC:.c=.c.rst)
-SYM = $(SRC:.c=.c.sym)
+CHRONOS_REL = $(SRC:.c=.c.chronos.rel)
+DONS_REL = $(SRC:.c=.c.dons.rel)
+YS1_REL = $(SRC:.c=.c.ys1.rel)
 
 ASM_ADB = $(ASM_SRC:.asm=.adb)
 ASM_LNK = $(ASM_SRC:.asm=.lnk)
@@ -45,45 +45,41 @@ ASM_REL = $(ASM_SRC:.asm=.rel)
 ASM_RST = $(ASM_SRC:.asm=.rst)
 ASM_SYM = $(ASM_SRC:.asm=.sym)
 
-PROGS = CCBootloader.hex CCBootloader-rfcat-chronosdongle.hex CCBootloader-rfcat-donsdongle.hex CCBootloader-rfcat-ys1.hex
+PROGS = CCBootloader-rfcat-chronosdongle.hex CCBootloader-rfcat-donsdongle.hex CCBootloader-rfcat-ys1.hex
 PCDB = $(PROGS:.hex=.cdb)
 PLNK = $(PROGS:.hex=.lnk)
+PLK = $(PROGS:.hex=.lk)
 PMAP = $(PROGS:.hex=.map)
 PMEM = $(PROGS:.hex=.mem)
 PAOM = $(PROGS:.hex=)
 
-%.c.rel : %.c
-	$(CC) -c $(CFLAGS) -o$*.c.rel $<
+%.c.chronos.rel : %.c
+	$(CC) -c $(CFLAGS) $(CHRONOS_FLAGS) -o$*.c.chronos.rel $<
+
+%.c.dons.rel : %.c
+	$(CC) -c $(CFLAGS) $(DONS_FLAGS) -o$*.c.dons.rel $<
+
+%.c.ys1.rel : %.c
+	$(CC) -c $(CFLAGS) $(YS1_FLAGS) -o$*.c.ys1.rel $<
 
 %.rel : %.asm
 	$(AS) -c $(ASFLAGS) $<
 
 all: $(PROGS)
 
-CCBootloader.hex: $(REL) $(ASM_REL) Makefile
-	$(CC) $(LDFLAGS_FLASH) $(CFLAGS) -o CCBootloader.hex $(ASM_REL) $(REL)
+CCBootloader-rfcat-chronosdongle.hex: $(CHRONOS_REL) $(ASM_REL)
+	$(CC) $(LDFLAGS_FLASH) $(CFLAGS) $(CHRONOS_FLAGS) -o CCBootloader-rfcat-chronosdongle.hex $(ASM_REL) $(CHRONOS_REL)
 
-CCBootloader-rfcat-chronosdongle.hex: CFLAGS += -DRFCAT -DRFCAT_CHRONOS
-CCBootloader-rfcat-chronosdongle.hex: $(REL) $(ASM_REL) Makefile
-	$(CC) $(LDFLAGS_FLASH) $(CFLAGS) -o CCBootloader-rfcat-chronosdongle.hex $(ASM_REL) $(REL)
+CCBootloader-rfcat-donsdongle.hex: $(DONS_REL) $(ASM_REL)
+	$(CC) $(LDFLAGS_FLASH) $(CFLAGS) $(DONS_FLAGS) -o CCBootloader-rfcat-donsdongle.hex $(ASM_REL) $(DONS_REL)
 
-CCBootloader-rfcat-donsdongle.hex: CFLAGS += -DRFCAT -DRFCAT_DONSDONGLE
-CCBootloader-rfcat-donsdongle.hex: $(REL) $(ASM_REL) Makefile
-	$(CC) $(LDFLAGS_FLASH) $(CFLAGS) -o CCBootloader-rfcat-donsdongle.hex $(ASM_REL) $(REL)
-
-CCBootloader-rfcat-ys1.hex: CFLAGS += -DRFCAT -DRFCAT_YARDSTICKONE
-CCBootloader-rfcat-ys1.hex: $(REL) $(ASM_REL) Makefile
-	$(CC) $(LDFLAGS_FLASH) $(CFLAGS) -o CCBootloader-rfcat-ys1.hex $(ASM_REL) $(REL)
+CCBootloader-rfcat-ys1.hex: $(YS1_REL) $(ASM_REL)
+	$(CC) $(LDFLAGS_FLASH) $(CFLAGS) $(YS1_FLAGS) -o CCBootloader-rfcat-ys1.hex $(ASM_REL) $(YS1_REL)
 
 clean:
-	rm -f $(ADB) $(ASM) $(LNK) $(LST) $(REL) $(RST) $(SYM)
+	rm -f src/*.c.*
 	rm -f $(ASM_ADB) $(ASM_LNK) $(ASM_LST) $(ASM_REL) $(ASM_RST) $(ASM_SYM)
-	rm -f $(PROGS) $(PCDB) $(PLNK) $(PMAP) $(PMEM) $(PAOM)
-
-install: CCBootloader.hex
-	goodfet.cc erase
-	goodfet.cc flash CCBootloader.hex
-	goodfet.cc verify CCBootloader.hex
+	rm -f $(PROGS) $(PCDB) $(PLNK) $(PLK) $(PMAP) $(PMEM) $(PAOM)
 
 installchronosdongle: CCBootloader-rfcat-chronosdongle.hex
 	goodfet.cc erase
diff --git a/src/flash.c b/src/flash.c
index 9277494..16759cd 100644
--- a/src/flash.c
+++ b/src/flash.c
@@ -54,7 +54,7 @@ void flash_erase_page(uint8_t page) {
   //FCTL &=  ~FCTL_ERASE;
 }
 
-void flash_write_trigger() {
+void flash_write_trigger(void) {
   // Enable flash write. Generates a DMA trigger. Must be aligned on a 2-byte
   // boundary and is therefore implemented in assembly.
   
@@ -161,11 +161,11 @@ void flash_check_erase_and_write(uint16_t buff[], uint16_t len, uint16_t flash_a
   flash_write(buff, len, flash_addr);
 }
 
-void flash_reset() {
+void flash_reset(void) {
   erased_page_flags = 0;
 }
 
-void flash_erase_all_user() {
+void flash_erase_all_user(void) {
   // Erase all user flash pages
   uint8_t i;
   for (i=USER_FIRST_PAGE; i<FLASH_PAGES; i++)
diff --git a/src/flash.h b/src/flash.h
index 723d633..6ab95b5 100644
--- a/src/flash.h
+++ b/src/flash.h
@@ -38,8 +38,8 @@ void flash_check_and_erase(uint8_t page);
 // Write to flash, erasing pages as needed that have never yet been erased
 void flash_check_erase_and_write(uint16_t buff[], uint16_t len, uint16_t flash_addr);
 // Reset record of which pages have been erased
-void flash_reset();
+void flash_reset(void);
 // Erase all user flash pages
-void flash_erase_all_user();
+void flash_erase_all_user(void);
 
 #endif // _FLASH_H_
\ No newline at end of file
diff --git a/src/hal.c b/src/hal.c
index 5b2724f..65d568d 100644
--- a/src/hal.c
+++ b/src/hal.c
@@ -20,13 +20,13 @@
 #include "cc1111.h"
 #include "hal.h"
 
-void setup_led() {
+void setup_led(void) {
   // Setup LED and turn it off
   P1DIR |= LED_MASK;
   led_off();
 }
 
-void setup_button() {
+void setup_button(void) {
 #ifdef RFCAT_DONSDONGLE
   P1DIR &= ~4;
 #endif
@@ -39,7 +39,7 @@ void setup_button() {
 }
 
 // any other gpio pins
-void setup_gpio() {
+void setup_gpio(void) {
 #ifdef RFCAT_YARDSTICKONE
   // amplifer configuration pins
   //P0_0 input with pull-up (antenna port power off)
@@ -53,7 +53,7 @@ void setup_gpio() {
 #endif
 }
 
-void led_on() {
+void led_on(void) {
 #ifdef RFCAT_YARDSTICKONE
   LED1 = 1;
   LED2 = 1;
@@ -63,7 +63,7 @@ void led_on() {
 #endif
 }
 
-void led_off() {
+void led_off(void) {
 #ifdef RFCAT_YARDSTICKONE
   LED1 = 0;
   LED2 = 0;
@@ -73,13 +73,13 @@ void led_off() {
 #endif
 }
 
-void usb_up() {
+void usb_up(void) {
   // Bring up the USB link
   P1DIR |= USB_MASK;
   USB_ENABLE = 1;
 }
 
-void usb_down() {
+void usb_down(void) {
   // Bring down the USB link
   USB_ENABLE = 0;
   P1DIR &= ~USB_MASK;
diff --git a/src/hal.h b/src/hal.h
index 560b471..131d09a 100644
--- a/src/hal.h
+++ b/src/hal.h
@@ -49,14 +49,14 @@
   #define AMP_BYPASS_EN		P2_3
 #endif
 
-void setup_led();
-void led_on();
-void led_off();
-void setup_button();
-void setup_gpio();
+void setup_led(void);
+void led_on(void);
+void led_off(void);
+void setup_button(void);
+void setup_gpio(void);
 
-void usb_up();
-void usb_down();
+void usb_up(void);
+void usb_down(void);
 
 #define BUTTON_PRESSED  	0
 #define GROUNDED		0
diff --git a/src/main.c b/src/main.c
index f864d60..32acc96 100644
--- a/src/main.c
+++ b/src/main.c
@@ -26,7 +26,7 @@
 
 uint8_t bootloader_running = 1;
 
-void clock_init()
+void clock_init(void)
 {
 	// Switch system clock to crystal oscilator
 	CLKCON = (CLKCON & ~CLKCON_OSC_MASK) | (CLKCON_OSC_XTAL);
@@ -59,14 +59,14 @@ void delay (unsigned char n) {
 			  nop();
 }
 
-uint8_t check_for_payload() {
+uint8_t check_for_payload(void) {
   if (*((__xdata uint8_t*)USER_CODE_BASE) == 0xFF)
     return 0;
   else
     return 1;
 }
 
-void jump_to_user() {
+void jump_to_user(void) {
   // Disable all interrupts
   EA = 0;
   IEN0 = IEN1 = IEN2 = 0;
@@ -95,7 +95,7 @@ void jump_to_user() {
 }
 
 #ifdef TIMER
-void setup_timer1() {
+void setup_timer1(void) {
   // Clear Timer 1 channel 1 and overflow interrupt flag
   // CPU interrupt flag (IRCON) for Timer 1 is cleared automatically by hardware.
   T1CTL &= ~T1CTL_OVFIF;
@@ -112,14 +112,14 @@ void setup_timer1() {
 #endif
 
 #ifdef TIMER
-void disable_timer1() {
+void disable_timer1(oid) {
   // Disable Timer 1 interrupt
   IEN1 &= ~IEN1_T1IE;
 }
 #endif
 
 #ifdef TIMER
-void timer1_isr() __naked {
+void timer1_isr(void) __naked {
   T1CTL &= ~T1CTL_OVFIF;
   
   // We need to issue a RETI instruction to
@@ -145,7 +145,7 @@ void timer1_isr() __naked {
 }
 #endif
 
-void timer1_isr_forward() __naked {
+void timer1_isr_forward(void) __naked {
   #ifdef TIMER
   __asm
   	push acc
@@ -165,7 +165,7 @@ void timer1_isr_forward() __naked {
   #endif
 }
 
-uint8_t want_bootloader() {
+uint8_t want_bootloader(void) {
   // Check if we want to the bootloader to run
   // Here is the place to check for things like USB power and jump straight to
   // user code under some conditions.
@@ -190,7 +190,7 @@ uint8_t want_bootloader() {
   #endif
 }
 
-void bootloader_main ()
+void bootloader_main (void)
 {
   __xdata char buff[100];
   uint8_t ihx_status;
diff --git a/src/usb.c b/src/usb.c
index 169491d..e181669 100644
--- a/src/usb.c
+++ b/src/usb.c
@@ -27,7 +27,7 @@ static __xdata uint16_t usb_out_bytes;
 volatile static __xdata uint8_t  usb_iif;
 static __xdata uint8_t  usb_running;
 
-static void usb_set_interrupts()
+static void usb_set_interrupts(void)
 {
   // IN interrupts on the control an IN endpoints
   USBIIE = (1 << USB_CONTROL_EP) | (1 << USB_IN_EP);
@@ -46,7 +46,7 @@ struct usb_setup {
 } __xdata usb_setup;
 
 __xdata uint8_t usb_ep0_state;
-uint8_t * __xdata usb_ep0_in_data;
+const uint8_t * __xdata usb_ep0_in_data;
 __xdata uint8_t usb_ep0_in_len;
 __xdata uint8_t usb_ep0_in_buf[2];
 __xdata uint8_t usb_ep0_out_len;
@@ -54,7 +54,7 @@ __xdata uint8_t *__xdata usb_ep0_out_data;
 __xdata uint8_t usb_configuration;
 
 // Send an IN data packet
-static void usb_ep0_flush()
+static void usb_ep0_flush(void)
 {
   __xdata uint8_t this_len;
   __xdata uint8_t cs0;
@@ -104,7 +104,7 @@ static void usb_get_descriptor(uint16_t value)
 }
 
 // Read data from the ep0 OUT fifo
-static void usb_ep0_fill()
+static void usb_ep0_fill(void)
 {
   __xdata uint8_t len;
 
@@ -129,7 +129,7 @@ void usb_set_address (uint8_t address)
   while (USBADDR & 0x80) {}
 }
 
-static void usb_set_configuration()
+static void usb_set_configuration(void)
 {
   // Set the IN max packet size, double buffered
   USBINDEX = USB_IN_EP;
@@ -142,7 +142,7 @@ static void usb_set_configuration()
   USBCSOH = USBCSOH_OUT_DBL_BUF;
 }
 
-static void usb_ep0_setup()
+static void usb_ep0_setup(void)
 {
   // Pull the setup packet out of the fifo
   usb_ep0_out_data = (__xdata uint8_t *) &usb_setup;
@@ -243,7 +243,7 @@ static void usb_ep0_setup()
 
 // End point 0 receives all of the control messages.
 // This function must be called periodically to process ep0 messages.
-static void usb_ep0()
+static void usb_ep0(void)
 {
   __xdata uint8_t cs0;
 
@@ -256,7 +256,7 @@ static void usb_ep0()
     cs0 = USBCS0;
     if (cs0 & USBCS0_SETUP_END) {
       usb_ep0_state = USB_EP0_IDLE;
-      USBCS0 = USBCS0_CLR_SETUP_END;
+      USBCS0 = (uint8_t)USBCS0_CLR_SETUP_END;
     }
     if (cs0 & USBCS0_SENT_STALL) {
       usb_ep0_state = USB_EP0_IDLE;
@@ -289,7 +289,7 @@ static void usb_ep0()
 
 // This interrupt is shared with port 2,
 // so when we hook that up, fix this
-void usb_isr() __interrupt 6
+void usb_isr(void) __interrupt (6)
 {
   USBIF = 0;
   usb_iif |= USBIIF;
@@ -300,7 +300,7 @@ void usb_isr() __interrupt 6
 }
 
 // Wait for a free IN buffer
-static void usb_in_wait()
+static void usb_in_wait(void)
 {
   while (1) {
     USBINDEX = USB_IN_EP;
@@ -311,7 +311,7 @@ static void usb_in_wait()
 }
 
 // Send the current IN packet
-static void usb_in_send()
+static void usb_in_send(void)
 {
   USBINDEX = USB_IN_EP;
   USBCSIL |= USBCSIL_INPKT_RDY;
@@ -319,7 +319,7 @@ static void usb_in_send()
   usb_in_bytes = 0;
 }
 
-void usb_flush()
+void usb_flush(void)
 {
   if (!usb_running)
     return;
@@ -345,7 +345,7 @@ void usb_putchar(char c) __reentrant
     usb_in_send();
 }
 
-char usb_pollchar()
+char usb_pollchar(void)
 {
   char c;
   if (usb_out_bytes == 0) {
@@ -368,7 +368,7 @@ char usb_pollchar()
   return c;
 }
 
-char usb_getchar()
+char usb_getchar(void)
 {
   char c;
   while ((c = usb_pollchar()) == USB_READ_AGAIN)
@@ -378,7 +378,7 @@ char usb_getchar()
   return c;
 }
 
-void usb_enable()
+void usb_enable(void)
 {
   // Turn on the USB controller
   SLEEP |= SLEEP_USB_EN;
@@ -396,7 +396,7 @@ void usb_enable()
   USBIF = 0;
 }
 
-void usb_disable()
+void usb_disable(void)
 {
   // Disable USB interrupts
   USBIIE = 0;
@@ -413,7 +413,7 @@ void usb_disable()
   SLEEP &= ~SLEEP_USB_EN;
 }
 
-void usb_init()
+void usb_init(void)
 {
   // Init ep0
 	usb_ep0_state = USB_EP0_IDLE;
diff --git a/src/usb.h b/src/usb.h
index f3f606a..3352b70 100644
--- a/src/usb.h
+++ b/src/usb.h
@@ -25,12 +25,12 @@
 
 // External interface
 
-void usb_init();
-void usb_disable();
-void usb_enable();
-char usb_getchar();
+void usb_init(void);
+void usb_disable(void);
+void usb_enable(void);
+char usb_getchar(void);
 void usb_putchar(char c);
-void usb_flush();
+void usb_flush(void);
 
 void usb_putstr(char* buff);
 void usb_readline(char* buff);
@@ -38,7 +38,7 @@ void usb_readline(char* buff);
 // End external interface
 
 // USB interrupt handler
-void usb_isr() __interrupt 6;
+void usb_isr(void) __interrupt (6);
 
 #define USB_SETUP_DIR_MASK    (0x01 << 7)
 #define USB_SETUP_TYPE_MASK   (0x03 << 5)

From 63f8d1db2523ec1f5afcc8ba646ff0f8b628abf6 Mon Sep 17 00:00:00 2001
From: the-snork <none>
Date: Sat, 4 Nov 2023 20:56:08 +0100
Subject: [PATCH 2/2] forgot to commit

---
 src/main.c | 21 ++-------------------
 1 file changed, 2 insertions(+), 19 deletions(-)

diff --git a/src/main.c b/src/main.c
index 32acc96..57f8e34 100644
--- a/src/main.c
+++ b/src/main.c
@@ -83,15 +83,7 @@ void jump_to_user(void) {
       ljmp #USER_CODE_BASE
     __endasm;
     while (1) {}
-  } else {
-    #ifdef RFCAT
-    return; // need to run bootloader!
-    #else
-    // Oops, no payload. We're stuck now!
-    led_on();
-    while (1) {}
-    #endif
-  }
+  } 
 }
 
 #ifdef TIMER
@@ -177,7 +169,6 @@ uint8_t want_bootloader(void) {
     return 0;
   */
 
-  #ifdef RFCAT 
   // we use the unused I2S SFRs as semaphores.
   // this would be safe even if I2S is in use as they should be reconfigured by 
   // user code 
@@ -185,9 +176,6 @@ uint8_t want_bootloader(void) {
     return 1;
   // no thanks
   return 0;
-  #else
-  return 1;
-  #endif
 }
 
 void bootloader_main (void)
@@ -196,7 +184,6 @@ void bootloader_main (void)
   uint8_t ihx_status;
   uint16_t read_start_addr, read_len;
 
-#ifdef RFCAT
   // use I2S SFR to signal that bootloader is present
   I2SCLKF0= 0xF0;
   I2SCLKF1= 0x0D;
@@ -216,14 +203,10 @@ void bootloader_main (void)
   if (CC1111YSONE_PIN_DC != GROUNDED && !want_bootloader())
   #endif
 
-#else
-  if (!want_bootloader())
-#endif
     jump_to_user();
-#ifdef RFCAT
+
   // reset semaphore 
   I2SCLKF2= 0x00;
-#endif
 
   clock_init();