Second damaging battlerage skill (skill 4) not in use [version 1.9-pre-ae01b23-moveBattlerageToAttainment]

[ose-goetia]

I downloaded version 1.9-pre-ae01b23-moveBattlerageToAttainment.

Using both the 'simple' and 'simplereverse' strategies, bashing is not using my second damaging rage (skill 4) (throatrip as a serpent), and a sentinel confirmed it was only using their first battlerage attack. I am using my autoraze skill (skill 3) properly.

Portals and theft are present in my battlerage list. I am not sure how to check the value of battlerageSkills[4] to confirm if the skill is present or not.

[keneanung]

Could you give me the output of AB ATTAINMENT?

[ose-goetia]

Formatting came through awful when I tried to copy and paste -- here's the attainment output in an image:

https://i.imgur.com/S41oBD9.png

[adayoung]

It's because gmcp.IRE.Display.ButtonActions is broken for some classes. That makes keneanung.bashing.rageAvailable go weird. Here's what I'm seeing for Runewarden:

{
  button2 = {
    text = "Portals",
    highlight = 0,
    commands = "portals"
  },
  button6 = {
    text = "Market",
    highlight = 0,
    commands = [[
marketon
marketoff
market <text>]]
  },
  button1 = {
    text = "Jab",
    highlight = 0,
    commands = "JAB @tar"
  },
  button7 = {
    text = "Battle",
    highlight = 0,
    commands = ""
  },
  button5 = {
    text = "Bulwark",
    highlight = 0,
    commands = "bulwark"
  },
  button4 = {
    text = "Battlerage",
    highlight = 0,
    commands = ""
  },
  button3 = {
    text = "Collide",
    highlight = 0,
    commands = "collide @tar"
  }
}

[adayoung]

And here's gmcp.IRE.Display.ButtonActions for Dragon:

{
  button2 = {
    text = "Portals",
    highlight = 1,
    commands = "portals"
  },
  button6 = {
    text = "Market",
    highlight = 1,
    commands = [[
marketon
marketoff
market <text>]]
  },
  button1 = {
    text = "Gut",
    highlight = 0,
    commands = "GUT @tar"
  },
  button7 = {
    text = "Battle",
    highlight = 1,
    commands = ""
  },
  button5 = {
    text = "Glaciate",
    highlight = 0,
    commands = "glaciate @tar"
  },
  button4 = {
    text = "Battlerage",
    highlight = 1,
    commands = ""
  },
  button3 = {
    text = "Dragonchill",
    highlight = 0,
    commands = "dragonchill @tar"
  }
}

[keneanung]

Does that mean these buttons are newly broken?

[adayoung]

Yeah. Here's what I got for blademaster:

{
  button2 = {
    text = "Portals",
    highlight = 1,
    commands = "portals"
  },
  button6 = {
    text = "Market",
    highlight = 1,
    commands = [[
marketon
marketoff
market <text>]]
  },
  button1 = {
    text = "Drawslash",
    highlight = 0,
    commands = "DRAWSLASH @tar"
  },
  button7 = {
    text = "Battle",
    highlight = 1,
    commands = ""
  },
  button5 = {
    text = "Daze",
    highlight = 0,
    commands = "shin daze @tar"
  },
  button4 = {
    text = "Battlerage",
    highlight = 1,
    commands = ""
  },
  button3 = {
    text = "Leapstrike",
    highlight = 0,
    commands = "leapstrike @tar"
  }
}

[adayoung]

Oops, I hope I'm not spamming by now 😊 Perhaps we need to use cooldowns instead of those buttons?

[adayoung]

What if we have another table to say whether a battlerage skill is on a cooldown, update it whenever a battlerage ability is used, and flip it back with a temptimer? keneanung.bashing.rageAvailable is essentially looking at cooldown from serverside right? 😮

[keneanung]

That and if enough rage is available for the ability. Yes, we could do tempTimers or timeframes, but I loved the idea to let the server do the work for me 😏

And I hope IRE cares enough about their nexus users to fix those buttons.

It's probably best to add at least a failsafe in case the buttons are broken (like now) or the user removes their rage buttons. This solution still comes from a time where these buttons were fixed IIRC.

[adayoung]

Hi! I opened #63 for this and with that, it's working as it used to! 😁

[ose-goetia]

Took me a while to test but I can confirm that the release in #63 makes everything work as intended, thank you

[ose-goetia]

The issue seems to have reappeared -- I'm assuming IRE must've changed something recently. I thought that it was my installation being goofy, so I updated from @adayoung 's 1.9-pre-2594940-cooldown2rageAvailable version in #63 to v1.9-pre-fae97a7-moveBattlerageToAttainment (latest release), though I think they may be the same thing, and there was no change. My Attainment skill list hasn't changed.

When I have enough rage, it seems like it waits until I also have enough rage for my weaker battlerage before using it, but never uses my throatrip.

The issue is still happening, and was never resolved with release v1.9-pre-fae97a7-moveBattlerageToAttainment for me. I've been using it for a few weeks now, and it never uses my 4th battlerage skill (2nd damaging one) in Bard or in Black Dragon.

I can also confirm that my custom battlerage strategy isn't working, where previously it worked before. I can copy the code for my custom strat in here and show any errors if you need.

[adayoung]

@Agzohmqueks, you're about the third black dragon that has complained on this. Let me have a look at it this weekend. Can I pounce you in-game to run some tests as well?!