-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
code qualityRefactoring and other improvements to code qualityRefactoring and other improvements to code qualitydocumentationImprovements or additions to documentationImprovements or additions to documentation
Description
- Add a comment with more info on the normalization in
mouseposition()- presumably: normalization to [-1, 1] and inverting the y axis to go from DOM to three.js world space
- Simplify if-statements in
updateSelectionBox(),attachSingleTransformControl(), andupdateSelection()- reduce unnecessary nesting of if-statements and merge if-branches with the same outcome/shared code
- set
showX = (axis === "X")etc directly if possible
- Consistence use of
this.#selectedObject,this.#transformControls.object, andthis.#selectedObjects[0]- Should they be identical (in most cases) or are there significant differences?
- If identical → is it sufficient to just use
this.#selectedObject? - If not identical → clarify how they differ
- Check if
deselectAll()should reset thethis.#selectedObject - Should
itemSelectedEvent()be renamed todispatchItemSelectedEvent()? - In
setUpMouseEvents(): find a better name forcanvasChildor add a comment explaining what exactly the last child of canvas is - Can we use
this.#canvasinitemSelectedEvent()?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
code qualityRefactoring and other improvements to code qualityRefactoring and other improvements to code qualitydocumentationImprovements or additions to documentationImprovements or additions to documentation